1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Copyright (c) 2017 Linaro Limited. All rights reserved.
4  *
5  * Author: Leo Yan <leo.yan@linaro.org>
6  */
7 #include <linux/amba/bus.h>
8 #include <linux/coresight.h>
9 #include <linux/cpu.h>
10 #include <linux/debugfs.h>
11 #include <linux/delay.h>
12 #include <linux/device.h>
13 #include <linux/err.h>
14 #include <linux/init.h>
15 #include <linux/io.h>
16 #include <linux/iopoll.h>
17 #include <linux/kernel.h>
18 #include <linux/module.h>
19 #include <linux/moduleparam.h>
20 #include <linux/pm_qos.h>
21 #include <linux/slab.h>
22 #include <linux/smp.h>
23 #include <linux/types.h>
24 #include <linux/uaccess.h>
25 
26 #include "coresight-priv.h"
27 
28 #define EDPCSR				0x0A0
29 #define EDCIDSR				0x0A4
30 #define EDVIDSR				0x0A8
31 #define EDPCSR_HI			0x0AC
32 #define EDOSLAR				0x300
33 #define EDPRCR				0x310
34 #define EDPRSR				0x314
35 #define EDDEVID1			0xFC4
36 #define EDDEVID				0xFC8
37 
38 #define EDPCSR_PROHIBITED		0xFFFFFFFF
39 
40 /* bits definition for EDPCSR */
41 #define EDPCSR_THUMB			BIT(0)
42 #define EDPCSR_ARM_INST_MASK		GENMASK(31, 2)
43 #define EDPCSR_THUMB_INST_MASK		GENMASK(31, 1)
44 
45 /* bits definition for EDPRCR */
46 #define EDPRCR_COREPURQ			BIT(3)
47 #define EDPRCR_CORENPDRQ		BIT(0)
48 
49 /* bits definition for EDPRSR */
50 #define EDPRSR_DLK			BIT(6)
51 #define EDPRSR_PU			BIT(0)
52 
53 /* bits definition for EDVIDSR */
54 #define EDVIDSR_NS			BIT(31)
55 #define EDVIDSR_E2			BIT(30)
56 #define EDVIDSR_E3			BIT(29)
57 #define EDVIDSR_HV			BIT(28)
58 #define EDVIDSR_VMID			GENMASK(7, 0)
59 
60 /*
61  * bits definition for EDDEVID1:PSCROffset
62  *
63  * NOTE: armv8 and armv7 have different definition for the register,
64  * so consolidate the bits definition as below:
65  *
66  * 0b0000 - Sample offset applies based on the instruction state, we
67  *          rely on EDDEVID to check if EDPCSR is implemented or not
68  * 0b0001 - No offset applies.
69  * 0b0010 - No offset applies, but do not use in AArch32 mode
70  *
71  */
72 #define EDDEVID1_PCSR_OFFSET_MASK	GENMASK(3, 0)
73 #define EDDEVID1_PCSR_OFFSET_INS_SET	(0x0)
74 #define EDDEVID1_PCSR_NO_OFFSET_DIS_AARCH32	(0x2)
75 
76 /* bits definition for EDDEVID */
77 #define EDDEVID_PCSAMPLE_MODE		GENMASK(3, 0)
78 #define EDDEVID_IMPL_EDPCSR		(0x1)
79 #define EDDEVID_IMPL_EDPCSR_EDCIDSR	(0x2)
80 #define EDDEVID_IMPL_FULL		(0x3)
81 
82 #define DEBUG_WAIT_SLEEP		1000
83 #define DEBUG_WAIT_TIMEOUT		32000
84 
85 struct debug_drvdata {
86 	void __iomem	*base;
87 	struct device	*dev;
88 	int		cpu;
89 
90 	bool		edpcsr_present;
91 	bool		edcidsr_present;
92 	bool		edvidsr_present;
93 	bool		pc_has_offset;
94 
95 	u32		edpcsr;
96 	u32		edpcsr_hi;
97 	u32		edprsr;
98 	u32		edvidsr;
99 	u32		edcidsr;
100 };
101 
102 static DEFINE_MUTEX(debug_lock);
103 static DEFINE_PER_CPU(struct debug_drvdata *, debug_drvdata);
104 static int debug_count;
105 static struct dentry *debug_debugfs_dir;
106 
107 static bool debug_enable;
108 module_param_named(enable, debug_enable, bool, 0600);
109 MODULE_PARM_DESC(enable, "Control to enable coresight CPU debug functionality");
110 
debug_os_unlock(struct debug_drvdata *drvdata)111 static void debug_os_unlock(struct debug_drvdata *drvdata)
112 {
113 	/* Unlocks the debug registers */
114 	writel_relaxed(0x0, drvdata->base + EDOSLAR);
115 
116 	/* Make sure the registers are unlocked before accessing */
117 	wmb();
118 }
119 
120 /*
121  * According to ARM DDI 0487A.k, before access external debug
122  * registers should firstly check the access permission; if any
123  * below condition has been met then cannot access debug
124  * registers to avoid lockup issue:
125  *
126  * - CPU power domain is powered off;
127  * - The OS Double Lock is locked;
128  *
129  * By checking EDPRSR can get to know if meet these conditions.
130  */
debug_access_permitted(struct debug_drvdata *drvdata)131 static bool debug_access_permitted(struct debug_drvdata *drvdata)
132 {
133 	/* CPU is powered off */
134 	if (!(drvdata->edprsr & EDPRSR_PU))
135 		return false;
136 
137 	/* The OS Double Lock is locked */
138 	if (drvdata->edprsr & EDPRSR_DLK)
139 		return false;
140 
141 	return true;
142 }
143 
debug_force_cpu_powered_up(struct debug_drvdata *drvdata)144 static void debug_force_cpu_powered_up(struct debug_drvdata *drvdata)
145 {
146 	u32 edprcr;
147 
148 try_again:
149 
150 	/*
151 	 * Send request to power management controller and assert
152 	 * DBGPWRUPREQ signal; if power management controller has
153 	 * sane implementation, it should enable CPU power domain
154 	 * in case CPU is in low power state.
155 	 */
156 	edprcr = readl_relaxed(drvdata->base + EDPRCR);
157 	edprcr |= EDPRCR_COREPURQ;
158 	writel_relaxed(edprcr, drvdata->base + EDPRCR);
159 
160 	/* Wait for CPU to be powered up (timeout~=32ms) */
161 	if (readx_poll_timeout_atomic(readl_relaxed, drvdata->base + EDPRSR,
162 			drvdata->edprsr, (drvdata->edprsr & EDPRSR_PU),
163 			DEBUG_WAIT_SLEEP, DEBUG_WAIT_TIMEOUT)) {
164 		/*
165 		 * Unfortunately the CPU cannot be powered up, so return
166 		 * back and later has no permission to access other
167 		 * registers. For this case, should disable CPU low power
168 		 * states to ensure CPU power domain is enabled!
169 		 */
170 		dev_err(drvdata->dev, "%s: power up request for CPU%d failed\n",
171 			__func__, drvdata->cpu);
172 		return;
173 	}
174 
175 	/*
176 	 * At this point the CPU is powered up, so set the no powerdown
177 	 * request bit so we don't lose power and emulate power down.
178 	 */
179 	edprcr = readl_relaxed(drvdata->base + EDPRCR);
180 	edprcr |= EDPRCR_COREPURQ | EDPRCR_CORENPDRQ;
181 	writel_relaxed(edprcr, drvdata->base + EDPRCR);
182 
183 	drvdata->edprsr = readl_relaxed(drvdata->base + EDPRSR);
184 
185 	/* The core power domain got switched off on use, try again */
186 	if (unlikely(!(drvdata->edprsr & EDPRSR_PU)))
187 		goto try_again;
188 }
189 
debug_read_regs(struct debug_drvdata *drvdata)190 static void debug_read_regs(struct debug_drvdata *drvdata)
191 {
192 	u32 save_edprcr;
193 
194 	CS_UNLOCK(drvdata->base);
195 
196 	/* Unlock os lock */
197 	debug_os_unlock(drvdata);
198 
199 	/* Save EDPRCR register */
200 	save_edprcr = readl_relaxed(drvdata->base + EDPRCR);
201 
202 	/*
203 	 * Ensure CPU power domain is enabled to let registers
204 	 * are accessiable.
205 	 */
206 	debug_force_cpu_powered_up(drvdata);
207 
208 	if (!debug_access_permitted(drvdata))
209 		goto out;
210 
211 	drvdata->edpcsr = readl_relaxed(drvdata->base + EDPCSR);
212 
213 	/*
214 	 * As described in ARM DDI 0487A.k, if the processing
215 	 * element (PE) is in debug state, or sample-based
216 	 * profiling is prohibited, EDPCSR reads as 0xFFFFFFFF;
217 	 * EDCIDSR, EDVIDSR and EDPCSR_HI registers also become
218 	 * UNKNOWN state. So directly bail out for this case.
219 	 */
220 	if (drvdata->edpcsr == EDPCSR_PROHIBITED)
221 		goto out;
222 
223 	/*
224 	 * A read of the EDPCSR normally has the side-effect of
225 	 * indirectly writing to EDCIDSR, EDVIDSR and EDPCSR_HI;
226 	 * at this point it's safe to read value from them.
227 	 */
228 	if (IS_ENABLED(CONFIG_64BIT))
229 		drvdata->edpcsr_hi = readl_relaxed(drvdata->base + EDPCSR_HI);
230 
231 	if (drvdata->edcidsr_present)
232 		drvdata->edcidsr = readl_relaxed(drvdata->base + EDCIDSR);
233 
234 	if (drvdata->edvidsr_present)
235 		drvdata->edvidsr = readl_relaxed(drvdata->base + EDVIDSR);
236 
237 out:
238 	/* Restore EDPRCR register */
239 	writel_relaxed(save_edprcr, drvdata->base + EDPRCR);
240 
241 	CS_LOCK(drvdata->base);
242 }
243 
244 #ifdef CONFIG_64BIT
debug_adjust_pc(struct debug_drvdata *drvdata)245 static unsigned long debug_adjust_pc(struct debug_drvdata *drvdata)
246 {
247 	return (unsigned long)drvdata->edpcsr_hi << 32 |
248 	       (unsigned long)drvdata->edpcsr;
249 }
250 #else
debug_adjust_pc(struct debug_drvdata *drvdata)251 static unsigned long debug_adjust_pc(struct debug_drvdata *drvdata)
252 {
253 	unsigned long arm_inst_offset = 0, thumb_inst_offset = 0;
254 	unsigned long pc;
255 
256 	pc = (unsigned long)drvdata->edpcsr;
257 
258 	if (drvdata->pc_has_offset) {
259 		arm_inst_offset = 8;
260 		thumb_inst_offset = 4;
261 	}
262 
263 	/* Handle thumb instruction */
264 	if (pc & EDPCSR_THUMB) {
265 		pc = (pc & EDPCSR_THUMB_INST_MASK) - thumb_inst_offset;
266 		return pc;
267 	}
268 
269 	/*
270 	 * Handle arm instruction offset, if the arm instruction
271 	 * is not 4 byte alignment then it's possible the case
272 	 * for implementation defined; keep original value for this
273 	 * case and print info for notice.
274 	 */
275 	if (pc & BIT(1))
276 		dev_emerg(drvdata->dev,
277 			  "Instruction offset is implementation defined\n");
278 	else
279 		pc = (pc & EDPCSR_ARM_INST_MASK) - arm_inst_offset;
280 
281 	return pc;
282 }
283 #endif
284 
debug_dump_regs(struct debug_drvdata *drvdata)285 static void debug_dump_regs(struct debug_drvdata *drvdata)
286 {
287 	struct device *dev = drvdata->dev;
288 	unsigned long pc;
289 
290 	dev_emerg(dev, " EDPRSR:  %08x (Power:%s DLK:%s)\n",
291 		  drvdata->edprsr,
292 		  drvdata->edprsr & EDPRSR_PU ? "On" : "Off",
293 		  drvdata->edprsr & EDPRSR_DLK ? "Lock" : "Unlock");
294 
295 	if (!debug_access_permitted(drvdata)) {
296 		dev_emerg(dev, "No permission to access debug registers!\n");
297 		return;
298 	}
299 
300 	if (drvdata->edpcsr == EDPCSR_PROHIBITED) {
301 		dev_emerg(dev, "CPU is in Debug state or profiling is prohibited!\n");
302 		return;
303 	}
304 
305 	pc = debug_adjust_pc(drvdata);
306 	dev_emerg(dev, " EDPCSR:  %pS\n", (void *)pc);
307 
308 	if (drvdata->edcidsr_present)
309 		dev_emerg(dev, " EDCIDSR: %08x\n", drvdata->edcidsr);
310 
311 	if (drvdata->edvidsr_present)
312 		dev_emerg(dev, " EDVIDSR: %08x (State:%s Mode:%s Width:%dbits VMID:%x)\n",
313 			  drvdata->edvidsr,
314 			  drvdata->edvidsr & EDVIDSR_NS ?
315 			  "Non-secure" : "Secure",
316 			  drvdata->edvidsr & EDVIDSR_E3 ? "EL3" :
317 				(drvdata->edvidsr & EDVIDSR_E2 ?
318 				 "EL2" : "EL1/0"),
319 			  drvdata->edvidsr & EDVIDSR_HV ? 64 : 32,
320 			  drvdata->edvidsr & (u32)EDVIDSR_VMID);
321 }
322 
debug_init_arch_data(void *info)323 static void debug_init_arch_data(void *info)
324 {
325 	struct debug_drvdata *drvdata = info;
326 	u32 mode, pcsr_offset;
327 	u32 eddevid, eddevid1;
328 
329 	CS_UNLOCK(drvdata->base);
330 
331 	/* Read device info */
332 	eddevid  = readl_relaxed(drvdata->base + EDDEVID);
333 	eddevid1 = readl_relaxed(drvdata->base + EDDEVID1);
334 
335 	CS_LOCK(drvdata->base);
336 
337 	/* Parse implementation feature */
338 	mode = eddevid & EDDEVID_PCSAMPLE_MODE;
339 	pcsr_offset = eddevid1 & EDDEVID1_PCSR_OFFSET_MASK;
340 
341 	drvdata->edpcsr_present  = false;
342 	drvdata->edcidsr_present = false;
343 	drvdata->edvidsr_present = false;
344 	drvdata->pc_has_offset   = false;
345 
346 	switch (mode) {
347 	case EDDEVID_IMPL_FULL:
348 		drvdata->edvidsr_present = true;
349 		fallthrough;
350 	case EDDEVID_IMPL_EDPCSR_EDCIDSR:
351 		drvdata->edcidsr_present = true;
352 		fallthrough;
353 	case EDDEVID_IMPL_EDPCSR:
354 		/*
355 		 * In ARM DDI 0487A.k, the EDDEVID1.PCSROffset is used to
356 		 * define if has the offset for PC sampling value; if read
357 		 * back EDDEVID1.PCSROffset == 0x2, then this means the debug
358 		 * module does not sample the instruction set state when
359 		 * armv8 CPU in AArch32 state.
360 		 */
361 		drvdata->edpcsr_present =
362 			((IS_ENABLED(CONFIG_64BIT) && pcsr_offset != 0) ||
363 			 (pcsr_offset != EDDEVID1_PCSR_NO_OFFSET_DIS_AARCH32));
364 
365 		drvdata->pc_has_offset =
366 			(pcsr_offset == EDDEVID1_PCSR_OFFSET_INS_SET);
367 		break;
368 	default:
369 		break;
370 	}
371 }
372 
373 /*
374  * Dump out information on panic.
375  */
debug_notifier_call(struct notifier_block *self, unsigned long v, void *p)376 static int debug_notifier_call(struct notifier_block *self,
377 			       unsigned long v, void *p)
378 {
379 	int cpu;
380 	struct debug_drvdata *drvdata;
381 
382 	/* Bail out if we can't acquire the mutex or the functionality is off */
383 	if (!mutex_trylock(&debug_lock))
384 		return NOTIFY_DONE;
385 
386 	if (!debug_enable)
387 		goto skip_dump;
388 
389 	pr_emerg("ARM external debug module:\n");
390 
391 	for_each_possible_cpu(cpu) {
392 		drvdata = per_cpu(debug_drvdata, cpu);
393 		if (!drvdata)
394 			continue;
395 
396 		dev_emerg(drvdata->dev, "CPU[%d]:\n", drvdata->cpu);
397 
398 		debug_read_regs(drvdata);
399 		debug_dump_regs(drvdata);
400 	}
401 
402 skip_dump:
403 	mutex_unlock(&debug_lock);
404 	return NOTIFY_DONE;
405 }
406 
407 static struct notifier_block debug_notifier = {
408 	.notifier_call = debug_notifier_call,
409 };
410 
debug_enable_func(void)411 static int debug_enable_func(void)
412 {
413 	struct debug_drvdata *drvdata;
414 	int cpu, ret = 0;
415 	cpumask_t mask;
416 
417 	/*
418 	 * Use cpumask to track which debug power domains have
419 	 * been powered on and use it to handle failure case.
420 	 */
421 	cpumask_clear(&mask);
422 
423 	for_each_possible_cpu(cpu) {
424 		drvdata = per_cpu(debug_drvdata, cpu);
425 		if (!drvdata)
426 			continue;
427 
428 		ret = pm_runtime_get_sync(drvdata->dev);
429 		if (ret < 0)
430 			goto err;
431 		else
432 			cpumask_set_cpu(cpu, &mask);
433 	}
434 
435 	return 0;
436 
437 err:
438 	/*
439 	 * If pm_runtime_get_sync() has failed, need rollback on
440 	 * all the other CPUs that have been enabled before that.
441 	 */
442 	for_each_cpu(cpu, &mask) {
443 		drvdata = per_cpu(debug_drvdata, cpu);
444 		pm_runtime_put_noidle(drvdata->dev);
445 	}
446 
447 	return ret;
448 }
449 
debug_disable_func(void)450 static int debug_disable_func(void)
451 {
452 	struct debug_drvdata *drvdata;
453 	int cpu, ret, err = 0;
454 
455 	/*
456 	 * Disable debug power domains, records the error and keep
457 	 * circling through all other CPUs when an error has been
458 	 * encountered.
459 	 */
460 	for_each_possible_cpu(cpu) {
461 		drvdata = per_cpu(debug_drvdata, cpu);
462 		if (!drvdata)
463 			continue;
464 
465 		ret = pm_runtime_put(drvdata->dev);
466 		if (ret < 0)
467 			err = ret;
468 	}
469 
470 	return err;
471 }
472 
debug_func_knob_write(struct file *f, const char __user *buf, size_t count, loff_t *ppos)473 static ssize_t debug_func_knob_write(struct file *f,
474 		const char __user *buf, size_t count, loff_t *ppos)
475 {
476 	u8 val;
477 	int ret;
478 
479 	ret = kstrtou8_from_user(buf, count, 2, &val);
480 	if (ret)
481 		return ret;
482 
483 	mutex_lock(&debug_lock);
484 
485 	if (val == debug_enable)
486 		goto out;
487 
488 	if (val)
489 		ret = debug_enable_func();
490 	else
491 		ret = debug_disable_func();
492 
493 	if (ret) {
494 		pr_err("%s: unable to %s debug function: %d\n",
495 		       __func__, val ? "enable" : "disable", ret);
496 		goto err;
497 	}
498 
499 	debug_enable = val;
500 out:
501 	ret = count;
502 err:
503 	mutex_unlock(&debug_lock);
504 	return ret;
505 }
506 
debug_func_knob_read(struct file *f, char __user *ubuf, size_t count, loff_t *ppos)507 static ssize_t debug_func_knob_read(struct file *f,
508 		char __user *ubuf, size_t count, loff_t *ppos)
509 {
510 	ssize_t ret;
511 	char buf[3];
512 
513 	mutex_lock(&debug_lock);
514 	snprintf(buf, sizeof(buf), "%d\n", debug_enable);
515 	mutex_unlock(&debug_lock);
516 
517 	ret = simple_read_from_buffer(ubuf, count, ppos, buf, sizeof(buf));
518 	return ret;
519 }
520 
521 static const struct file_operations debug_func_knob_fops = {
522 	.open	= simple_open,
523 	.read	= debug_func_knob_read,
524 	.write	= debug_func_knob_write,
525 };
526 
debug_func_init(void)527 static int debug_func_init(void)
528 {
529 	int ret;
530 
531 	/* Create debugfs node */
532 	debug_debugfs_dir = debugfs_create_dir("coresight_cpu_debug", NULL);
533 	debugfs_create_file("enable", 0644, debug_debugfs_dir, NULL,
534 			    &debug_func_knob_fops);
535 
536 	/* Register function to be called for panic */
537 	ret = atomic_notifier_chain_register(&panic_notifier_list,
538 					     &debug_notifier);
539 	if (ret) {
540 		pr_err("%s: unable to register notifier: %d\n",
541 		       __func__, ret);
542 		goto err;
543 	}
544 
545 	return 0;
546 
547 err:
548 	debugfs_remove_recursive(debug_debugfs_dir);
549 	return ret;
550 }
551 
debug_func_exit(void)552 static void debug_func_exit(void)
553 {
554 	atomic_notifier_chain_unregister(&panic_notifier_list,
555 					 &debug_notifier);
556 	debugfs_remove_recursive(debug_debugfs_dir);
557 }
558 
debug_probe(struct amba_device *adev, const struct amba_id *id)559 static int debug_probe(struct amba_device *adev, const struct amba_id *id)
560 {
561 	void __iomem *base;
562 	struct device *dev = &adev->dev;
563 	struct debug_drvdata *drvdata;
564 	struct resource *res = &adev->res;
565 	int ret;
566 
567 	drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
568 	if (!drvdata)
569 		return -ENOMEM;
570 
571 	drvdata->cpu = coresight_get_cpu(dev);
572 	if (drvdata->cpu < 0)
573 		return drvdata->cpu;
574 
575 	if (per_cpu(debug_drvdata, drvdata->cpu)) {
576 		dev_err(dev, "CPU%d drvdata has already been initialized\n",
577 			drvdata->cpu);
578 		return -EBUSY;
579 	}
580 
581 	drvdata->dev = &adev->dev;
582 	amba_set_drvdata(adev, drvdata);
583 
584 	/* Validity for the resource is already checked by the AMBA core */
585 	base = devm_ioremap_resource(dev, res);
586 	if (IS_ERR(base))
587 		return PTR_ERR(base);
588 
589 	drvdata->base = base;
590 
591 	get_online_cpus();
592 	per_cpu(debug_drvdata, drvdata->cpu) = drvdata;
593 	ret = smp_call_function_single(drvdata->cpu, debug_init_arch_data,
594 				       drvdata, 1);
595 	put_online_cpus();
596 
597 	if (ret) {
598 		dev_err(dev, "CPU%d debug arch init failed\n", drvdata->cpu);
599 		goto err;
600 	}
601 
602 	if (!drvdata->edpcsr_present) {
603 		dev_err(dev, "CPU%d sample-based profiling isn't implemented\n",
604 			drvdata->cpu);
605 		ret = -ENXIO;
606 		goto err;
607 	}
608 
609 	if (!debug_count++) {
610 		ret = debug_func_init();
611 		if (ret)
612 			goto err_func_init;
613 	}
614 
615 	mutex_lock(&debug_lock);
616 	/* Turn off debug power domain if debugging is disabled */
617 	if (!debug_enable)
618 		pm_runtime_put(dev);
619 	mutex_unlock(&debug_lock);
620 
621 	dev_info(dev, "Coresight debug-CPU%d initialized\n", drvdata->cpu);
622 	return 0;
623 
624 err_func_init:
625 	debug_count--;
626 err:
627 	per_cpu(debug_drvdata, drvdata->cpu) = NULL;
628 	return ret;
629 }
630 
debug_remove(struct amba_device *adev)631 static void debug_remove(struct amba_device *adev)
632 {
633 	struct device *dev = &adev->dev;
634 	struct debug_drvdata *drvdata = amba_get_drvdata(adev);
635 
636 	per_cpu(debug_drvdata, drvdata->cpu) = NULL;
637 
638 	mutex_lock(&debug_lock);
639 	/* Turn off debug power domain before rmmod the module */
640 	if (debug_enable)
641 		pm_runtime_put(dev);
642 	mutex_unlock(&debug_lock);
643 
644 	if (!--debug_count)
645 		debug_func_exit();
646 }
647 
648 static const struct amba_cs_uci_id uci_id_debug[] = {
649 	{
650 		/*  CPU Debug UCI data */
651 		.devarch	= 0x47706a15,
652 		.devarch_mask	= 0xfff0ffff,
653 		.devtype	= 0x00000015,
654 	}
655 };
656 
657 static const struct amba_id debug_ids[] = {
658 	CS_AMBA_ID(0x000bbd03),				/* Cortex-A53 */
659 	CS_AMBA_ID(0x000bbd07),				/* Cortex-A57 */
660 	CS_AMBA_ID(0x000bbd08),				/* Cortex-A72 */
661 	CS_AMBA_ID(0x000bbd09),				/* Cortex-A73 */
662 	CS_AMBA_UCI_ID(0x000f0205, uci_id_debug),	/* Qualcomm Kryo */
663 	CS_AMBA_UCI_ID(0x000f0211, uci_id_debug),	/* Qualcomm Kryo */
664 	{},
665 };
666 
667 MODULE_DEVICE_TABLE(amba, debug_ids);
668 
669 static struct amba_driver debug_driver = {
670 	.drv = {
671 		.name   = "coresight-cpu-debug",
672 		.suppress_bind_attrs = true,
673 	},
674 	.probe		= debug_probe,
675 	.remove		= debug_remove,
676 	.id_table	= debug_ids,
677 };
678 
679 module_amba_driver(debug_driver);
680 
681 MODULE_AUTHOR("Leo Yan <leo.yan@linaro.org>");
682 MODULE_DESCRIPTION("ARM Coresight CPU Debug Driver");
683 MODULE_LICENSE("GPL");
684