1f08c3bdfSopenharmony_ci# Maintainer Patch Review Checklist 2f08c3bdfSopenharmony_ci 3f08c3bdfSopenharmony_ciPatchset should be tested locally and ideally also in maintainer's fork in 4f08c3bdfSopenharmony_ciGitHub Actions on GitHub. 5f08c3bdfSopenharmony_ci 6f08c3bdfSopenharmony_ciNOTE: Travis does only build testing, passing the CI means only that the 7f08c3bdfSopenharmony_ci test compiles fine on variety of different distributions and 8f08c3bdfSopenharmony_ci releases. 9f08c3bdfSopenharmony_ci 10f08c3bdfSopenharmony_ciThe test should be executed at least once locally and should PASS as well. 11f08c3bdfSopenharmony_ci 12f08c3bdfSopenharmony_ciCommit messages should have 13f08c3bdfSopenharmony_ci 14f08c3bdfSopenharmony_ci* Author's `Signed-off-by` tag 15f08c3bdfSopenharmony_ci* Committer's `Reviewed-by` or `Signed-off-by` tag 16f08c3bdfSopenharmony_ci* Check also mailing lists for other reviewers / testers tags, notes and failure reports 17f08c3bdfSopenharmony_ci* `Fixes: hash` if it fixes particular LTP commit 18f08c3bdfSopenharmony_ci* `Fixes: #N` if it fixes github issue number N, so it's automatically closed 19f08c3bdfSopenharmony_ci 20f08c3bdfSopenharmony_ciAfter patch is accepted or rejected, set correct state and archive in 21f08c3bdfSopenharmony_cihttps://patchwork.ozlabs.org/project/ltp/list/[LTP patchwork instance]. 22f08c3bdfSopenharmony_ci 23f08c3bdfSopenharmony_ciAlso update `.github/workflows/wiki-mirror.yml` script which mirrors 24f08c3bdfSopenharmony_ci`doc/*.txt` to LTP wiki (git URL https://github.com/linux-test-project/ltp.wiki.git) 25f08c3bdfSopenharmony_ciif new wiki page is added. 26f08c3bdfSopenharmony_ci 27f08c3bdfSopenharmony_ci## New tests 28f08c3bdfSopenharmony_ciNew test should 29f08c3bdfSopenharmony_ci 30f08c3bdfSopenharmony_ci* Have a record in runtest file 31f08c3bdfSopenharmony_ci* Test should work fine with more than one iteration 32f08c3bdfSopenharmony_ci (e.g. run with `-i 100`) 33f08c3bdfSopenharmony_ci* Have a brief description 34f08c3bdfSopenharmony_ci* License: the default license for new tests is GPL v2 or later, use 35f08c3bdfSopenharmony_ci GPL-2.0-or-later; the licence for test (e.g. GPL-2.0) should not change 36f08c3bdfSopenharmony_ci unless test is completely rewritten 37f08c3bdfSopenharmony_ci* Old copyrights should be kept unless test is completely rewritten 38f08c3bdfSopenharmony_ci 39f08c3bdfSopenharmony_ci### C tests 40f08c3bdfSopenharmony_ci* Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#22-writing-a-test-in-c[C API] 41f08c3bdfSopenharmony_ci* Test binaries are added into corresponding '.gitignore' files 42f08c3bdfSopenharmony_ci* Check coding style with `make check` 43f08c3bdfSopenharmony_ci (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#21-c-coding-style[C coding style]) 44f08c3bdfSopenharmony_ci* Docparse documentation 45f08c3bdfSopenharmony_ci* If a test is a regression test it should include tags 46f08c3bdfSopenharmony_ci (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags]) 47f08c3bdfSopenharmony_ci* When rewriting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux] 48f08c3bdfSopenharmony_ci support should be removed (project has been discontinued). 49f08c3bdfSopenharmony_ci E.g. remove `#ifdef UCLINUX`, replace `FORK_OR_VFORK()` with simple `fork()` or `SAFE_FORK()`. 50f08c3bdfSopenharmony_ci 51f08c3bdfSopenharmony_ci### Shell tests 52f08c3bdfSopenharmony_ci* Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#23-writing-a-testcase-in-shell[shell API] 53f08c3bdfSopenharmony_ci* Check coding style with `make check` 54f08c3bdfSopenharmony_ci (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#132-shell-coding-style[Shell coding style]) 55f08c3bdfSopenharmony_ci* If a test is a regression test it should include related kernel or glibc commits as a comment 56f08c3bdfSopenharmony_ci 57f08c3bdfSopenharmony_ci## LTP library 58f08c3bdfSopenharmony_ciFor patchset touching library please check also 59f08c3bdfSopenharmony_cihttps://github.com/linux-test-project/ltp/wiki/LTP-Library-API-Writing-Guidelines[LTP Library API Writing Guidelines]. 60