153aa9179Sopenharmony_ciFrom f8852184a111f6c4abb38ea3d2b2b91f45347a7a Mon Sep 17 00:00:00 2001
253aa9179Sopenharmony_ciFrom: Nick Wellnhofer <wellnhofer@aevum.de>
353aa9179Sopenharmony_ciDate: Tue, 14 Feb 2023 13:03:13 +0100
453aa9179Sopenharmony_ciSubject: [PATCH] malloc-fail: Fix memory leak in xmlParseEntityDecl
553aa9179Sopenharmony_ci
653aa9179Sopenharmony_ciFound with libFuzzer, see #344.
753aa9179Sopenharmony_ci
853aa9179Sopenharmony_ciReference:https://github.com/GNOME/libxml2/commit/f8852184a111f6c4abb38ea3d2b2b91f45347a7a
953aa9179Sopenharmony_ciConflict:NA
1053aa9179Sopenharmony_ci---
1153aa9179Sopenharmony_ci parser.c | 4 ++--
1253aa9179Sopenharmony_ci 1 file changed, 2 insertions(+), 2 deletions(-)
1353aa9179Sopenharmony_ci
1453aa9179Sopenharmony_cidiff --git a/parser.c b/parser.c
1553aa9179Sopenharmony_ciindex 3aea3e2..37d7dec 100644
1653aa9179Sopenharmony_ci--- a/parser.c
1753aa9179Sopenharmony_ci+++ b/parser.c
1853aa9179Sopenharmony_ci@@ -5518,7 +5518,7 @@ xmlParseEntityDecl(xmlParserCtxtPtr ctxt) {
1953aa9179Sopenharmony_ci 			ctxt->myDoc = xmlNewDoc(SAX_COMPAT_MODE);
2053aa9179Sopenharmony_ci 			if (ctxt->myDoc == NULL) {
2153aa9179Sopenharmony_ci 			    xmlErrMemory(ctxt, "New Doc failed");
2253aa9179Sopenharmony_ci-			    return;
2353aa9179Sopenharmony_ci+			    goto done;
2453aa9179Sopenharmony_ci 			}
2553aa9179Sopenharmony_ci 			ctxt->myDoc->properties = XML_DOC_INTERNAL;
2653aa9179Sopenharmony_ci 		    }
2753aa9179Sopenharmony_ci@@ -5589,7 +5589,7 @@ xmlParseEntityDecl(xmlParserCtxtPtr ctxt) {
2853aa9179Sopenharmony_ci 			    ctxt->myDoc = xmlNewDoc(SAX_COMPAT_MODE);
2953aa9179Sopenharmony_ci 			    if (ctxt->myDoc == NULL) {
3053aa9179Sopenharmony_ci 			        xmlErrMemory(ctxt, "New Doc failed");
3153aa9179Sopenharmony_ci-				return;
3253aa9179Sopenharmony_ci+				goto done;
3353aa9179Sopenharmony_ci 			    }
3453aa9179Sopenharmony_ci 			    ctxt->myDoc->properties = XML_DOC_INTERNAL;
3553aa9179Sopenharmony_ci 			}
3653aa9179Sopenharmony_ci-- 
3753aa9179Sopenharmony_ci2.27.0
3853aa9179Sopenharmony_ci
39