153aa9179Sopenharmony_ciFrom bc7740b3c30e1517dcf53a084766c74d25db222f Mon Sep 17 00:00:00 2001
253aa9179Sopenharmony_ciFrom: Nick Wellnhofer <wellnhofer@aevum.de>
353aa9179Sopenharmony_ciDate: Thu, 16 Feb 2023 11:45:58 +0100
453aa9179Sopenharmony_ciSubject: [PATCH] malloc-fail: Fix memory leak in xmlCopyPropList
553aa9179Sopenharmony_ci
653aa9179Sopenharmony_ciFound with libFuzzer, see #344.
753aa9179Sopenharmony_ci
853aa9179Sopenharmony_ciReference:https://github.com/GNOME/libxml2/commit/bc7740b3c30e1517dcf53a084766c74d25db222f
953aa9179Sopenharmony_ciConflict:NA
1053aa9179Sopenharmony_ci---
1153aa9179Sopenharmony_ci tree.c | 4 +++-
1253aa9179Sopenharmony_ci 1 file changed, 3 insertions(+), 1 deletion(-)
1353aa9179Sopenharmony_ci
1453aa9179Sopenharmony_cidiff --git a/tree.c b/tree.c
1553aa9179Sopenharmony_ciindex ac156e1..35bd948 100644
1653aa9179Sopenharmony_ci--- a/tree.c
1753aa9179Sopenharmony_ci+++ b/tree.c
1853aa9179Sopenharmony_ci@@ -4190,8 +4190,10 @@ xmlCopyPropList(xmlNodePtr target, xmlAttrPtr cur) {
1953aa9179Sopenharmony_ci         return(NULL);
2053aa9179Sopenharmony_ci     while (cur != NULL) {
2153aa9179Sopenharmony_ci         q = xmlCopyProp(target, cur);
2253aa9179Sopenharmony_ci-	if (q == NULL)
2353aa9179Sopenharmony_ci+	if (q == NULL) {
2453aa9179Sopenharmony_ci+            xmlFreePropList(ret);
2553aa9179Sopenharmony_ci 	    return(NULL);
2653aa9179Sopenharmony_ci+        }
2753aa9179Sopenharmony_ci 	if (p == NULL) {
2853aa9179Sopenharmony_ci 	    ret = p = q;
2953aa9179Sopenharmony_ci 	} else {
3053aa9179Sopenharmony_ci-- 
3153aa9179Sopenharmony_ci2.27.0
3253aa9179Sopenharmony_ci
33