1b5975d6bSopenharmony_ciFrom f59e02a1439c70616547d51abf0a6da33e095e80 Mon Sep 17 00:00:00 2001
2b5975d6bSopenharmony_ciFrom: Simon McVittie <smcv@collabora.com>
3b5975d6bSopenharmony_ciDate: Thu, 31 Mar 2022 14:28:56 +0100
4b5975d6bSopenharmony_ciSubject: [PATCH] gioenums: Add G_TLS_CERTIFICATE_FLAGS_NONE
5b5975d6bSopenharmony_ci
6b5975d6bSopenharmony_ciThis makes the absence of flags (in other words, a valid certificate)
7b5975d6bSopenharmony_cimore self-documenting.
8b5975d6bSopenharmony_ci
9b5975d6bSopenharmony_ciSigned-off-by: Simon McVittie <smcv@collabora.com>
10b5975d6bSopenharmony_ci
11b5975d6bSopenharmony_ciConflict:NA
12b5975d6bSopenharmony_ciReference:https://gitlab.gnome.org/GNOME/glib/-/commit/f59e02a1439c70616547d51abf0a6da33e095e80
13b5975d6bSopenharmony_ci
14b5975d6bSopenharmony_ci---
15b5975d6bSopenharmony_ci gio/gdtlsclientconnection.c | 2 +-
16b5975d6bSopenharmony_ci gio/gioenums.h              | 2 ++
17b5975d6bSopenharmony_ci gio/gtlscertificate.c       | 2 ++
18b5975d6bSopenharmony_ci gio/gtlsclientconnection.c  | 2 +-
19b5975d6bSopenharmony_ci 4 files changed, 6 insertions(+), 2 deletions(-)
20b5975d6bSopenharmony_ci
21b5975d6bSopenharmony_cidiff --git a/gio/gdtlsclientconnection.c b/gio/gdtlsclientconnection.c
22b5975d6bSopenharmony_ciindex 74cce7572f..403c8b74d0 100644
23b5975d6bSopenharmony_ci--- a/gio/gdtlsclientconnection.c
24b5975d6bSopenharmony_ci+++ b/gio/gdtlsclientconnection.c
25b5975d6bSopenharmony_ci@@ -191,7 +191,7 @@ g_dtls_client_connection_new (GDatagramBased      *base_socket,
26b5975d6bSopenharmony_ci GTlsCertificateFlags
27b5975d6bSopenharmony_ci g_dtls_client_connection_get_validation_flags (GDtlsClientConnection *conn)
28b5975d6bSopenharmony_ci {
29b5975d6bSopenharmony_ci-  GTlsCertificateFlags flags = 0;
30b5975d6bSopenharmony_ci+  GTlsCertificateFlags flags = G_TLS_CERTIFICATE_FLAGS_NONE;
31b5975d6bSopenharmony_ci 
32b5975d6bSopenharmony_ci   g_return_val_if_fail (G_IS_DTLS_CLIENT_CONNECTION (conn), 0);
33b5975d6bSopenharmony_ci 
34b5975d6bSopenharmony_cidiff --git a/gio/gioenums.h b/gio/gioenums.h
35b5975d6bSopenharmony_ciindex 0d27c15a2b..deacd62206 100644
36b5975d6bSopenharmony_ci--- a/gio/gioenums.h
37b5975d6bSopenharmony_ci+++ b/gio/gioenums.h
38b5975d6bSopenharmony_ci@@ -1578,6 +1578,7 @@ typedef enum {
39b5975d6bSopenharmony_ci 
40b5975d6bSopenharmony_ci /**
41b5975d6bSopenharmony_ci  * GTlsCertificateFlags:
42b5975d6bSopenharmony_ci+ * @G_TLS_CERTIFICATE_FLAGS_NONE: No flags. Since: 2.74
43b5975d6bSopenharmony_ci  * @G_TLS_CERTIFICATE_UNKNOWN_CA: The signing certificate authority is
44b5975d6bSopenharmony_ci  *   not known.
45b5975d6bSopenharmony_ci  * @G_TLS_CERTIFICATE_BAD_IDENTITY: The certificate does not match the
46b5975d6bSopenharmony_ci@@ -1609,6 +1610,7 @@ typedef enum {
47b5975d6bSopenharmony_ci  * Since: 2.28
48b5975d6bSopenharmony_ci  */
49b5975d6bSopenharmony_ci typedef enum {
50b5975d6bSopenharmony_ci+  G_TLS_CERTIFICATE_FLAGS_NONE GLIB_AVAILABLE_ENUMERATOR_IN_2_74 = 0,
51b5975d6bSopenharmony_ci   G_TLS_CERTIFICATE_UNKNOWN_CA    = (1 << 0),
52b5975d6bSopenharmony_ci   G_TLS_CERTIFICATE_BAD_IDENTITY  = (1 << 1),
53b5975d6bSopenharmony_ci   G_TLS_CERTIFICATE_NOT_ACTIVATED = (1 << 2),
54b5975d6bSopenharmony_cidiff --git a/gio/gtlscertificate.c b/gio/gtlscertificate.c
55b5975d6bSopenharmony_ciindex ca09b180ae..e97b8ac144 100644
56b5975d6bSopenharmony_ci--- a/gio/gtlscertificate.c
57b5975d6bSopenharmony_ci+++ b/gio/gtlscertificate.c
58b5975d6bSopenharmony_ci@@ -1121,6 +1121,8 @@ g_tls_certificate_get_issuer (GTlsCertificate  *cert)
59b5975d6bSopenharmony_ci  * check a certificate against a CA that is not part of the system
60b5975d6bSopenharmony_ci  * CA database.
61b5975d6bSopenharmony_ci  *
62b5975d6bSopenharmony_ci+ * If @cert is valid, %G_TLS_CERTIFICATE_FLAGS_NONE is returned.
63b5975d6bSopenharmony_ci+ *
64b5975d6bSopenharmony_ci  * If @identity is not %NULL, @cert's name(s) will be compared against
65b5975d6bSopenharmony_ci  * it, and %G_TLS_CERTIFICATE_BAD_IDENTITY will be set in the return
66b5975d6bSopenharmony_ci  * value if it does not match. If @identity is %NULL, that bit will
67b5975d6bSopenharmony_cidiff --git a/gio/gtlsclientconnection.c b/gio/gtlsclientconnection.c
68b5975d6bSopenharmony_ciindex a6dc897f9f..e6c77b681d 100644
69b5975d6bSopenharmony_ci--- a/gio/gtlsclientconnection.c
70b5975d6bSopenharmony_ci+++ b/gio/gtlsclientconnection.c
71b5975d6bSopenharmony_ci@@ -213,7 +213,7 @@ g_tls_client_connection_new (GIOStream           *base_io_stream,
72b5975d6bSopenharmony_ci GTlsCertificateFlags
73b5975d6bSopenharmony_ci g_tls_client_connection_get_validation_flags (GTlsClientConnection *conn)
74b5975d6bSopenharmony_ci {
75b5975d6bSopenharmony_ci-  GTlsCertificateFlags flags = 0;
76b5975d6bSopenharmony_ci+  GTlsCertificateFlags flags = G_TLS_CERTIFICATE_FLAGS_NONE;
77b5975d6bSopenharmony_ci 
78b5975d6bSopenharmony_ci   g_return_val_if_fail (G_IS_TLS_CLIENT_CONNECTION (conn), 0);
79b5975d6bSopenharmony_ci 
80b5975d6bSopenharmony_ci-- 
81b5975d6bSopenharmony_ciGitLab
82b5975d6bSopenharmony_ci
83