1b5975d6bSopenharmony_ciFrom 27203e48c91ab8b55033dcf1773cb60c0aaed3fa Mon Sep 17 00:00:00 2001 2b5975d6bSopenharmony_ciFrom: Sebastian Keller <skeller@gnome.org> 3b5975d6bSopenharmony_ciDate: Tue, 30 Aug 2022 21:39:36 +0200 4b5975d6bSopenharmony_ciSubject: [PATCH] documentportal: Fix small leak in add_documents with empty 5b5975d6bSopenharmony_ci URI list 6b5975d6bSopenharmony_ci 7b5975d6bSopenharmony_ciWhen called with an empty URI list (or only inaccessible files), 8b5975d6bSopenharmony_cig_document_portal_add_documents would not call g_variant_builder_end, 9b5975d6bSopenharmony_cileaking the memory allocated by the variant builder. 10b5975d6bSopenharmony_ci 11b5975d6bSopenharmony_ciCloses: https://gitlab.gnome.org/GNOME/glib/-/issues/2733 12b5975d6bSopenharmony_ci 13b5975d6bSopenharmony_ciConflict:NA 14b5975d6bSopenharmony_ciReference:https://gitlab.gnome.org/GNOME/glib/-/commit/27203e48c91ab8b55033dcf1773cb60c0aaed3fa 15b5975d6bSopenharmony_ci 16b5975d6bSopenharmony_ci--- 17b5975d6bSopenharmony_ci gio/gdocumentportal.c | 1 + 18b5975d6bSopenharmony_ci 1 file changed, 1 insertion(+) 19b5975d6bSopenharmony_ci 20b5975d6bSopenharmony_cidiff --git a/gio/gdocumentportal.c b/gio/gdocumentportal.c 21b5975d6bSopenharmony_ciindex c08c36c581..382e2aab6e 100644 22b5975d6bSopenharmony_ci--- a/gio/gdocumentportal.c 23b5975d6bSopenharmony_ci+++ b/gio/gdocumentportal.c 24b5975d6bSopenharmony_ci@@ -203,6 +203,7 @@ g_document_portal_add_documents (GList *uris, 25b5975d6bSopenharmony_ci else 26b5975d6bSopenharmony_ci { 27b5975d6bSopenharmony_ci ruris = g_list_copy_deep (uris, (GCopyFunc)g_strdup, NULL); 28b5975d6bSopenharmony_ci+ g_variant_builder_clear (&builder); 29b5975d6bSopenharmony_ci } 30b5975d6bSopenharmony_ci 31b5975d6bSopenharmony_ci out: 32b5975d6bSopenharmony_ci-- 33b5975d6bSopenharmony_ciGitLab 34b5975d6bSopenharmony_ci 35