1a6a784faSopenharmony_ciFrom 2431caddb7e6a87f04ac90b5c6366ad268b6ff31 Mon Sep 17 00:00:00 2001 2a6a784faSopenharmony_ciFrom: Zdenek Dohnal <zdohnal@redhat.com> 3a6a784faSopenharmony_ciDate: Wed, 20 Sep 2023 14:45:17 +0200 4a6a784faSopenharmony_ciSubject: [PATCH] raster-interpret.c: Fix CVE-2023-4504 5a6a784faSopenharmony_ci 6a6a784faSopenharmony_ciWe didn't check for end of buffer if it looks there is an escaped 7a6a784faSopenharmony_cicharacter - check for NULL terminator there and if found, return NULL 8a6a784faSopenharmony_cias return value and in `ptr`, because a lone backslash is not 9a6a784faSopenharmony_cia valid PostScript character. 10a6a784faSopenharmony_ci 11a6a784faSopenharmony_ciReference:https://github.com/OpenPrinting/cups/commit/2431caddb7e6a87f04ac90b5c6366ad268b6ff31 12a6a784faSopenharmony_ciConflict:Patch context adaptation 13a6a784faSopenharmony_ci 14a6a784faSopenharmony_ci--- 15a6a784faSopenharmony_ci cups/raster-interpret.c | 14 +++++++++++++- 16a6a784faSopenharmony_ci 1 files changed, 14 insertions(+) 17a6a784faSopenharmony_ci 18a6a784faSopenharmony_cidiff --git a/cups/raster-interpret.c b/cups/raster-interpret.c 19a6a784faSopenharmony_ciindex 6fcf731b5..b8655c8c6 100644 20a6a784faSopenharmony_ci--- a/cups/raster-interpret.c 21a6a784faSopenharmony_ci+++ b/cups/raster-interpret.c 22a6a784faSopenharmony_ci@@ -1116,7 +1116,19 @@ scan_ps(_cups_ps_stack_t *st, /* I - Stack */ 23a6a784faSopenharmony_ci 24a6a784faSopenharmony_ci cur ++; 25a6a784faSopenharmony_ci 26a6a784faSopenharmony_ci- if (*cur == 'b') 27a6a784faSopenharmony_ci+ /* 28a6a784faSopenharmony_ci+ * Return NULL if we reached NULL terminator, a lone backslash 29a6a784faSopenharmony_ci+ * is not a valid character in PostScript. 30a6a784faSopenharmony_ci+ */ 31a6a784faSopenharmony_ci+ 32a6a784faSopenharmony_ci+ if (!*cur) 33a6a784faSopenharmony_ci+ { 34a6a784faSopenharmony_ci+ *ptr = NULL; 35a6a784faSopenharmony_ci+ 36a6a784faSopenharmony_ci+ return (NULL); 37a6a784faSopenharmony_ci+ } 38a6a784faSopenharmony_ci+ 39a6a784faSopenharmony_ci+ if (*cur == 'b') 40a6a784faSopenharmony_ci *valptr++ = '\b'; 41a6a784faSopenharmony_ci else if (*cur == 'f') 42a6a784faSopenharmony_ci *valptr++ = '\f'; 43a6a784faSopenharmony_ci 44a6a784faSopenharmony_ci 45