162306a36Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only
262306a36Sopenharmony_ci/*
362306a36Sopenharmony_ci * KUnit tests for AppArmor's policy unpack.
462306a36Sopenharmony_ci */
562306a36Sopenharmony_ci
662306a36Sopenharmony_ci#include <kunit/test.h>
762306a36Sopenharmony_ci#include <kunit/visibility.h>
862306a36Sopenharmony_ci
962306a36Sopenharmony_ci#include "include/policy.h"
1062306a36Sopenharmony_ci#include "include/policy_unpack.h"
1162306a36Sopenharmony_ci
1262306a36Sopenharmony_ci#define TEST_STRING_NAME "TEST_STRING"
1362306a36Sopenharmony_ci#define TEST_STRING_DATA "testing"
1462306a36Sopenharmony_ci#define TEST_STRING_BUF_OFFSET \
1562306a36Sopenharmony_ci	(3 + strlen(TEST_STRING_NAME) + 1)
1662306a36Sopenharmony_ci
1762306a36Sopenharmony_ci#define TEST_U32_NAME "U32_TEST"
1862306a36Sopenharmony_ci#define TEST_U32_DATA ((u32)0x01020304)
1962306a36Sopenharmony_ci#define TEST_NAMED_U32_BUF_OFFSET \
2062306a36Sopenharmony_ci	(TEST_STRING_BUF_OFFSET + 3 + strlen(TEST_STRING_DATA) + 1)
2162306a36Sopenharmony_ci#define TEST_U32_BUF_OFFSET \
2262306a36Sopenharmony_ci	(TEST_NAMED_U32_BUF_OFFSET + 3 + strlen(TEST_U32_NAME) + 1)
2362306a36Sopenharmony_ci
2462306a36Sopenharmony_ci#define TEST_U16_OFFSET (TEST_U32_BUF_OFFSET + 3)
2562306a36Sopenharmony_ci#define TEST_U16_DATA ((u16)(TEST_U32_DATA >> 16))
2662306a36Sopenharmony_ci
2762306a36Sopenharmony_ci#define TEST_U64_NAME "U64_TEST"
2862306a36Sopenharmony_ci#define TEST_U64_DATA ((u64)0x0102030405060708)
2962306a36Sopenharmony_ci#define TEST_NAMED_U64_BUF_OFFSET (TEST_U32_BUF_OFFSET + sizeof(u32) + 1)
3062306a36Sopenharmony_ci#define TEST_U64_BUF_OFFSET \
3162306a36Sopenharmony_ci	(TEST_NAMED_U64_BUF_OFFSET + 3 + strlen(TEST_U64_NAME) + 1)
3262306a36Sopenharmony_ci
3362306a36Sopenharmony_ci#define TEST_BLOB_NAME "BLOB_TEST"
3462306a36Sopenharmony_ci#define TEST_BLOB_DATA "\xde\xad\x00\xbe\xef"
3562306a36Sopenharmony_ci#define TEST_BLOB_DATA_SIZE (ARRAY_SIZE(TEST_BLOB_DATA))
3662306a36Sopenharmony_ci#define TEST_NAMED_BLOB_BUF_OFFSET (TEST_U64_BUF_OFFSET + sizeof(u64) + 1)
3762306a36Sopenharmony_ci#define TEST_BLOB_BUF_OFFSET \
3862306a36Sopenharmony_ci	(TEST_NAMED_BLOB_BUF_OFFSET + 3 + strlen(TEST_BLOB_NAME) + 1)
3962306a36Sopenharmony_ci
4062306a36Sopenharmony_ci#define TEST_ARRAY_NAME "ARRAY_TEST"
4162306a36Sopenharmony_ci#define TEST_ARRAY_SIZE 16
4262306a36Sopenharmony_ci#define TEST_NAMED_ARRAY_BUF_OFFSET \
4362306a36Sopenharmony_ci	(TEST_BLOB_BUF_OFFSET + 5 + TEST_BLOB_DATA_SIZE)
4462306a36Sopenharmony_ci#define TEST_ARRAY_BUF_OFFSET \
4562306a36Sopenharmony_ci	(TEST_NAMED_ARRAY_BUF_OFFSET + 3 + strlen(TEST_ARRAY_NAME) + 1)
4662306a36Sopenharmony_ci
4762306a36Sopenharmony_ciMODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
4862306a36Sopenharmony_ci
4962306a36Sopenharmony_cistruct policy_unpack_fixture {
5062306a36Sopenharmony_ci	struct aa_ext *e;
5162306a36Sopenharmony_ci	size_t e_size;
5262306a36Sopenharmony_ci};
5362306a36Sopenharmony_ci
5462306a36Sopenharmony_cistatic struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
5562306a36Sopenharmony_ci					  struct kunit *test, size_t buf_size)
5662306a36Sopenharmony_ci{
5762306a36Sopenharmony_ci	char *buf;
5862306a36Sopenharmony_ci	struct aa_ext *e;
5962306a36Sopenharmony_ci
6062306a36Sopenharmony_ci	buf = kunit_kzalloc(test, buf_size, GFP_USER);
6162306a36Sopenharmony_ci	KUNIT_EXPECT_NOT_ERR_OR_NULL(test, buf);
6262306a36Sopenharmony_ci
6362306a36Sopenharmony_ci	e = kunit_kmalloc(test, sizeof(*e), GFP_USER);
6462306a36Sopenharmony_ci	KUNIT_EXPECT_NOT_ERR_OR_NULL(test, e);
6562306a36Sopenharmony_ci
6662306a36Sopenharmony_ci	e->start = buf;
6762306a36Sopenharmony_ci	e->end = e->start + buf_size;
6862306a36Sopenharmony_ci	e->pos = e->start;
6962306a36Sopenharmony_ci
7062306a36Sopenharmony_ci	*buf = AA_NAME;
7162306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_STRING_NAME) + 1;
7262306a36Sopenharmony_ci	strscpy(buf + 3, TEST_STRING_NAME, e->end - (void *)(buf + 3));
7362306a36Sopenharmony_ci
7462306a36Sopenharmony_ci	buf = e->start + TEST_STRING_BUF_OFFSET;
7562306a36Sopenharmony_ci	*buf = AA_STRING;
7662306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_STRING_DATA) + 1;
7762306a36Sopenharmony_ci	strscpy(buf + 3, TEST_STRING_DATA, e->end - (void *)(buf + 3));
7862306a36Sopenharmony_ci	buf = e->start + TEST_NAMED_U32_BUF_OFFSET;
7962306a36Sopenharmony_ci	*buf = AA_NAME;
8062306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_U32_NAME) + 1;
8162306a36Sopenharmony_ci	strscpy(buf + 3, TEST_U32_NAME, e->end - (void *)(buf + 3));
8262306a36Sopenharmony_ci	*(buf + 3 + strlen(TEST_U32_NAME) + 1) = AA_U32;
8362306a36Sopenharmony_ci	*((u32 *)(buf + 3 + strlen(TEST_U32_NAME) + 2)) = TEST_U32_DATA;
8462306a36Sopenharmony_ci
8562306a36Sopenharmony_ci	buf = e->start + TEST_NAMED_U64_BUF_OFFSET;
8662306a36Sopenharmony_ci	*buf = AA_NAME;
8762306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_U64_NAME) + 1;
8862306a36Sopenharmony_ci	strscpy(buf + 3, TEST_U64_NAME, e->end - (void *)(buf + 3));
8962306a36Sopenharmony_ci	*(buf + 3 + strlen(TEST_U64_NAME) + 1) = AA_U64;
9062306a36Sopenharmony_ci	*((u64 *)(buf + 3 + strlen(TEST_U64_NAME) + 2)) = TEST_U64_DATA;
9162306a36Sopenharmony_ci
9262306a36Sopenharmony_ci	buf = e->start + TEST_NAMED_BLOB_BUF_OFFSET;
9362306a36Sopenharmony_ci	*buf = AA_NAME;
9462306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_BLOB_NAME) + 1;
9562306a36Sopenharmony_ci	strscpy(buf + 3, TEST_BLOB_NAME, e->end - (void *)(buf + 3));
9662306a36Sopenharmony_ci	*(buf + 3 + strlen(TEST_BLOB_NAME) + 1) = AA_BLOB;
9762306a36Sopenharmony_ci	*(buf + 3 + strlen(TEST_BLOB_NAME) + 2) = TEST_BLOB_DATA_SIZE;
9862306a36Sopenharmony_ci	memcpy(buf + 3 + strlen(TEST_BLOB_NAME) + 6,
9962306a36Sopenharmony_ci		TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE);
10062306a36Sopenharmony_ci
10162306a36Sopenharmony_ci	buf = e->start + TEST_NAMED_ARRAY_BUF_OFFSET;
10262306a36Sopenharmony_ci	*buf = AA_NAME;
10362306a36Sopenharmony_ci	*(buf + 1) = strlen(TEST_ARRAY_NAME) + 1;
10462306a36Sopenharmony_ci	strscpy(buf + 3, TEST_ARRAY_NAME, e->end - (void *)(buf + 3));
10562306a36Sopenharmony_ci	*(buf + 3 + strlen(TEST_ARRAY_NAME) + 1) = AA_ARRAY;
10662306a36Sopenharmony_ci	*((u16 *)(buf + 3 + strlen(TEST_ARRAY_NAME) + 2)) = TEST_ARRAY_SIZE;
10762306a36Sopenharmony_ci
10862306a36Sopenharmony_ci	return e;
10962306a36Sopenharmony_ci}
11062306a36Sopenharmony_ci
11162306a36Sopenharmony_cistatic int policy_unpack_test_init(struct kunit *test)
11262306a36Sopenharmony_ci{
11362306a36Sopenharmony_ci	size_t e_size = TEST_ARRAY_BUF_OFFSET + sizeof(u16) + 1;
11462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf;
11562306a36Sopenharmony_ci
11662306a36Sopenharmony_ci	puf = kunit_kmalloc(test, sizeof(*puf), GFP_USER);
11762306a36Sopenharmony_ci	KUNIT_EXPECT_NOT_ERR_OR_NULL(test, puf);
11862306a36Sopenharmony_ci
11962306a36Sopenharmony_ci	puf->e_size = e_size;
12062306a36Sopenharmony_ci	puf->e = build_aa_ext_struct(puf, test, e_size);
12162306a36Sopenharmony_ci
12262306a36Sopenharmony_ci	test->priv = puf;
12362306a36Sopenharmony_ci	return 0;
12462306a36Sopenharmony_ci}
12562306a36Sopenharmony_ci
12662306a36Sopenharmony_cistatic void policy_unpack_test_inbounds_when_inbounds(struct kunit *test)
12762306a36Sopenharmony_ci{
12862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
12962306a36Sopenharmony_ci
13062306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, aa_inbounds(puf->e, 0));
13162306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, aa_inbounds(puf->e, puf->e_size / 2));
13262306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, aa_inbounds(puf->e, puf->e_size));
13362306a36Sopenharmony_ci}
13462306a36Sopenharmony_ci
13562306a36Sopenharmony_cistatic void policy_unpack_test_inbounds_when_out_of_bounds(struct kunit *test)
13662306a36Sopenharmony_ci{
13762306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
13862306a36Sopenharmony_ci
13962306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, aa_inbounds(puf->e, puf->e_size + 1));
14062306a36Sopenharmony_ci}
14162306a36Sopenharmony_ci
14262306a36Sopenharmony_cistatic void policy_unpack_test_unpack_array_with_null_name(struct kunit *test)
14362306a36Sopenharmony_ci{
14462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
14562306a36Sopenharmony_ci	u16 array_size = 0;
14662306a36Sopenharmony_ci
14762306a36Sopenharmony_ci	puf->e->pos += TEST_ARRAY_BUF_OFFSET;
14862306a36Sopenharmony_ci
14962306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, aa_unpack_array(puf->e, NULL, &array_size));
15062306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, array_size, (u16)TEST_ARRAY_SIZE);
15162306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
15262306a36Sopenharmony_ci		puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16) + 1);
15362306a36Sopenharmony_ci}
15462306a36Sopenharmony_ci
15562306a36Sopenharmony_cistatic void policy_unpack_test_unpack_array_with_name(struct kunit *test)
15662306a36Sopenharmony_ci{
15762306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
15862306a36Sopenharmony_ci	const char name[] = TEST_ARRAY_NAME;
15962306a36Sopenharmony_ci	u16 array_size = 0;
16062306a36Sopenharmony_ci
16162306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;
16262306a36Sopenharmony_ci
16362306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, aa_unpack_array(puf->e, name, &array_size));
16462306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, array_size, (u16)TEST_ARRAY_SIZE);
16562306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
16662306a36Sopenharmony_ci		puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16) + 1);
16762306a36Sopenharmony_ci}
16862306a36Sopenharmony_ci
16962306a36Sopenharmony_cistatic void policy_unpack_test_unpack_array_out_of_bounds(struct kunit *test)
17062306a36Sopenharmony_ci{
17162306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
17262306a36Sopenharmony_ci	const char name[] = TEST_ARRAY_NAME;
17362306a36Sopenharmony_ci	u16 array_size;
17462306a36Sopenharmony_ci
17562306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;
17662306a36Sopenharmony_ci	puf->e->end = puf->e->start + TEST_ARRAY_BUF_OFFSET + sizeof(u16);
17762306a36Sopenharmony_ci
17862306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, aa_unpack_array(puf->e, name, &array_size));
17962306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
18062306a36Sopenharmony_ci		puf->e->start + TEST_NAMED_ARRAY_BUF_OFFSET);
18162306a36Sopenharmony_ci}
18262306a36Sopenharmony_ci
18362306a36Sopenharmony_cistatic void policy_unpack_test_unpack_blob_with_null_name(struct kunit *test)
18462306a36Sopenharmony_ci{
18562306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
18662306a36Sopenharmony_ci	char *blob = NULL;
18762306a36Sopenharmony_ci	size_t size;
18862306a36Sopenharmony_ci
18962306a36Sopenharmony_ci	puf->e->pos += TEST_BLOB_BUF_OFFSET;
19062306a36Sopenharmony_ci	size = aa_unpack_blob(puf->e, &blob, NULL);
19162306a36Sopenharmony_ci
19262306a36Sopenharmony_ci	KUNIT_ASSERT_EQ(test, size, TEST_BLOB_DATA_SIZE);
19362306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test,
19462306a36Sopenharmony_ci		memcmp(blob, TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE) == 0);
19562306a36Sopenharmony_ci}
19662306a36Sopenharmony_ci
19762306a36Sopenharmony_cistatic void policy_unpack_test_unpack_blob_with_name(struct kunit *test)
19862306a36Sopenharmony_ci{
19962306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
20062306a36Sopenharmony_ci	char *blob = NULL;
20162306a36Sopenharmony_ci	size_t size;
20262306a36Sopenharmony_ci
20362306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_BLOB_BUF_OFFSET;
20462306a36Sopenharmony_ci	size = aa_unpack_blob(puf->e, &blob, TEST_BLOB_NAME);
20562306a36Sopenharmony_ci
20662306a36Sopenharmony_ci	KUNIT_ASSERT_EQ(test, size, TEST_BLOB_DATA_SIZE);
20762306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test,
20862306a36Sopenharmony_ci		memcmp(blob, TEST_BLOB_DATA, TEST_BLOB_DATA_SIZE) == 0);
20962306a36Sopenharmony_ci}
21062306a36Sopenharmony_ci
21162306a36Sopenharmony_cistatic void policy_unpack_test_unpack_blob_out_of_bounds(struct kunit *test)
21262306a36Sopenharmony_ci{
21362306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
21462306a36Sopenharmony_ci	char *blob = NULL;
21562306a36Sopenharmony_ci	void *start;
21662306a36Sopenharmony_ci	int size;
21762306a36Sopenharmony_ci
21862306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_BLOB_BUF_OFFSET;
21962306a36Sopenharmony_ci	start = puf->e->pos;
22062306a36Sopenharmony_ci	puf->e->end = puf->e->start + TEST_BLOB_BUF_OFFSET
22162306a36Sopenharmony_ci		+ TEST_BLOB_DATA_SIZE - 1;
22262306a36Sopenharmony_ci
22362306a36Sopenharmony_ci	size = aa_unpack_blob(puf->e, &blob, TEST_BLOB_NAME);
22462306a36Sopenharmony_ci
22562306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, 0);
22662306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, start);
22762306a36Sopenharmony_ci}
22862306a36Sopenharmony_ci
22962306a36Sopenharmony_cistatic void policy_unpack_test_unpack_str_with_null_name(struct kunit *test)
23062306a36Sopenharmony_ci{
23162306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
23262306a36Sopenharmony_ci	const char *string = NULL;
23362306a36Sopenharmony_ci	size_t size;
23462306a36Sopenharmony_ci
23562306a36Sopenharmony_ci	puf->e->pos += TEST_STRING_BUF_OFFSET;
23662306a36Sopenharmony_ci	size = aa_unpack_str(puf->e, &string, NULL);
23762306a36Sopenharmony_ci
23862306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, strlen(TEST_STRING_DATA) + 1);
23962306a36Sopenharmony_ci	KUNIT_EXPECT_STREQ(test, string, TEST_STRING_DATA);
24062306a36Sopenharmony_ci}
24162306a36Sopenharmony_ci
24262306a36Sopenharmony_cistatic void policy_unpack_test_unpack_str_with_name(struct kunit *test)
24362306a36Sopenharmony_ci{
24462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
24562306a36Sopenharmony_ci	const char *string = NULL;
24662306a36Sopenharmony_ci	size_t size;
24762306a36Sopenharmony_ci
24862306a36Sopenharmony_ci	size = aa_unpack_str(puf->e, &string, TEST_STRING_NAME);
24962306a36Sopenharmony_ci
25062306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, strlen(TEST_STRING_DATA) + 1);
25162306a36Sopenharmony_ci	KUNIT_EXPECT_STREQ(test, string, TEST_STRING_DATA);
25262306a36Sopenharmony_ci}
25362306a36Sopenharmony_ci
25462306a36Sopenharmony_cistatic void policy_unpack_test_unpack_str_out_of_bounds(struct kunit *test)
25562306a36Sopenharmony_ci{
25662306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
25762306a36Sopenharmony_ci	const char *string = NULL;
25862306a36Sopenharmony_ci	void *start = puf->e->pos;
25962306a36Sopenharmony_ci	int size;
26062306a36Sopenharmony_ci
26162306a36Sopenharmony_ci	puf->e->end = puf->e->pos + TEST_STRING_BUF_OFFSET
26262306a36Sopenharmony_ci		+ strlen(TEST_STRING_DATA) - 1;
26362306a36Sopenharmony_ci
26462306a36Sopenharmony_ci	size = aa_unpack_str(puf->e, &string, TEST_STRING_NAME);
26562306a36Sopenharmony_ci
26662306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, 0);
26762306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, start);
26862306a36Sopenharmony_ci}
26962306a36Sopenharmony_ci
27062306a36Sopenharmony_cistatic void policy_unpack_test_unpack_strdup_with_null_name(struct kunit *test)
27162306a36Sopenharmony_ci{
27262306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
27362306a36Sopenharmony_ci	char *string = NULL;
27462306a36Sopenharmony_ci	size_t size;
27562306a36Sopenharmony_ci
27662306a36Sopenharmony_ci	puf->e->pos += TEST_STRING_BUF_OFFSET;
27762306a36Sopenharmony_ci	size = aa_unpack_strdup(puf->e, &string, NULL);
27862306a36Sopenharmony_ci
27962306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, strlen(TEST_STRING_DATA) + 1);
28062306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test,
28162306a36Sopenharmony_ci			   ((uintptr_t)puf->e->start <= (uintptr_t)string)
28262306a36Sopenharmony_ci			   && ((uintptr_t)string <= (uintptr_t)puf->e->end));
28362306a36Sopenharmony_ci	KUNIT_EXPECT_STREQ(test, string, TEST_STRING_DATA);
28462306a36Sopenharmony_ci}
28562306a36Sopenharmony_ci
28662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_strdup_with_name(struct kunit *test)
28762306a36Sopenharmony_ci{
28862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
28962306a36Sopenharmony_ci	char *string = NULL;
29062306a36Sopenharmony_ci	size_t size;
29162306a36Sopenharmony_ci
29262306a36Sopenharmony_ci	size = aa_unpack_strdup(puf->e, &string, TEST_STRING_NAME);
29362306a36Sopenharmony_ci
29462306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, strlen(TEST_STRING_DATA) + 1);
29562306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test,
29662306a36Sopenharmony_ci			   ((uintptr_t)puf->e->start <= (uintptr_t)string)
29762306a36Sopenharmony_ci			   && ((uintptr_t)string <= (uintptr_t)puf->e->end));
29862306a36Sopenharmony_ci	KUNIT_EXPECT_STREQ(test, string, TEST_STRING_DATA);
29962306a36Sopenharmony_ci}
30062306a36Sopenharmony_ci
30162306a36Sopenharmony_cistatic void policy_unpack_test_unpack_strdup_out_of_bounds(struct kunit *test)
30262306a36Sopenharmony_ci{
30362306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
30462306a36Sopenharmony_ci	void *start = puf->e->pos;
30562306a36Sopenharmony_ci	char *string = NULL;
30662306a36Sopenharmony_ci	int size;
30762306a36Sopenharmony_ci
30862306a36Sopenharmony_ci	puf->e->end = puf->e->pos + TEST_STRING_BUF_OFFSET
30962306a36Sopenharmony_ci		+ strlen(TEST_STRING_DATA) - 1;
31062306a36Sopenharmony_ci
31162306a36Sopenharmony_ci	size = aa_unpack_strdup(puf->e, &string, TEST_STRING_NAME);
31262306a36Sopenharmony_ci
31362306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, 0);
31462306a36Sopenharmony_ci	KUNIT_EXPECT_NULL(test, string);
31562306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, start);
31662306a36Sopenharmony_ci}
31762306a36Sopenharmony_ci
31862306a36Sopenharmony_cistatic void policy_unpack_test_unpack_nameX_with_null_name(struct kunit *test)
31962306a36Sopenharmony_ci{
32062306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
32162306a36Sopenharmony_ci	bool success;
32262306a36Sopenharmony_ci
32362306a36Sopenharmony_ci	puf->e->pos += TEST_U32_BUF_OFFSET;
32462306a36Sopenharmony_ci
32562306a36Sopenharmony_ci	success = aa_unpack_nameX(puf->e, AA_U32, NULL);
32662306a36Sopenharmony_ci
32762306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
32862306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
32962306a36Sopenharmony_ci			    puf->e->start + TEST_U32_BUF_OFFSET + 1);
33062306a36Sopenharmony_ci}
33162306a36Sopenharmony_ci
33262306a36Sopenharmony_cistatic void policy_unpack_test_unpack_nameX_with_wrong_code(struct kunit *test)
33362306a36Sopenharmony_ci{
33462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
33562306a36Sopenharmony_ci	bool success;
33662306a36Sopenharmony_ci
33762306a36Sopenharmony_ci	puf->e->pos += TEST_U32_BUF_OFFSET;
33862306a36Sopenharmony_ci
33962306a36Sopenharmony_ci	success = aa_unpack_nameX(puf->e, AA_BLOB, NULL);
34062306a36Sopenharmony_ci
34162306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
34262306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
34362306a36Sopenharmony_ci			    puf->e->start + TEST_U32_BUF_OFFSET);
34462306a36Sopenharmony_ci}
34562306a36Sopenharmony_ci
34662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_nameX_with_name(struct kunit *test)
34762306a36Sopenharmony_ci{
34862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
34962306a36Sopenharmony_ci	const char name[] = TEST_U32_NAME;
35062306a36Sopenharmony_ci	bool success;
35162306a36Sopenharmony_ci
35262306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U32_BUF_OFFSET;
35362306a36Sopenharmony_ci
35462306a36Sopenharmony_ci	success = aa_unpack_nameX(puf->e, AA_U32, name);
35562306a36Sopenharmony_ci
35662306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
35762306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
35862306a36Sopenharmony_ci			    puf->e->start + TEST_U32_BUF_OFFSET + 1);
35962306a36Sopenharmony_ci}
36062306a36Sopenharmony_ci
36162306a36Sopenharmony_cistatic void policy_unpack_test_unpack_nameX_with_wrong_name(struct kunit *test)
36262306a36Sopenharmony_ci{
36362306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
36462306a36Sopenharmony_ci	static const char name[] = "12345678";
36562306a36Sopenharmony_ci	bool success;
36662306a36Sopenharmony_ci
36762306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U32_BUF_OFFSET;
36862306a36Sopenharmony_ci
36962306a36Sopenharmony_ci	success = aa_unpack_nameX(puf->e, AA_U32, name);
37062306a36Sopenharmony_ci
37162306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
37262306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
37362306a36Sopenharmony_ci			    puf->e->start + TEST_NAMED_U32_BUF_OFFSET);
37462306a36Sopenharmony_ci}
37562306a36Sopenharmony_ci
37662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u16_chunk_basic(struct kunit *test)
37762306a36Sopenharmony_ci{
37862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
37962306a36Sopenharmony_ci	char *chunk = NULL;
38062306a36Sopenharmony_ci	size_t size;
38162306a36Sopenharmony_ci
38262306a36Sopenharmony_ci	puf->e->pos += TEST_U16_OFFSET;
38362306a36Sopenharmony_ci	/*
38462306a36Sopenharmony_ci	 * WARNING: For unit testing purposes, we're pushing puf->e->end past
38562306a36Sopenharmony_ci	 * the end of the allocated memory. Doing anything other than comparing
38662306a36Sopenharmony_ci	 * memory addresses is dangerous.
38762306a36Sopenharmony_ci	 */
38862306a36Sopenharmony_ci	puf->e->end += TEST_U16_DATA;
38962306a36Sopenharmony_ci
39062306a36Sopenharmony_ci	size = aa_unpack_u16_chunk(puf->e, &chunk);
39162306a36Sopenharmony_ci
39262306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, chunk,
39362306a36Sopenharmony_ci			    puf->e->start + TEST_U16_OFFSET + 2);
39462306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, TEST_U16_DATA);
39562306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, (chunk + TEST_U16_DATA));
39662306a36Sopenharmony_ci}
39762306a36Sopenharmony_ci
39862306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u16_chunk_out_of_bounds_1(
39962306a36Sopenharmony_ci		struct kunit *test)
40062306a36Sopenharmony_ci{
40162306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
40262306a36Sopenharmony_ci	char *chunk = NULL;
40362306a36Sopenharmony_ci	size_t size;
40462306a36Sopenharmony_ci
40562306a36Sopenharmony_ci	puf->e->pos = puf->e->end - 1;
40662306a36Sopenharmony_ci
40762306a36Sopenharmony_ci	size = aa_unpack_u16_chunk(puf->e, &chunk);
40862306a36Sopenharmony_ci
40962306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, 0);
41062306a36Sopenharmony_ci	KUNIT_EXPECT_NULL(test, chunk);
41162306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, puf->e->end - 1);
41262306a36Sopenharmony_ci}
41362306a36Sopenharmony_ci
41462306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u16_chunk_out_of_bounds_2(
41562306a36Sopenharmony_ci		struct kunit *test)
41662306a36Sopenharmony_ci{
41762306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
41862306a36Sopenharmony_ci	char *chunk = NULL;
41962306a36Sopenharmony_ci	size_t size;
42062306a36Sopenharmony_ci
42162306a36Sopenharmony_ci	puf->e->pos += TEST_U16_OFFSET;
42262306a36Sopenharmony_ci	/*
42362306a36Sopenharmony_ci	 * WARNING: For unit testing purposes, we're pushing puf->e->end past
42462306a36Sopenharmony_ci	 * the end of the allocated memory. Doing anything other than comparing
42562306a36Sopenharmony_ci	 * memory addresses is dangerous.
42662306a36Sopenharmony_ci	 */
42762306a36Sopenharmony_ci	puf->e->end = puf->e->pos + TEST_U16_DATA - 1;
42862306a36Sopenharmony_ci
42962306a36Sopenharmony_ci	size = aa_unpack_u16_chunk(puf->e, &chunk);
43062306a36Sopenharmony_ci
43162306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, size, 0);
43262306a36Sopenharmony_ci	KUNIT_EXPECT_NULL(test, chunk);
43362306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos, puf->e->start + TEST_U16_OFFSET);
43462306a36Sopenharmony_ci}
43562306a36Sopenharmony_ci
43662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u32_with_null_name(struct kunit *test)
43762306a36Sopenharmony_ci{
43862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
43962306a36Sopenharmony_ci	bool success;
44062306a36Sopenharmony_ci	u32 data = 0;
44162306a36Sopenharmony_ci
44262306a36Sopenharmony_ci	puf->e->pos += TEST_U32_BUF_OFFSET;
44362306a36Sopenharmony_ci
44462306a36Sopenharmony_ci	success = aa_unpack_u32(puf->e, &data, NULL);
44562306a36Sopenharmony_ci
44662306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
44762306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, data, TEST_U32_DATA);
44862306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
44962306a36Sopenharmony_ci			puf->e->start + TEST_U32_BUF_OFFSET + sizeof(u32) + 1);
45062306a36Sopenharmony_ci}
45162306a36Sopenharmony_ci
45262306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u32_with_name(struct kunit *test)
45362306a36Sopenharmony_ci{
45462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
45562306a36Sopenharmony_ci	const char name[] = TEST_U32_NAME;
45662306a36Sopenharmony_ci	bool success;
45762306a36Sopenharmony_ci	u32 data = 0;
45862306a36Sopenharmony_ci
45962306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U32_BUF_OFFSET;
46062306a36Sopenharmony_ci
46162306a36Sopenharmony_ci	success = aa_unpack_u32(puf->e, &data, name);
46262306a36Sopenharmony_ci
46362306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
46462306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, data, TEST_U32_DATA);
46562306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
46662306a36Sopenharmony_ci			puf->e->start + TEST_U32_BUF_OFFSET + sizeof(u32) + 1);
46762306a36Sopenharmony_ci}
46862306a36Sopenharmony_ci
46962306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u32_out_of_bounds(struct kunit *test)
47062306a36Sopenharmony_ci{
47162306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
47262306a36Sopenharmony_ci	const char name[] = TEST_U32_NAME;
47362306a36Sopenharmony_ci	bool success;
47462306a36Sopenharmony_ci	u32 data = 0;
47562306a36Sopenharmony_ci
47662306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U32_BUF_OFFSET;
47762306a36Sopenharmony_ci	puf->e->end = puf->e->start + TEST_U32_BUF_OFFSET + sizeof(u32);
47862306a36Sopenharmony_ci
47962306a36Sopenharmony_ci	success = aa_unpack_u32(puf->e, &data, name);
48062306a36Sopenharmony_ci
48162306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
48262306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
48362306a36Sopenharmony_ci			puf->e->start + TEST_NAMED_U32_BUF_OFFSET);
48462306a36Sopenharmony_ci}
48562306a36Sopenharmony_ci
48662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u64_with_null_name(struct kunit *test)
48762306a36Sopenharmony_ci{
48862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
48962306a36Sopenharmony_ci	bool success;
49062306a36Sopenharmony_ci	u64 data = 0;
49162306a36Sopenharmony_ci
49262306a36Sopenharmony_ci	puf->e->pos += TEST_U64_BUF_OFFSET;
49362306a36Sopenharmony_ci
49462306a36Sopenharmony_ci	success = aa_unpack_u64(puf->e, &data, NULL);
49562306a36Sopenharmony_ci
49662306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
49762306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, data, TEST_U64_DATA);
49862306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
49962306a36Sopenharmony_ci			puf->e->start + TEST_U64_BUF_OFFSET + sizeof(u64) + 1);
50062306a36Sopenharmony_ci}
50162306a36Sopenharmony_ci
50262306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u64_with_name(struct kunit *test)
50362306a36Sopenharmony_ci{
50462306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
50562306a36Sopenharmony_ci	const char name[] = TEST_U64_NAME;
50662306a36Sopenharmony_ci	bool success;
50762306a36Sopenharmony_ci	u64 data = 0;
50862306a36Sopenharmony_ci
50962306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U64_BUF_OFFSET;
51062306a36Sopenharmony_ci
51162306a36Sopenharmony_ci	success = aa_unpack_u64(puf->e, &data, name);
51262306a36Sopenharmony_ci
51362306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
51462306a36Sopenharmony_ci	KUNIT_EXPECT_EQ(test, data, TEST_U64_DATA);
51562306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
51662306a36Sopenharmony_ci			puf->e->start + TEST_U64_BUF_OFFSET + sizeof(u64) + 1);
51762306a36Sopenharmony_ci}
51862306a36Sopenharmony_ci
51962306a36Sopenharmony_cistatic void policy_unpack_test_unpack_u64_out_of_bounds(struct kunit *test)
52062306a36Sopenharmony_ci{
52162306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
52262306a36Sopenharmony_ci	const char name[] = TEST_U64_NAME;
52362306a36Sopenharmony_ci	bool success;
52462306a36Sopenharmony_ci	u64 data = 0;
52562306a36Sopenharmony_ci
52662306a36Sopenharmony_ci	puf->e->pos += TEST_NAMED_U64_BUF_OFFSET;
52762306a36Sopenharmony_ci	puf->e->end = puf->e->start + TEST_U64_BUF_OFFSET + sizeof(u64);
52862306a36Sopenharmony_ci
52962306a36Sopenharmony_ci	success = aa_unpack_u64(puf->e, &data, name);
53062306a36Sopenharmony_ci
53162306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
53262306a36Sopenharmony_ci	KUNIT_EXPECT_PTR_EQ(test, puf->e->pos,
53362306a36Sopenharmony_ci			puf->e->start + TEST_NAMED_U64_BUF_OFFSET);
53462306a36Sopenharmony_ci}
53562306a36Sopenharmony_ci
53662306a36Sopenharmony_cistatic void policy_unpack_test_unpack_X_code_match(struct kunit *test)
53762306a36Sopenharmony_ci{
53862306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
53962306a36Sopenharmony_ci	bool success = aa_unpack_X(puf->e, AA_NAME);
54062306a36Sopenharmony_ci
54162306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, success);
54262306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, puf->e->pos == puf->e->start + 1);
54362306a36Sopenharmony_ci}
54462306a36Sopenharmony_ci
54562306a36Sopenharmony_cistatic void policy_unpack_test_unpack_X_code_mismatch(struct kunit *test)
54662306a36Sopenharmony_ci{
54762306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
54862306a36Sopenharmony_ci	bool success = aa_unpack_X(puf->e, AA_STRING);
54962306a36Sopenharmony_ci
55062306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
55162306a36Sopenharmony_ci	KUNIT_EXPECT_TRUE(test, puf->e->pos == puf->e->start);
55262306a36Sopenharmony_ci}
55362306a36Sopenharmony_ci
55462306a36Sopenharmony_cistatic void policy_unpack_test_unpack_X_out_of_bounds(struct kunit *test)
55562306a36Sopenharmony_ci{
55662306a36Sopenharmony_ci	struct policy_unpack_fixture *puf = test->priv;
55762306a36Sopenharmony_ci	bool success;
55862306a36Sopenharmony_ci
55962306a36Sopenharmony_ci	puf->e->pos = puf->e->end;
56062306a36Sopenharmony_ci	success = aa_unpack_X(puf->e, AA_NAME);
56162306a36Sopenharmony_ci
56262306a36Sopenharmony_ci	KUNIT_EXPECT_FALSE(test, success);
56362306a36Sopenharmony_ci}
56462306a36Sopenharmony_ci
56562306a36Sopenharmony_cistatic struct kunit_case apparmor_policy_unpack_test_cases[] = {
56662306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_inbounds_when_inbounds),
56762306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_inbounds_when_out_of_bounds),
56862306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_array_with_null_name),
56962306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_array_with_name),
57062306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_array_out_of_bounds),
57162306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_blob_with_null_name),
57262306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_blob_with_name),
57362306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_blob_out_of_bounds),
57462306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_nameX_with_null_name),
57562306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_nameX_with_wrong_code),
57662306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_nameX_with_name),
57762306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_nameX_with_wrong_name),
57862306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_str_with_null_name),
57962306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_str_with_name),
58062306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_str_out_of_bounds),
58162306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_strdup_with_null_name),
58262306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_strdup_with_name),
58362306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_strdup_out_of_bounds),
58462306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u16_chunk_basic),
58562306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u16_chunk_out_of_bounds_1),
58662306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u16_chunk_out_of_bounds_2),
58762306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u32_with_null_name),
58862306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u32_with_name),
58962306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u32_out_of_bounds),
59062306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u64_with_null_name),
59162306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u64_with_name),
59262306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_u64_out_of_bounds),
59362306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_X_code_match),
59462306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_X_code_mismatch),
59562306a36Sopenharmony_ci	KUNIT_CASE(policy_unpack_test_unpack_X_out_of_bounds),
59662306a36Sopenharmony_ci	{},
59762306a36Sopenharmony_ci};
59862306a36Sopenharmony_ci
59962306a36Sopenharmony_cistatic struct kunit_suite apparmor_policy_unpack_test_module = {
60062306a36Sopenharmony_ci	.name = "apparmor_policy_unpack",
60162306a36Sopenharmony_ci	.init = policy_unpack_test_init,
60262306a36Sopenharmony_ci	.test_cases = apparmor_policy_unpack_test_cases,
60362306a36Sopenharmony_ci};
60462306a36Sopenharmony_ci
60562306a36Sopenharmony_cikunit_test_suite(apparmor_policy_unpack_test_module);
60662306a36Sopenharmony_ci
60762306a36Sopenharmony_ciMODULE_LICENSE("GPL");
608