162306a36Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only 262306a36Sopenharmony_ci/// Use WARN(1,...) rather than printk followed by WARN_ON(1) 362306a36Sopenharmony_ci/// 462306a36Sopenharmony_ci// Confidence: High 562306a36Sopenharmony_ci// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. 662306a36Sopenharmony_ci// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. 762306a36Sopenharmony_ci// URL: https://coccinelle.gitlabpages.inria.fr/website 862306a36Sopenharmony_ci// Comments: 962306a36Sopenharmony_ci// Options: --no-includes --include-headers 1062306a36Sopenharmony_ci 1162306a36Sopenharmony_civirtual patch 1262306a36Sopenharmony_civirtual context 1362306a36Sopenharmony_civirtual org 1462306a36Sopenharmony_civirtual report 1562306a36Sopenharmony_ci 1662306a36Sopenharmony_ci@bad1@ 1762306a36Sopenharmony_ciposition p; 1862306a36Sopenharmony_ci@@ 1962306a36Sopenharmony_ci 2062306a36Sopenharmony_ciprintk(...); 2162306a36Sopenharmony_ciprintk@p(...); 2262306a36Sopenharmony_ciWARN_ON(1); 2362306a36Sopenharmony_ci 2462306a36Sopenharmony_ci@r1 depends on context || report || org@ 2562306a36Sopenharmony_ciposition p != bad1.p; 2662306a36Sopenharmony_ci@@ 2762306a36Sopenharmony_ci 2862306a36Sopenharmony_ci printk@p(...); 2962306a36Sopenharmony_ci*WARN_ON(1); 3062306a36Sopenharmony_ci 3162306a36Sopenharmony_ci@script:python depends on org@ 3262306a36Sopenharmony_cip << r1.p; 3362306a36Sopenharmony_ci@@ 3462306a36Sopenharmony_ci 3562306a36Sopenharmony_cicocci.print_main("printk + WARN_ON can be just WARN",p) 3662306a36Sopenharmony_ci 3762306a36Sopenharmony_ci@script:python depends on report@ 3862306a36Sopenharmony_cip << r1.p; 3962306a36Sopenharmony_ci@@ 4062306a36Sopenharmony_ci 4162306a36Sopenharmony_cimsg = "SUGGESTION: printk + WARN_ON can be just WARN" 4262306a36Sopenharmony_cicoccilib.report.print_report(p[0],msg) 4362306a36Sopenharmony_ci 4462306a36Sopenharmony_ci@ok1 depends on patch@ 4562306a36Sopenharmony_ciexpression list es; 4662306a36Sopenharmony_ciposition p != bad1.p; 4762306a36Sopenharmony_ci@@ 4862306a36Sopenharmony_ci 4962306a36Sopenharmony_ci-printk@p( 5062306a36Sopenharmony_ci+WARN(1, 5162306a36Sopenharmony_ci es); 5262306a36Sopenharmony_ci-WARN_ON(1); 5362306a36Sopenharmony_ci 5462306a36Sopenharmony_ci@depends on patch@ 5562306a36Sopenharmony_ciexpression list ok1.es; 5662306a36Sopenharmony_ci@@ 5762306a36Sopenharmony_ci 5862306a36Sopenharmony_ciif (...) 5962306a36Sopenharmony_ci- { 6062306a36Sopenharmony_ci WARN(1,es); 6162306a36Sopenharmony_ci- } 6262306a36Sopenharmony_ci 6362306a36Sopenharmony_ci// -------------------------------------------------------------------- 6462306a36Sopenharmony_ci 6562306a36Sopenharmony_ci@bad2@ 6662306a36Sopenharmony_ciposition p; 6762306a36Sopenharmony_ci@@ 6862306a36Sopenharmony_ci 6962306a36Sopenharmony_ciprintk(...); 7062306a36Sopenharmony_ciprintk@p(...); 7162306a36Sopenharmony_ciWARN_ON_ONCE(1); 7262306a36Sopenharmony_ci 7362306a36Sopenharmony_ci@r2 depends on context || report || org@ 7462306a36Sopenharmony_ciposition p != bad1.p; 7562306a36Sopenharmony_ci@@ 7662306a36Sopenharmony_ci 7762306a36Sopenharmony_ci printk@p(...); 7862306a36Sopenharmony_ci*WARN_ON_ONCE(1); 7962306a36Sopenharmony_ci 8062306a36Sopenharmony_ci@script:python depends on org@ 8162306a36Sopenharmony_cip << r2.p; 8262306a36Sopenharmony_ci@@ 8362306a36Sopenharmony_ci 8462306a36Sopenharmony_cicocci.print_main("printk + WARN_ON_ONCE can be just WARN_ONCE",p) 8562306a36Sopenharmony_ci 8662306a36Sopenharmony_ci@script:python depends on report@ 8762306a36Sopenharmony_cip << r2.p; 8862306a36Sopenharmony_ci@@ 8962306a36Sopenharmony_ci 9062306a36Sopenharmony_cimsg = "SUGGESTION: printk + WARN_ON_ONCE can be just WARN_ONCE" 9162306a36Sopenharmony_cicoccilib.report.print_report(p[0],msg) 9262306a36Sopenharmony_ci 9362306a36Sopenharmony_ci@ok2 depends on patch@ 9462306a36Sopenharmony_ciexpression list es; 9562306a36Sopenharmony_ciposition p != bad2.p; 9662306a36Sopenharmony_ci@@ 9762306a36Sopenharmony_ci 9862306a36Sopenharmony_ci-printk@p( 9962306a36Sopenharmony_ci+WARN_ONCE(1, 10062306a36Sopenharmony_ci es); 10162306a36Sopenharmony_ci-WARN_ON_ONCE(1); 10262306a36Sopenharmony_ci 10362306a36Sopenharmony_ci@depends on patch@ 10462306a36Sopenharmony_ciexpression list ok2.es; 10562306a36Sopenharmony_ci@@ 10662306a36Sopenharmony_ci 10762306a36Sopenharmony_ciif (...) 10862306a36Sopenharmony_ci- { 10962306a36Sopenharmony_ci WARN_ONCE(1,es); 11062306a36Sopenharmony_ci- } 111