162306a36Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0
262306a36Sopenharmony_ci/*
362306a36Sopenharmony_ci * Functions corresponding to string type attributes under
462306a36Sopenharmony_ci * HP_WMI_BIOS_STRING_GUID for use with hp-bioscfg driver.
562306a36Sopenharmony_ci *
662306a36Sopenharmony_ci * Copyright (c) 2022 HP Development Company, L.P.
762306a36Sopenharmony_ci */
862306a36Sopenharmony_ci
962306a36Sopenharmony_ci#include "bioscfg.h"
1062306a36Sopenharmony_ci
1162306a36Sopenharmony_ci#define WMI_STRING_TYPE "HPBIOS_BIOSString"
1262306a36Sopenharmony_ci
1362306a36Sopenharmony_ciGET_INSTANCE_ID(string);
1462306a36Sopenharmony_ci
1562306a36Sopenharmony_cistatic ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
1662306a36Sopenharmony_ci{
1762306a36Sopenharmony_ci	int instance_id = get_string_instance_id(kobj);
1862306a36Sopenharmony_ci
1962306a36Sopenharmony_ci	if (instance_id < 0)
2062306a36Sopenharmony_ci		return -EIO;
2162306a36Sopenharmony_ci
2262306a36Sopenharmony_ci	return  sysfs_emit(buf, "%s\n",
2362306a36Sopenharmony_ci			 bioscfg_drv.string_data[instance_id].current_value);
2462306a36Sopenharmony_ci}
2562306a36Sopenharmony_ci
2662306a36Sopenharmony_ci/**
2762306a36Sopenharmony_ci * validate_string_input() -
2862306a36Sopenharmony_ci * Validate input of current_value against min and max lengths
2962306a36Sopenharmony_ci *
3062306a36Sopenharmony_ci * @instance_id: The instance on which input is validated
3162306a36Sopenharmony_ci * @buf: Input value
3262306a36Sopenharmony_ci */
3362306a36Sopenharmony_cistatic int validate_string_input(int instance_id, const char *buf)
3462306a36Sopenharmony_ci{
3562306a36Sopenharmony_ci	int in_len = strlen(buf);
3662306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
3762306a36Sopenharmony_ci
3862306a36Sopenharmony_ci	/* BIOS treats it as a read only attribute */
3962306a36Sopenharmony_ci	if (string_data->common.is_readonly)
4062306a36Sopenharmony_ci		return -EIO;
4162306a36Sopenharmony_ci
4262306a36Sopenharmony_ci	if (in_len < string_data->min_length || in_len > string_data->max_length)
4362306a36Sopenharmony_ci		return -ERANGE;
4462306a36Sopenharmony_ci
4562306a36Sopenharmony_ci	return 0;
4662306a36Sopenharmony_ci}
4762306a36Sopenharmony_ci
4862306a36Sopenharmony_cistatic void update_string_value(int instance_id, char *attr_value)
4962306a36Sopenharmony_ci{
5062306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
5162306a36Sopenharmony_ci
5262306a36Sopenharmony_ci	/* Write settings to BIOS */
5362306a36Sopenharmony_ci	strscpy(string_data->current_value, attr_value, sizeof(string_data->current_value));
5462306a36Sopenharmony_ci}
5562306a36Sopenharmony_ci
5662306a36Sopenharmony_ci/*
5762306a36Sopenharmony_ci * ATTRIBUTE_S_COMMON_PROPERTY_SHOW(display_name_language_code, string);
5862306a36Sopenharmony_ci * static struct kobj_attribute string_display_langcode =
5962306a36Sopenharmony_ci *	__ATTR_RO(display_name_language_code);
6062306a36Sopenharmony_ci */
6162306a36Sopenharmony_ci
6262306a36Sopenharmony_ciATTRIBUTE_S_COMMON_PROPERTY_SHOW(display_name, string);
6362306a36Sopenharmony_cistatic struct kobj_attribute string_display_name =
6462306a36Sopenharmony_ci	__ATTR_RO(display_name);
6562306a36Sopenharmony_ci
6662306a36Sopenharmony_ciATTRIBUTE_PROPERTY_STORE(current_value, string);
6762306a36Sopenharmony_cistatic struct kobj_attribute string_current_val =
6862306a36Sopenharmony_ci	__ATTR_RW_MODE(current_value, 0644);
6962306a36Sopenharmony_ci
7062306a36Sopenharmony_ciATTRIBUTE_N_PROPERTY_SHOW(min_length, string);
7162306a36Sopenharmony_cistatic struct kobj_attribute string_min_length =
7262306a36Sopenharmony_ci	__ATTR_RO(min_length);
7362306a36Sopenharmony_ci
7462306a36Sopenharmony_ciATTRIBUTE_N_PROPERTY_SHOW(max_length, string);
7562306a36Sopenharmony_cistatic struct kobj_attribute string_max_length =
7662306a36Sopenharmony_ci	__ATTR_RO(max_length);
7762306a36Sopenharmony_ci
7862306a36Sopenharmony_cistatic ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr,
7962306a36Sopenharmony_ci			 char *buf)
8062306a36Sopenharmony_ci{
8162306a36Sopenharmony_ci	return sysfs_emit(buf, "string\n");
8262306a36Sopenharmony_ci}
8362306a36Sopenharmony_ci
8462306a36Sopenharmony_cistatic struct kobj_attribute string_type =
8562306a36Sopenharmony_ci	__ATTR_RO(type);
8662306a36Sopenharmony_ci
8762306a36Sopenharmony_cistatic struct attribute *string_attrs[] = {
8862306a36Sopenharmony_ci	&common_display_langcode.attr,
8962306a36Sopenharmony_ci	&string_display_name.attr,
9062306a36Sopenharmony_ci	&string_current_val.attr,
9162306a36Sopenharmony_ci	&string_min_length.attr,
9262306a36Sopenharmony_ci	&string_max_length.attr,
9362306a36Sopenharmony_ci	&string_type.attr,
9462306a36Sopenharmony_ci	NULL
9562306a36Sopenharmony_ci};
9662306a36Sopenharmony_ci
9762306a36Sopenharmony_cistatic const struct attribute_group string_attr_group = {
9862306a36Sopenharmony_ci	.attrs = string_attrs,
9962306a36Sopenharmony_ci};
10062306a36Sopenharmony_ci
10162306a36Sopenharmony_ciint hp_alloc_string_data(void)
10262306a36Sopenharmony_ci{
10362306a36Sopenharmony_ci	bioscfg_drv.string_instances_count = hp_get_instance_count(HP_WMI_BIOS_STRING_GUID);
10462306a36Sopenharmony_ci	bioscfg_drv.string_data = kcalloc(bioscfg_drv.string_instances_count,
10562306a36Sopenharmony_ci					  sizeof(*bioscfg_drv.string_data), GFP_KERNEL);
10662306a36Sopenharmony_ci	if (!bioscfg_drv.string_data) {
10762306a36Sopenharmony_ci		bioscfg_drv.string_instances_count = 0;
10862306a36Sopenharmony_ci		return -ENOMEM;
10962306a36Sopenharmony_ci	}
11062306a36Sopenharmony_ci	return 0;
11162306a36Sopenharmony_ci}
11262306a36Sopenharmony_ci
11362306a36Sopenharmony_ci/* Expected Values types associated with each element */
11462306a36Sopenharmony_cistatic const acpi_object_type expected_string_types[] = {
11562306a36Sopenharmony_ci	[NAME] = ACPI_TYPE_STRING,
11662306a36Sopenharmony_ci	[VALUE] = ACPI_TYPE_STRING,
11762306a36Sopenharmony_ci	[PATH] = ACPI_TYPE_STRING,
11862306a36Sopenharmony_ci	[IS_READONLY] = ACPI_TYPE_INTEGER,
11962306a36Sopenharmony_ci	[DISPLAY_IN_UI] = ACPI_TYPE_INTEGER,
12062306a36Sopenharmony_ci	[REQUIRES_PHYSICAL_PRESENCE] = ACPI_TYPE_INTEGER,
12162306a36Sopenharmony_ci	[SEQUENCE] = ACPI_TYPE_INTEGER,
12262306a36Sopenharmony_ci	[PREREQUISITES_SIZE] = ACPI_TYPE_INTEGER,
12362306a36Sopenharmony_ci	[PREREQUISITES] = ACPI_TYPE_STRING,
12462306a36Sopenharmony_ci	[SECURITY_LEVEL] = ACPI_TYPE_INTEGER,
12562306a36Sopenharmony_ci	[STR_MIN_LENGTH] = ACPI_TYPE_INTEGER,
12662306a36Sopenharmony_ci	[STR_MAX_LENGTH] = ACPI_TYPE_INTEGER,
12762306a36Sopenharmony_ci};
12862306a36Sopenharmony_ci
12962306a36Sopenharmony_cistatic int hp_populate_string_elements_from_package(union acpi_object *string_obj,
13062306a36Sopenharmony_ci						    int string_obj_count,
13162306a36Sopenharmony_ci						    int instance_id)
13262306a36Sopenharmony_ci{
13362306a36Sopenharmony_ci	char *str_value = NULL;
13462306a36Sopenharmony_ci	int value_len;
13562306a36Sopenharmony_ci	int ret = 0;
13662306a36Sopenharmony_ci	u32 int_value = 0;
13762306a36Sopenharmony_ci	int elem;
13862306a36Sopenharmony_ci	int reqs;
13962306a36Sopenharmony_ci	int eloc;
14062306a36Sopenharmony_ci	int size;
14162306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
14262306a36Sopenharmony_ci
14362306a36Sopenharmony_ci	if (!string_obj)
14462306a36Sopenharmony_ci		return -EINVAL;
14562306a36Sopenharmony_ci
14662306a36Sopenharmony_ci	for (elem = 1, eloc = 1; elem < string_obj_count; elem++, eloc++) {
14762306a36Sopenharmony_ci		/* ONLY look at the first STRING_ELEM_CNT elements */
14862306a36Sopenharmony_ci		if (eloc == STR_ELEM_CNT)
14962306a36Sopenharmony_ci			goto exit_string_package;
15062306a36Sopenharmony_ci
15162306a36Sopenharmony_ci		switch (string_obj[elem].type) {
15262306a36Sopenharmony_ci		case ACPI_TYPE_STRING:
15362306a36Sopenharmony_ci			if (elem != PREREQUISITES) {
15462306a36Sopenharmony_ci				ret = hp_convert_hexstr_to_str(string_obj[elem].string.pointer,
15562306a36Sopenharmony_ci							       string_obj[elem].string.length,
15662306a36Sopenharmony_ci							       &str_value, &value_len);
15762306a36Sopenharmony_ci
15862306a36Sopenharmony_ci				if (ret)
15962306a36Sopenharmony_ci					continue;
16062306a36Sopenharmony_ci			}
16162306a36Sopenharmony_ci			break;
16262306a36Sopenharmony_ci		case ACPI_TYPE_INTEGER:
16362306a36Sopenharmony_ci			int_value = (u32)string_obj[elem].integer.value;
16462306a36Sopenharmony_ci			break;
16562306a36Sopenharmony_ci		default:
16662306a36Sopenharmony_ci			pr_warn("Unsupported object type [%d]\n", string_obj[elem].type);
16762306a36Sopenharmony_ci			continue;
16862306a36Sopenharmony_ci		}
16962306a36Sopenharmony_ci
17062306a36Sopenharmony_ci		/* Check that both expected and read object type match */
17162306a36Sopenharmony_ci		if (expected_string_types[eloc] != string_obj[elem].type) {
17262306a36Sopenharmony_ci			pr_err("Error expected type %d for elem %d, but got type %d instead\n",
17362306a36Sopenharmony_ci			       expected_string_types[eloc], elem, string_obj[elem].type);
17462306a36Sopenharmony_ci			kfree(str_value);
17562306a36Sopenharmony_ci			return -EIO;
17662306a36Sopenharmony_ci		}
17762306a36Sopenharmony_ci
17862306a36Sopenharmony_ci		/* Assign appropriate element value to corresponding field*/
17962306a36Sopenharmony_ci		switch (eloc) {
18062306a36Sopenharmony_ci		case VALUE:
18162306a36Sopenharmony_ci			strscpy(string_data->current_value,
18262306a36Sopenharmony_ci				str_value, sizeof(string_data->current_value));
18362306a36Sopenharmony_ci			break;
18462306a36Sopenharmony_ci		case PATH:
18562306a36Sopenharmony_ci			strscpy(string_data->common.path, str_value,
18662306a36Sopenharmony_ci				sizeof(string_data->common.path));
18762306a36Sopenharmony_ci			break;
18862306a36Sopenharmony_ci		case IS_READONLY:
18962306a36Sopenharmony_ci			string_data->common.is_readonly = int_value;
19062306a36Sopenharmony_ci			break;
19162306a36Sopenharmony_ci		case DISPLAY_IN_UI:
19262306a36Sopenharmony_ci			string_data->common.display_in_ui = int_value;
19362306a36Sopenharmony_ci			break;
19462306a36Sopenharmony_ci		case REQUIRES_PHYSICAL_PRESENCE:
19562306a36Sopenharmony_ci			string_data->common.requires_physical_presence = int_value;
19662306a36Sopenharmony_ci			break;
19762306a36Sopenharmony_ci		case SEQUENCE:
19862306a36Sopenharmony_ci			string_data->common.sequence = int_value;
19962306a36Sopenharmony_ci			break;
20062306a36Sopenharmony_ci		case PREREQUISITES_SIZE:
20162306a36Sopenharmony_ci			if (int_value > MAX_PREREQUISITES_SIZE) {
20262306a36Sopenharmony_ci				pr_warn("Prerequisites size value exceeded the maximum number of elements supported or data may be malformed\n");
20362306a36Sopenharmony_ci				int_value = MAX_PREREQUISITES_SIZE;
20462306a36Sopenharmony_ci			}
20562306a36Sopenharmony_ci			string_data->common.prerequisites_size = int_value;
20662306a36Sopenharmony_ci
20762306a36Sopenharmony_ci			/*
20862306a36Sopenharmony_ci			 * This step is needed to keep the expected
20962306a36Sopenharmony_ci			 * element list pointing to the right obj[elem].type
21062306a36Sopenharmony_ci			 * when the size is zero. PREREQUISITES
21162306a36Sopenharmony_ci			 * object is omitted by BIOS when the size is
21262306a36Sopenharmony_ci			 * zero.
21362306a36Sopenharmony_ci			 */
21462306a36Sopenharmony_ci			if (string_data->common.prerequisites_size == 0)
21562306a36Sopenharmony_ci				eloc++;
21662306a36Sopenharmony_ci			break;
21762306a36Sopenharmony_ci		case PREREQUISITES:
21862306a36Sopenharmony_ci			size = min_t(u32, string_data->common.prerequisites_size,
21962306a36Sopenharmony_ci				     MAX_PREREQUISITES_SIZE);
22062306a36Sopenharmony_ci
22162306a36Sopenharmony_ci			for (reqs = 0; reqs < size; reqs++) {
22262306a36Sopenharmony_ci				if (elem >= string_obj_count) {
22362306a36Sopenharmony_ci					pr_err("Error elem-objects package is too small\n");
22462306a36Sopenharmony_ci					return -EINVAL;
22562306a36Sopenharmony_ci				}
22662306a36Sopenharmony_ci
22762306a36Sopenharmony_ci				ret = hp_convert_hexstr_to_str(string_obj[elem + reqs].string.pointer,
22862306a36Sopenharmony_ci							       string_obj[elem + reqs].string.length,
22962306a36Sopenharmony_ci							       &str_value, &value_len);
23062306a36Sopenharmony_ci
23162306a36Sopenharmony_ci				if (ret)
23262306a36Sopenharmony_ci					continue;
23362306a36Sopenharmony_ci
23462306a36Sopenharmony_ci				strscpy(string_data->common.prerequisites[reqs],
23562306a36Sopenharmony_ci					str_value,
23662306a36Sopenharmony_ci					sizeof(string_data->common.prerequisites[reqs]));
23762306a36Sopenharmony_ci				kfree(str_value);
23862306a36Sopenharmony_ci				str_value = NULL;
23962306a36Sopenharmony_ci			}
24062306a36Sopenharmony_ci			break;
24162306a36Sopenharmony_ci
24262306a36Sopenharmony_ci		case SECURITY_LEVEL:
24362306a36Sopenharmony_ci			string_data->common.security_level = int_value;
24462306a36Sopenharmony_ci			break;
24562306a36Sopenharmony_ci		case STR_MIN_LENGTH:
24662306a36Sopenharmony_ci			string_data->min_length = int_value;
24762306a36Sopenharmony_ci			break;
24862306a36Sopenharmony_ci		case STR_MAX_LENGTH:
24962306a36Sopenharmony_ci			string_data->max_length = int_value;
25062306a36Sopenharmony_ci			break;
25162306a36Sopenharmony_ci		default:
25262306a36Sopenharmony_ci			pr_warn("Invalid element: %d found in String attribute or data may be malformed\n", elem);
25362306a36Sopenharmony_ci			break;
25462306a36Sopenharmony_ci		}
25562306a36Sopenharmony_ci
25662306a36Sopenharmony_ci		kfree(str_value);
25762306a36Sopenharmony_ci		str_value = NULL;
25862306a36Sopenharmony_ci	}
25962306a36Sopenharmony_ci
26062306a36Sopenharmony_ciexit_string_package:
26162306a36Sopenharmony_ci	kfree(str_value);
26262306a36Sopenharmony_ci	return 0;
26362306a36Sopenharmony_ci}
26462306a36Sopenharmony_ci
26562306a36Sopenharmony_ci/**
26662306a36Sopenharmony_ci * hp_populate_string_package_data() -
26762306a36Sopenharmony_ci * Populate all properties of an instance under string attribute
26862306a36Sopenharmony_ci *
26962306a36Sopenharmony_ci * @string_obj: ACPI object with string data
27062306a36Sopenharmony_ci * @instance_id: The instance to enumerate
27162306a36Sopenharmony_ci * @attr_name_kobj: The parent kernel object
27262306a36Sopenharmony_ci */
27362306a36Sopenharmony_ciint hp_populate_string_package_data(union acpi_object *string_obj,
27462306a36Sopenharmony_ci				    int instance_id,
27562306a36Sopenharmony_ci				    struct kobject *attr_name_kobj)
27662306a36Sopenharmony_ci{
27762306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
27862306a36Sopenharmony_ci
27962306a36Sopenharmony_ci	string_data->attr_name_kobj = attr_name_kobj;
28062306a36Sopenharmony_ci
28162306a36Sopenharmony_ci	hp_populate_string_elements_from_package(string_obj,
28262306a36Sopenharmony_ci						 string_obj->package.count,
28362306a36Sopenharmony_ci						 instance_id);
28462306a36Sopenharmony_ci
28562306a36Sopenharmony_ci	hp_update_attribute_permissions(string_data->common.is_readonly,
28662306a36Sopenharmony_ci					&string_current_val);
28762306a36Sopenharmony_ci	hp_friendly_user_name_update(string_data->common.path,
28862306a36Sopenharmony_ci				     attr_name_kobj->name,
28962306a36Sopenharmony_ci				     string_data->common.display_name,
29062306a36Sopenharmony_ci				     sizeof(string_data->common.display_name));
29162306a36Sopenharmony_ci	return sysfs_create_group(attr_name_kobj, &string_attr_group);
29262306a36Sopenharmony_ci}
29362306a36Sopenharmony_ci
29462306a36Sopenharmony_cistatic int hp_populate_string_elements_from_buffer(u8 *buffer_ptr, u32 *buffer_size,
29562306a36Sopenharmony_ci						   int instance_id)
29662306a36Sopenharmony_ci{
29762306a36Sopenharmony_ci	int ret = 0;
29862306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
29962306a36Sopenharmony_ci
30062306a36Sopenharmony_ci	/*
30162306a36Sopenharmony_ci	 * Only data relevant to this driver and its functionality is
30262306a36Sopenharmony_ci	 * read. BIOS defines the order in which each * element is
30362306a36Sopenharmony_ci	 * read. Element 0 data is not relevant to this
30462306a36Sopenharmony_ci	 * driver hence it is ignored. For clarity, all element names
30562306a36Sopenharmony_ci	 * (DISPLAY_IN_UI) which defines the order in which is read
30662306a36Sopenharmony_ci	 * and the name matches the variable where the data is stored.
30762306a36Sopenharmony_ci	 *
30862306a36Sopenharmony_ci	 * In earlier implementation, reported errors were ignored
30962306a36Sopenharmony_ci	 * causing the data to remain uninitialized. It is not
31062306a36Sopenharmony_ci	 * possible to determine if data read from BIOS is valid or
31162306a36Sopenharmony_ci	 * not. It is for this reason functions may return a error
31262306a36Sopenharmony_ci	 * without validating the data itself.
31362306a36Sopenharmony_ci	 */
31462306a36Sopenharmony_ci
31562306a36Sopenharmony_ci	// VALUE:
31662306a36Sopenharmony_ci	ret = hp_get_string_from_buffer(&buffer_ptr, buffer_size, string_data->current_value,
31762306a36Sopenharmony_ci					sizeof(string_data->current_value));
31862306a36Sopenharmony_ci	if (ret < 0)
31962306a36Sopenharmony_ci		goto buffer_exit;
32062306a36Sopenharmony_ci
32162306a36Sopenharmony_ci	// COMMON:
32262306a36Sopenharmony_ci	ret = hp_get_common_data_from_buffer(&buffer_ptr, buffer_size, &string_data->common);
32362306a36Sopenharmony_ci	if (ret < 0)
32462306a36Sopenharmony_ci		goto buffer_exit;
32562306a36Sopenharmony_ci
32662306a36Sopenharmony_ci	// STR_MIN_LENGTH:
32762306a36Sopenharmony_ci	ret = hp_get_integer_from_buffer(&buffer_ptr, buffer_size,
32862306a36Sopenharmony_ci					 &string_data->min_length);
32962306a36Sopenharmony_ci	if (ret < 0)
33062306a36Sopenharmony_ci		goto buffer_exit;
33162306a36Sopenharmony_ci
33262306a36Sopenharmony_ci	// STR_MAX_LENGTH:
33362306a36Sopenharmony_ci	ret = hp_get_integer_from_buffer(&buffer_ptr, buffer_size,
33462306a36Sopenharmony_ci					 &string_data->max_length);
33562306a36Sopenharmony_ci
33662306a36Sopenharmony_cibuffer_exit:
33762306a36Sopenharmony_ci
33862306a36Sopenharmony_ci	return ret;
33962306a36Sopenharmony_ci}
34062306a36Sopenharmony_ci
34162306a36Sopenharmony_ci/**
34262306a36Sopenharmony_ci * hp_populate_string_buffer_data() -
34362306a36Sopenharmony_ci * Populate all properties of an instance under string attribute
34462306a36Sopenharmony_ci *
34562306a36Sopenharmony_ci * @buffer_ptr: Buffer pointer
34662306a36Sopenharmony_ci * @buffer_size: Buffer size
34762306a36Sopenharmony_ci * @instance_id: The instance to enumerate
34862306a36Sopenharmony_ci * @attr_name_kobj: The parent kernel object
34962306a36Sopenharmony_ci */
35062306a36Sopenharmony_ciint hp_populate_string_buffer_data(u8 *buffer_ptr, u32 *buffer_size,
35162306a36Sopenharmony_ci				   int instance_id,
35262306a36Sopenharmony_ci				   struct kobject *attr_name_kobj)
35362306a36Sopenharmony_ci{
35462306a36Sopenharmony_ci	struct string_data *string_data = &bioscfg_drv.string_data[instance_id];
35562306a36Sopenharmony_ci	int ret = 0;
35662306a36Sopenharmony_ci
35762306a36Sopenharmony_ci	string_data->attr_name_kobj = attr_name_kobj;
35862306a36Sopenharmony_ci
35962306a36Sopenharmony_ci	ret = hp_populate_string_elements_from_buffer(buffer_ptr, buffer_size,
36062306a36Sopenharmony_ci						      instance_id);
36162306a36Sopenharmony_ci	if (ret < 0)
36262306a36Sopenharmony_ci		return ret;
36362306a36Sopenharmony_ci
36462306a36Sopenharmony_ci	hp_update_attribute_permissions(string_data->common.is_readonly,
36562306a36Sopenharmony_ci					&string_current_val);
36662306a36Sopenharmony_ci	hp_friendly_user_name_update(string_data->common.path,
36762306a36Sopenharmony_ci				     attr_name_kobj->name,
36862306a36Sopenharmony_ci				     string_data->common.display_name,
36962306a36Sopenharmony_ci				     sizeof(string_data->common.display_name));
37062306a36Sopenharmony_ci
37162306a36Sopenharmony_ci	return sysfs_create_group(attr_name_kobj, &string_attr_group);
37262306a36Sopenharmony_ci}
37362306a36Sopenharmony_ci
37462306a36Sopenharmony_ci/**
37562306a36Sopenharmony_ci * hp_exit_string_attributes() - Clear all attribute data
37662306a36Sopenharmony_ci *
37762306a36Sopenharmony_ci * Clears all data allocated for this group of attributes
37862306a36Sopenharmony_ci */
37962306a36Sopenharmony_civoid hp_exit_string_attributes(void)
38062306a36Sopenharmony_ci{
38162306a36Sopenharmony_ci	int instance_id;
38262306a36Sopenharmony_ci
38362306a36Sopenharmony_ci	for (instance_id = 0; instance_id < bioscfg_drv.string_instances_count;
38462306a36Sopenharmony_ci	     instance_id++) {
38562306a36Sopenharmony_ci		struct kobject *attr_name_kobj =
38662306a36Sopenharmony_ci			bioscfg_drv.string_data[instance_id].attr_name_kobj;
38762306a36Sopenharmony_ci
38862306a36Sopenharmony_ci		if (attr_name_kobj)
38962306a36Sopenharmony_ci			sysfs_remove_group(attr_name_kobj, &string_attr_group);
39062306a36Sopenharmony_ci	}
39162306a36Sopenharmony_ci	bioscfg_drv.string_instances_count = 0;
39262306a36Sopenharmony_ci
39362306a36Sopenharmony_ci	kfree(bioscfg_drv.string_data);
39462306a36Sopenharmony_ci	bioscfg_drv.string_data = NULL;
39562306a36Sopenharmony_ci}
396