162306a36Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only
262306a36Sopenharmony_ci/*
362306a36Sopenharmony_ci * Copyright (C) 2016 Broadcom Limited
462306a36Sopenharmony_ci */
562306a36Sopenharmony_ci
662306a36Sopenharmony_ci/**
762306a36Sopenharmony_ci * DOC: VC4 DPI module
862306a36Sopenharmony_ci *
962306a36Sopenharmony_ci * The VC4 DPI hardware supports MIPI DPI type 4 and Nokia ViSSI
1062306a36Sopenharmony_ci * signals.  On BCM2835, these can be routed out to GPIO0-27 with the
1162306a36Sopenharmony_ci * ALT2 function.
1262306a36Sopenharmony_ci */
1362306a36Sopenharmony_ci
1462306a36Sopenharmony_ci#include <drm/drm_atomic_helper.h>
1562306a36Sopenharmony_ci#include <drm/drm_bridge.h>
1662306a36Sopenharmony_ci#include <drm/drm_drv.h>
1762306a36Sopenharmony_ci#include <drm/drm_edid.h>
1862306a36Sopenharmony_ci#include <drm/drm_of.h>
1962306a36Sopenharmony_ci#include <drm/drm_panel.h>
2062306a36Sopenharmony_ci#include <drm/drm_probe_helper.h>
2162306a36Sopenharmony_ci#include <drm/drm_simple_kms_helper.h>
2262306a36Sopenharmony_ci#include <linux/clk.h>
2362306a36Sopenharmony_ci#include <linux/component.h>
2462306a36Sopenharmony_ci#include <linux/media-bus-format.h>
2562306a36Sopenharmony_ci#include <linux/mod_devicetable.h>
2662306a36Sopenharmony_ci#include <linux/platform_device.h>
2762306a36Sopenharmony_ci#include "vc4_drv.h"
2862306a36Sopenharmony_ci#include "vc4_regs.h"
2962306a36Sopenharmony_ci
3062306a36Sopenharmony_ci#define DPI_C			0x00
3162306a36Sopenharmony_ci# define DPI_OUTPUT_ENABLE_MODE		BIT(16)
3262306a36Sopenharmony_ci
3362306a36Sopenharmony_ci/* The order field takes the incoming 24 bit RGB from the pixel valve
3462306a36Sopenharmony_ci * and shuffles the 3 channels.
3562306a36Sopenharmony_ci */
3662306a36Sopenharmony_ci# define DPI_ORDER_MASK			VC4_MASK(15, 14)
3762306a36Sopenharmony_ci# define DPI_ORDER_SHIFT		14
3862306a36Sopenharmony_ci# define DPI_ORDER_RGB			0
3962306a36Sopenharmony_ci# define DPI_ORDER_BGR			1
4062306a36Sopenharmony_ci# define DPI_ORDER_GRB			2
4162306a36Sopenharmony_ci# define DPI_ORDER_BRG			3
4262306a36Sopenharmony_ci
4362306a36Sopenharmony_ci/* The format field takes the ORDER-shuffled pixel valve data and
4462306a36Sopenharmony_ci * formats it onto the output lines.
4562306a36Sopenharmony_ci */
4662306a36Sopenharmony_ci# define DPI_FORMAT_MASK		VC4_MASK(13, 11)
4762306a36Sopenharmony_ci# define DPI_FORMAT_SHIFT		11
4862306a36Sopenharmony_ci/* This define is named in the hardware, but actually just outputs 0. */
4962306a36Sopenharmony_ci# define DPI_FORMAT_9BIT_666_RGB	0
5062306a36Sopenharmony_ci/* Outputs 00000000rrrrrggggggbbbbb */
5162306a36Sopenharmony_ci# define DPI_FORMAT_16BIT_565_RGB_1	1
5262306a36Sopenharmony_ci/* Outputs 000rrrrr00gggggg000bbbbb */
5362306a36Sopenharmony_ci# define DPI_FORMAT_16BIT_565_RGB_2	2
5462306a36Sopenharmony_ci/* Outputs 00rrrrr000gggggg00bbbbb0 */
5562306a36Sopenharmony_ci# define DPI_FORMAT_16BIT_565_RGB_3	3
5662306a36Sopenharmony_ci/* Outputs 000000rrrrrrggggggbbbbbb */
5762306a36Sopenharmony_ci# define DPI_FORMAT_18BIT_666_RGB_1	4
5862306a36Sopenharmony_ci/* Outputs 00rrrrrr00gggggg00bbbbbb */
5962306a36Sopenharmony_ci# define DPI_FORMAT_18BIT_666_RGB_2	5
6062306a36Sopenharmony_ci/* Outputs rrrrrrrrggggggggbbbbbbbb */
6162306a36Sopenharmony_ci# define DPI_FORMAT_24BIT_888_RGB	6
6262306a36Sopenharmony_ci
6362306a36Sopenharmony_ci/* Reverses the polarity of the corresponding signal */
6462306a36Sopenharmony_ci# define DPI_PIXEL_CLK_INVERT		BIT(10)
6562306a36Sopenharmony_ci# define DPI_HSYNC_INVERT		BIT(9)
6662306a36Sopenharmony_ci# define DPI_VSYNC_INVERT		BIT(8)
6762306a36Sopenharmony_ci# define DPI_OUTPUT_ENABLE_INVERT	BIT(7)
6862306a36Sopenharmony_ci
6962306a36Sopenharmony_ci/* Outputs the signal the falling clock edge instead of rising. */
7062306a36Sopenharmony_ci# define DPI_HSYNC_NEGATE		BIT(6)
7162306a36Sopenharmony_ci# define DPI_VSYNC_NEGATE		BIT(5)
7262306a36Sopenharmony_ci# define DPI_OUTPUT_ENABLE_NEGATE	BIT(4)
7362306a36Sopenharmony_ci
7462306a36Sopenharmony_ci/* Disables the signal */
7562306a36Sopenharmony_ci# define DPI_HSYNC_DISABLE		BIT(3)
7662306a36Sopenharmony_ci# define DPI_VSYNC_DISABLE		BIT(2)
7762306a36Sopenharmony_ci# define DPI_OUTPUT_ENABLE_DISABLE	BIT(1)
7862306a36Sopenharmony_ci
7962306a36Sopenharmony_ci/* Power gate to the device, full reset at 0 -> 1 transition */
8062306a36Sopenharmony_ci# define DPI_ENABLE			BIT(0)
8162306a36Sopenharmony_ci
8262306a36Sopenharmony_ci/* All other registers besides DPI_C return the ID */
8362306a36Sopenharmony_ci#define DPI_ID			0x04
8462306a36Sopenharmony_ci# define DPI_ID_VALUE		0x00647069
8562306a36Sopenharmony_ci
8662306a36Sopenharmony_ci/* General DPI hardware state. */
8762306a36Sopenharmony_cistruct vc4_dpi {
8862306a36Sopenharmony_ci	struct vc4_encoder encoder;
8962306a36Sopenharmony_ci
9062306a36Sopenharmony_ci	struct platform_device *pdev;
9162306a36Sopenharmony_ci
9262306a36Sopenharmony_ci	void __iomem *regs;
9362306a36Sopenharmony_ci
9462306a36Sopenharmony_ci	struct clk *pixel_clock;
9562306a36Sopenharmony_ci	struct clk *core_clock;
9662306a36Sopenharmony_ci
9762306a36Sopenharmony_ci	struct debugfs_regset32 regset;
9862306a36Sopenharmony_ci};
9962306a36Sopenharmony_ci
10062306a36Sopenharmony_ci#define to_vc4_dpi(_encoder)						\
10162306a36Sopenharmony_ci	container_of_const(_encoder, struct vc4_dpi, encoder.base)
10262306a36Sopenharmony_ci
10362306a36Sopenharmony_ci#define DPI_READ(offset)								\
10462306a36Sopenharmony_ci	({										\
10562306a36Sopenharmony_ci		kunit_fail_current_test("Accessing a register in a unit test!\n");	\
10662306a36Sopenharmony_ci		readl(dpi->regs + (offset));						\
10762306a36Sopenharmony_ci	})
10862306a36Sopenharmony_ci
10962306a36Sopenharmony_ci#define DPI_WRITE(offset, val)								\
11062306a36Sopenharmony_ci	do {										\
11162306a36Sopenharmony_ci		kunit_fail_current_test("Accessing a register in a unit test!\n");	\
11262306a36Sopenharmony_ci		writel(val, dpi->regs + (offset));					\
11362306a36Sopenharmony_ci	} while (0)
11462306a36Sopenharmony_ci
11562306a36Sopenharmony_cistatic const struct debugfs_reg32 dpi_regs[] = {
11662306a36Sopenharmony_ci	VC4_REG32(DPI_C),
11762306a36Sopenharmony_ci	VC4_REG32(DPI_ID),
11862306a36Sopenharmony_ci};
11962306a36Sopenharmony_ci
12062306a36Sopenharmony_cistatic void vc4_dpi_encoder_disable(struct drm_encoder *encoder)
12162306a36Sopenharmony_ci{
12262306a36Sopenharmony_ci	struct drm_device *dev = encoder->dev;
12362306a36Sopenharmony_ci	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
12462306a36Sopenharmony_ci	int idx;
12562306a36Sopenharmony_ci
12662306a36Sopenharmony_ci	if (!drm_dev_enter(dev, &idx))
12762306a36Sopenharmony_ci		return;
12862306a36Sopenharmony_ci
12962306a36Sopenharmony_ci	clk_disable_unprepare(dpi->pixel_clock);
13062306a36Sopenharmony_ci
13162306a36Sopenharmony_ci	drm_dev_exit(idx);
13262306a36Sopenharmony_ci}
13362306a36Sopenharmony_ci
13462306a36Sopenharmony_cistatic void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
13562306a36Sopenharmony_ci{
13662306a36Sopenharmony_ci	struct drm_device *dev = encoder->dev;
13762306a36Sopenharmony_ci	struct drm_display_mode *mode = &encoder->crtc->mode;
13862306a36Sopenharmony_ci	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
13962306a36Sopenharmony_ci	struct drm_connector_list_iter conn_iter;
14062306a36Sopenharmony_ci	struct drm_connector *connector = NULL, *connector_scan;
14162306a36Sopenharmony_ci	u32 dpi_c = DPI_ENABLE;
14262306a36Sopenharmony_ci	int idx;
14362306a36Sopenharmony_ci	int ret;
14462306a36Sopenharmony_ci
14562306a36Sopenharmony_ci	/* Look up the connector attached to DPI so we can get the
14662306a36Sopenharmony_ci	 * bus_format.  Ideally the bridge would tell us the
14762306a36Sopenharmony_ci	 * bus_format we want, but it doesn't yet, so assume that it's
14862306a36Sopenharmony_ci	 * uniform throughout the bridge chain.
14962306a36Sopenharmony_ci	 */
15062306a36Sopenharmony_ci	drm_connector_list_iter_begin(dev, &conn_iter);
15162306a36Sopenharmony_ci	drm_for_each_connector_iter(connector_scan, &conn_iter) {
15262306a36Sopenharmony_ci		if (connector_scan->encoder == encoder) {
15362306a36Sopenharmony_ci			connector = connector_scan;
15462306a36Sopenharmony_ci			break;
15562306a36Sopenharmony_ci		}
15662306a36Sopenharmony_ci	}
15762306a36Sopenharmony_ci	drm_connector_list_iter_end(&conn_iter);
15862306a36Sopenharmony_ci
15962306a36Sopenharmony_ci	/* Default to 18bit if no connector or format found. */
16062306a36Sopenharmony_ci	dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT);
16162306a36Sopenharmony_ci
16262306a36Sopenharmony_ci	if (connector) {
16362306a36Sopenharmony_ci		if (connector->display_info.num_bus_formats) {
16462306a36Sopenharmony_ci			u32 bus_format = connector->display_info.bus_formats[0];
16562306a36Sopenharmony_ci
16662306a36Sopenharmony_ci			dpi_c &= ~DPI_FORMAT_MASK;
16762306a36Sopenharmony_ci
16862306a36Sopenharmony_ci			switch (bus_format) {
16962306a36Sopenharmony_ci			case MEDIA_BUS_FMT_RGB888_1X24:
17062306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
17162306a36Sopenharmony_ci						       DPI_FORMAT);
17262306a36Sopenharmony_ci				break;
17362306a36Sopenharmony_ci			case MEDIA_BUS_FMT_BGR888_1X24:
17462306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
17562306a36Sopenharmony_ci						       DPI_FORMAT);
17662306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR,
17762306a36Sopenharmony_ci						       DPI_ORDER);
17862306a36Sopenharmony_ci				break;
17962306a36Sopenharmony_ci			case MEDIA_BUS_FMT_BGR666_1X24_CPADHI:
18062306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER);
18162306a36Sopenharmony_ci				fallthrough;
18262306a36Sopenharmony_ci			case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
18362306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2,
18462306a36Sopenharmony_ci						       DPI_FORMAT);
18562306a36Sopenharmony_ci				break;
18662306a36Sopenharmony_ci			case MEDIA_BUS_FMT_BGR666_1X18:
18762306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER);
18862306a36Sopenharmony_ci				fallthrough;
18962306a36Sopenharmony_ci			case MEDIA_BUS_FMT_RGB666_1X18:
19062306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1,
19162306a36Sopenharmony_ci						       DPI_FORMAT);
19262306a36Sopenharmony_ci				break;
19362306a36Sopenharmony_ci			case MEDIA_BUS_FMT_RGB565_1X16:
19462306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1,
19562306a36Sopenharmony_ci						       DPI_FORMAT);
19662306a36Sopenharmony_ci				break;
19762306a36Sopenharmony_ci			case MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
19862306a36Sopenharmony_ci				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2,
19962306a36Sopenharmony_ci						       DPI_FORMAT);
20062306a36Sopenharmony_ci				break;
20162306a36Sopenharmony_ci			default:
20262306a36Sopenharmony_ci				DRM_ERROR("Unknown media bus format %d\n",
20362306a36Sopenharmony_ci					  bus_format);
20462306a36Sopenharmony_ci				break;
20562306a36Sopenharmony_ci			}
20662306a36Sopenharmony_ci		}
20762306a36Sopenharmony_ci
20862306a36Sopenharmony_ci		if (connector->display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)
20962306a36Sopenharmony_ci			dpi_c |= DPI_PIXEL_CLK_INVERT;
21062306a36Sopenharmony_ci
21162306a36Sopenharmony_ci		if (connector->display_info.bus_flags & DRM_BUS_FLAG_DE_LOW)
21262306a36Sopenharmony_ci			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
21362306a36Sopenharmony_ci	}
21462306a36Sopenharmony_ci
21562306a36Sopenharmony_ci	if (mode->flags & DRM_MODE_FLAG_CSYNC) {
21662306a36Sopenharmony_ci		if (mode->flags & DRM_MODE_FLAG_NCSYNC)
21762306a36Sopenharmony_ci			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
21862306a36Sopenharmony_ci	} else {
21962306a36Sopenharmony_ci		dpi_c |= DPI_OUTPUT_ENABLE_MODE;
22062306a36Sopenharmony_ci
22162306a36Sopenharmony_ci		if (mode->flags & DRM_MODE_FLAG_NHSYNC)
22262306a36Sopenharmony_ci			dpi_c |= DPI_HSYNC_INVERT;
22362306a36Sopenharmony_ci		else if (!(mode->flags & DRM_MODE_FLAG_PHSYNC))
22462306a36Sopenharmony_ci			dpi_c |= DPI_HSYNC_DISABLE;
22562306a36Sopenharmony_ci
22662306a36Sopenharmony_ci		if (mode->flags & DRM_MODE_FLAG_NVSYNC)
22762306a36Sopenharmony_ci			dpi_c |= DPI_VSYNC_INVERT;
22862306a36Sopenharmony_ci		else if (!(mode->flags & DRM_MODE_FLAG_PVSYNC))
22962306a36Sopenharmony_ci			dpi_c |= DPI_VSYNC_DISABLE;
23062306a36Sopenharmony_ci	}
23162306a36Sopenharmony_ci
23262306a36Sopenharmony_ci	if (!drm_dev_enter(dev, &idx))
23362306a36Sopenharmony_ci		return;
23462306a36Sopenharmony_ci
23562306a36Sopenharmony_ci	DPI_WRITE(DPI_C, dpi_c);
23662306a36Sopenharmony_ci
23762306a36Sopenharmony_ci	ret = clk_set_rate(dpi->pixel_clock, mode->clock * 1000);
23862306a36Sopenharmony_ci	if (ret)
23962306a36Sopenharmony_ci		DRM_ERROR("Failed to set clock rate: %d\n", ret);
24062306a36Sopenharmony_ci
24162306a36Sopenharmony_ci	ret = clk_prepare_enable(dpi->pixel_clock);
24262306a36Sopenharmony_ci	if (ret)
24362306a36Sopenharmony_ci		DRM_ERROR("Failed to set clock rate: %d\n", ret);
24462306a36Sopenharmony_ci
24562306a36Sopenharmony_ci	drm_dev_exit(idx);
24662306a36Sopenharmony_ci}
24762306a36Sopenharmony_ci
24862306a36Sopenharmony_cistatic enum drm_mode_status vc4_dpi_encoder_mode_valid(struct drm_encoder *encoder,
24962306a36Sopenharmony_ci						       const struct drm_display_mode *mode)
25062306a36Sopenharmony_ci{
25162306a36Sopenharmony_ci	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
25262306a36Sopenharmony_ci		return MODE_NO_INTERLACE;
25362306a36Sopenharmony_ci
25462306a36Sopenharmony_ci	return MODE_OK;
25562306a36Sopenharmony_ci}
25662306a36Sopenharmony_ci
25762306a36Sopenharmony_cistatic const struct drm_encoder_helper_funcs vc4_dpi_encoder_helper_funcs = {
25862306a36Sopenharmony_ci	.disable = vc4_dpi_encoder_disable,
25962306a36Sopenharmony_ci	.enable = vc4_dpi_encoder_enable,
26062306a36Sopenharmony_ci	.mode_valid = vc4_dpi_encoder_mode_valid,
26162306a36Sopenharmony_ci};
26262306a36Sopenharmony_ci
26362306a36Sopenharmony_cistatic int vc4_dpi_late_register(struct drm_encoder *encoder)
26462306a36Sopenharmony_ci{
26562306a36Sopenharmony_ci	struct drm_device *drm = encoder->dev;
26662306a36Sopenharmony_ci	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
26762306a36Sopenharmony_ci
26862306a36Sopenharmony_ci	vc4_debugfs_add_regset32(drm, "dpi_regs", &dpi->regset);
26962306a36Sopenharmony_ci
27062306a36Sopenharmony_ci	return 0;
27162306a36Sopenharmony_ci}
27262306a36Sopenharmony_ci
27362306a36Sopenharmony_cistatic const struct drm_encoder_funcs vc4_dpi_encoder_funcs = {
27462306a36Sopenharmony_ci	.late_register = vc4_dpi_late_register,
27562306a36Sopenharmony_ci};
27662306a36Sopenharmony_ci
27762306a36Sopenharmony_cistatic const struct of_device_id vc4_dpi_dt_match[] = {
27862306a36Sopenharmony_ci	{ .compatible = "brcm,bcm2835-dpi", .data = NULL },
27962306a36Sopenharmony_ci	{}
28062306a36Sopenharmony_ci};
28162306a36Sopenharmony_ci
28262306a36Sopenharmony_ci/* Sets up the next link in the display chain, whether it's a panel or
28362306a36Sopenharmony_ci * a bridge.
28462306a36Sopenharmony_ci */
28562306a36Sopenharmony_cistatic int vc4_dpi_init_bridge(struct vc4_dpi *dpi)
28662306a36Sopenharmony_ci{
28762306a36Sopenharmony_ci	struct drm_device *drm = dpi->encoder.base.dev;
28862306a36Sopenharmony_ci	struct device *dev = &dpi->pdev->dev;
28962306a36Sopenharmony_ci	struct drm_bridge *bridge;
29062306a36Sopenharmony_ci
29162306a36Sopenharmony_ci	bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0);
29262306a36Sopenharmony_ci	if (IS_ERR(bridge)) {
29362306a36Sopenharmony_ci		/* If nothing was connected in the DT, that's not an
29462306a36Sopenharmony_ci		 * error.
29562306a36Sopenharmony_ci		 */
29662306a36Sopenharmony_ci		if (PTR_ERR(bridge) == -ENODEV)
29762306a36Sopenharmony_ci			return 0;
29862306a36Sopenharmony_ci		else
29962306a36Sopenharmony_ci			return PTR_ERR(bridge);
30062306a36Sopenharmony_ci	}
30162306a36Sopenharmony_ci
30262306a36Sopenharmony_ci	return drm_bridge_attach(&dpi->encoder.base, bridge, NULL, 0);
30362306a36Sopenharmony_ci}
30462306a36Sopenharmony_ci
30562306a36Sopenharmony_cistatic void vc4_dpi_disable_clock(void *ptr)
30662306a36Sopenharmony_ci{
30762306a36Sopenharmony_ci	struct vc4_dpi *dpi = ptr;
30862306a36Sopenharmony_ci
30962306a36Sopenharmony_ci	clk_disable_unprepare(dpi->core_clock);
31062306a36Sopenharmony_ci}
31162306a36Sopenharmony_ci
31262306a36Sopenharmony_cistatic int vc4_dpi_bind(struct device *dev, struct device *master, void *data)
31362306a36Sopenharmony_ci{
31462306a36Sopenharmony_ci	struct platform_device *pdev = to_platform_device(dev);
31562306a36Sopenharmony_ci	struct drm_device *drm = dev_get_drvdata(master);
31662306a36Sopenharmony_ci	struct vc4_dpi *dpi;
31762306a36Sopenharmony_ci	int ret;
31862306a36Sopenharmony_ci
31962306a36Sopenharmony_ci	dpi = drmm_kzalloc(drm, sizeof(*dpi), GFP_KERNEL);
32062306a36Sopenharmony_ci	if (!dpi)
32162306a36Sopenharmony_ci		return -ENOMEM;
32262306a36Sopenharmony_ci
32362306a36Sopenharmony_ci	dpi->encoder.type = VC4_ENCODER_TYPE_DPI;
32462306a36Sopenharmony_ci	dpi->pdev = pdev;
32562306a36Sopenharmony_ci	dpi->regs = vc4_ioremap_regs(pdev, 0);
32662306a36Sopenharmony_ci	if (IS_ERR(dpi->regs))
32762306a36Sopenharmony_ci		return PTR_ERR(dpi->regs);
32862306a36Sopenharmony_ci	dpi->regset.base = dpi->regs;
32962306a36Sopenharmony_ci	dpi->regset.regs = dpi_regs;
33062306a36Sopenharmony_ci	dpi->regset.nregs = ARRAY_SIZE(dpi_regs);
33162306a36Sopenharmony_ci
33262306a36Sopenharmony_ci	if (DPI_READ(DPI_ID) != DPI_ID_VALUE) {
33362306a36Sopenharmony_ci		dev_err(dev, "Port returned 0x%08x for ID instead of 0x%08x\n",
33462306a36Sopenharmony_ci			DPI_READ(DPI_ID), DPI_ID_VALUE);
33562306a36Sopenharmony_ci		return -ENODEV;
33662306a36Sopenharmony_ci	}
33762306a36Sopenharmony_ci
33862306a36Sopenharmony_ci	dpi->core_clock = devm_clk_get(dev, "core");
33962306a36Sopenharmony_ci	if (IS_ERR(dpi->core_clock)) {
34062306a36Sopenharmony_ci		ret = PTR_ERR(dpi->core_clock);
34162306a36Sopenharmony_ci		if (ret != -EPROBE_DEFER)
34262306a36Sopenharmony_ci			DRM_ERROR("Failed to get core clock: %d\n", ret);
34362306a36Sopenharmony_ci		return ret;
34462306a36Sopenharmony_ci	}
34562306a36Sopenharmony_ci
34662306a36Sopenharmony_ci	dpi->pixel_clock = devm_clk_get(dev, "pixel");
34762306a36Sopenharmony_ci	if (IS_ERR(dpi->pixel_clock)) {
34862306a36Sopenharmony_ci		ret = PTR_ERR(dpi->pixel_clock);
34962306a36Sopenharmony_ci		if (ret != -EPROBE_DEFER)
35062306a36Sopenharmony_ci			DRM_ERROR("Failed to get pixel clock: %d\n", ret);
35162306a36Sopenharmony_ci		return ret;
35262306a36Sopenharmony_ci	}
35362306a36Sopenharmony_ci
35462306a36Sopenharmony_ci	ret = clk_prepare_enable(dpi->core_clock);
35562306a36Sopenharmony_ci	if (ret) {
35662306a36Sopenharmony_ci		DRM_ERROR("Failed to turn on core clock: %d\n", ret);
35762306a36Sopenharmony_ci		return ret;
35862306a36Sopenharmony_ci	}
35962306a36Sopenharmony_ci
36062306a36Sopenharmony_ci	ret = devm_add_action_or_reset(dev, vc4_dpi_disable_clock, dpi);
36162306a36Sopenharmony_ci	if (ret)
36262306a36Sopenharmony_ci		return ret;
36362306a36Sopenharmony_ci
36462306a36Sopenharmony_ci	ret = drmm_encoder_init(drm, &dpi->encoder.base,
36562306a36Sopenharmony_ci				&vc4_dpi_encoder_funcs,
36662306a36Sopenharmony_ci				DRM_MODE_ENCODER_DPI,
36762306a36Sopenharmony_ci				NULL);
36862306a36Sopenharmony_ci	if (ret)
36962306a36Sopenharmony_ci		return ret;
37062306a36Sopenharmony_ci
37162306a36Sopenharmony_ci	drm_encoder_helper_add(&dpi->encoder.base, &vc4_dpi_encoder_helper_funcs);
37262306a36Sopenharmony_ci
37362306a36Sopenharmony_ci	ret = vc4_dpi_init_bridge(dpi);
37462306a36Sopenharmony_ci	if (ret)
37562306a36Sopenharmony_ci		return ret;
37662306a36Sopenharmony_ci
37762306a36Sopenharmony_ci	dev_set_drvdata(dev, dpi);
37862306a36Sopenharmony_ci
37962306a36Sopenharmony_ci	return 0;
38062306a36Sopenharmony_ci}
38162306a36Sopenharmony_ci
38262306a36Sopenharmony_cistatic const struct component_ops vc4_dpi_ops = {
38362306a36Sopenharmony_ci	.bind   = vc4_dpi_bind,
38462306a36Sopenharmony_ci};
38562306a36Sopenharmony_ci
38662306a36Sopenharmony_cistatic int vc4_dpi_dev_probe(struct platform_device *pdev)
38762306a36Sopenharmony_ci{
38862306a36Sopenharmony_ci	return component_add(&pdev->dev, &vc4_dpi_ops);
38962306a36Sopenharmony_ci}
39062306a36Sopenharmony_ci
39162306a36Sopenharmony_cistatic void vc4_dpi_dev_remove(struct platform_device *pdev)
39262306a36Sopenharmony_ci{
39362306a36Sopenharmony_ci	component_del(&pdev->dev, &vc4_dpi_ops);
39462306a36Sopenharmony_ci}
39562306a36Sopenharmony_ci
39662306a36Sopenharmony_cistruct platform_driver vc4_dpi_driver = {
39762306a36Sopenharmony_ci	.probe = vc4_dpi_dev_probe,
39862306a36Sopenharmony_ci	.remove_new = vc4_dpi_dev_remove,
39962306a36Sopenharmony_ci	.driver = {
40062306a36Sopenharmony_ci		.name = "vc4_dpi",
40162306a36Sopenharmony_ci		.of_match_table = vc4_dpi_dt_match,
40262306a36Sopenharmony_ci	},
40362306a36Sopenharmony_ci};
404