162306a36Sopenharmony_ci/*
262306a36Sopenharmony_ci * Copyright (C) 2013-2015 ARM Limited
362306a36Sopenharmony_ci * Author: Liviu Dudau <Liviu.Dudau@arm.com>
462306a36Sopenharmony_ci *
562306a36Sopenharmony_ci * This file is subject to the terms and conditions of the GNU General Public
662306a36Sopenharmony_ci * License.  See the file COPYING in the main directory of this archive
762306a36Sopenharmony_ci * for more details.
862306a36Sopenharmony_ci *
962306a36Sopenharmony_ci *  Implementation of a CRTC class for the HDLCD driver.
1062306a36Sopenharmony_ci */
1162306a36Sopenharmony_ci
1262306a36Sopenharmony_ci#include <linux/clk.h>
1362306a36Sopenharmony_ci#include <linux/of_graph.h>
1462306a36Sopenharmony_ci#include <linux/platform_data/simplefb.h>
1562306a36Sopenharmony_ci
1662306a36Sopenharmony_ci#include <video/videomode.h>
1762306a36Sopenharmony_ci
1862306a36Sopenharmony_ci#include <drm/drm_atomic.h>
1962306a36Sopenharmony_ci#include <drm/drm_atomic_helper.h>
2062306a36Sopenharmony_ci#include <drm/drm_crtc.h>
2162306a36Sopenharmony_ci#include <drm/drm_fb_dma_helper.h>
2262306a36Sopenharmony_ci#include <drm/drm_framebuffer.h>
2362306a36Sopenharmony_ci#include <drm/drm_gem_dma_helper.h>
2462306a36Sopenharmony_ci#include <drm/drm_of.h>
2562306a36Sopenharmony_ci#include <drm/drm_probe_helper.h>
2662306a36Sopenharmony_ci#include <drm/drm_vblank.h>
2762306a36Sopenharmony_ci
2862306a36Sopenharmony_ci#include "hdlcd_drv.h"
2962306a36Sopenharmony_ci#include "hdlcd_regs.h"
3062306a36Sopenharmony_ci
3162306a36Sopenharmony_ci/*
3262306a36Sopenharmony_ci * The HDLCD controller is a dumb RGB streamer that gets connected to
3362306a36Sopenharmony_ci * a single HDMI transmitter or in the case of the ARM Models it gets
3462306a36Sopenharmony_ci * emulated by the software that does the actual rendering.
3562306a36Sopenharmony_ci *
3662306a36Sopenharmony_ci */
3762306a36Sopenharmony_ci
3862306a36Sopenharmony_cistatic void hdlcd_crtc_cleanup(struct drm_crtc *crtc)
3962306a36Sopenharmony_ci{
4062306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
4162306a36Sopenharmony_ci
4262306a36Sopenharmony_ci	/* stop the controller on cleanup */
4362306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_COMMAND, 0);
4462306a36Sopenharmony_ci	drm_crtc_cleanup(crtc);
4562306a36Sopenharmony_ci}
4662306a36Sopenharmony_ci
4762306a36Sopenharmony_cistatic int hdlcd_crtc_enable_vblank(struct drm_crtc *crtc)
4862306a36Sopenharmony_ci{
4962306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
5062306a36Sopenharmony_ci	unsigned int mask = hdlcd_read(hdlcd, HDLCD_REG_INT_MASK);
5162306a36Sopenharmony_ci
5262306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_INT_MASK, mask | HDLCD_INTERRUPT_VSYNC);
5362306a36Sopenharmony_ci
5462306a36Sopenharmony_ci	return 0;
5562306a36Sopenharmony_ci}
5662306a36Sopenharmony_ci
5762306a36Sopenharmony_cistatic void hdlcd_crtc_disable_vblank(struct drm_crtc *crtc)
5862306a36Sopenharmony_ci{
5962306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
6062306a36Sopenharmony_ci	unsigned int mask = hdlcd_read(hdlcd, HDLCD_REG_INT_MASK);
6162306a36Sopenharmony_ci
6262306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_INT_MASK, mask & ~HDLCD_INTERRUPT_VSYNC);
6362306a36Sopenharmony_ci}
6462306a36Sopenharmony_ci
6562306a36Sopenharmony_cistatic const struct drm_crtc_funcs hdlcd_crtc_funcs = {
6662306a36Sopenharmony_ci	.destroy = hdlcd_crtc_cleanup,
6762306a36Sopenharmony_ci	.set_config = drm_atomic_helper_set_config,
6862306a36Sopenharmony_ci	.page_flip = drm_atomic_helper_page_flip,
6962306a36Sopenharmony_ci	.reset = drm_atomic_helper_crtc_reset,
7062306a36Sopenharmony_ci	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
7162306a36Sopenharmony_ci	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
7262306a36Sopenharmony_ci	.enable_vblank = hdlcd_crtc_enable_vblank,
7362306a36Sopenharmony_ci	.disable_vblank = hdlcd_crtc_disable_vblank,
7462306a36Sopenharmony_ci};
7562306a36Sopenharmony_ci
7662306a36Sopenharmony_cistatic struct simplefb_format supported_formats[] = SIMPLEFB_FORMATS;
7762306a36Sopenharmony_ci
7862306a36Sopenharmony_ci/*
7962306a36Sopenharmony_ci * Setup the HDLCD registers for decoding the pixels out of the framebuffer
8062306a36Sopenharmony_ci */
8162306a36Sopenharmony_cistatic int hdlcd_set_pxl_fmt(struct drm_crtc *crtc)
8262306a36Sopenharmony_ci{
8362306a36Sopenharmony_ci	unsigned int btpp;
8462306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
8562306a36Sopenharmony_ci	const struct drm_framebuffer *fb = crtc->primary->state->fb;
8662306a36Sopenharmony_ci	uint32_t pixel_format;
8762306a36Sopenharmony_ci	struct simplefb_format *format = NULL;
8862306a36Sopenharmony_ci	int i;
8962306a36Sopenharmony_ci
9062306a36Sopenharmony_ci	pixel_format = fb->format->format;
9162306a36Sopenharmony_ci
9262306a36Sopenharmony_ci	for (i = 0; i < ARRAY_SIZE(supported_formats); i++) {
9362306a36Sopenharmony_ci		if (supported_formats[i].fourcc == pixel_format)
9462306a36Sopenharmony_ci			format = &supported_formats[i];
9562306a36Sopenharmony_ci	}
9662306a36Sopenharmony_ci
9762306a36Sopenharmony_ci	if (WARN_ON(!format))
9862306a36Sopenharmony_ci		return 0;
9962306a36Sopenharmony_ci
10062306a36Sopenharmony_ci	/* HDLCD uses 'bytes per pixel', zero means 1 byte */
10162306a36Sopenharmony_ci	btpp = (format->bits_per_pixel + 7) / 8;
10262306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_PIXEL_FORMAT, (btpp - 1) << 3);
10362306a36Sopenharmony_ci
10462306a36Sopenharmony_ci	/*
10562306a36Sopenharmony_ci	 * The format of the HDLCD_REG_<color>_SELECT register is:
10662306a36Sopenharmony_ci	 *   - bits[23:16] - default value for that color component
10762306a36Sopenharmony_ci	 *   - bits[11:8]  - number of bits to extract for each color component
10862306a36Sopenharmony_ci	 *   - bits[4:0]   - index of the lowest bit to extract
10962306a36Sopenharmony_ci	 *
11062306a36Sopenharmony_ci	 * The default color value is used when bits[11:8] are zero, when the
11162306a36Sopenharmony_ci	 * pixel is outside the visible frame area or when there is a
11262306a36Sopenharmony_ci	 * buffer underrun.
11362306a36Sopenharmony_ci	 */
11462306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_RED_SELECT, format->red.offset |
11562306a36Sopenharmony_ci#ifdef CONFIG_DRM_HDLCD_SHOW_UNDERRUN
11662306a36Sopenharmony_ci		    0x00ff0000 |	/* show underruns in red */
11762306a36Sopenharmony_ci#endif
11862306a36Sopenharmony_ci		    ((format->red.length & 0xf) << 8));
11962306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_GREEN_SELECT, format->green.offset |
12062306a36Sopenharmony_ci		    ((format->green.length & 0xf) << 8));
12162306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_BLUE_SELECT, format->blue.offset |
12262306a36Sopenharmony_ci		    ((format->blue.length & 0xf) << 8));
12362306a36Sopenharmony_ci
12462306a36Sopenharmony_ci	return 0;
12562306a36Sopenharmony_ci}
12662306a36Sopenharmony_ci
12762306a36Sopenharmony_cistatic void hdlcd_crtc_mode_set_nofb(struct drm_crtc *crtc)
12862306a36Sopenharmony_ci{
12962306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
13062306a36Sopenharmony_ci	struct drm_display_mode *m = &crtc->state->adjusted_mode;
13162306a36Sopenharmony_ci	struct videomode vm;
13262306a36Sopenharmony_ci	unsigned int polarities, err;
13362306a36Sopenharmony_ci
13462306a36Sopenharmony_ci	vm.vfront_porch = m->crtc_vsync_start - m->crtc_vdisplay;
13562306a36Sopenharmony_ci	vm.vback_porch = m->crtc_vtotal - m->crtc_vsync_end;
13662306a36Sopenharmony_ci	vm.vsync_len = m->crtc_vsync_end - m->crtc_vsync_start;
13762306a36Sopenharmony_ci	vm.hfront_porch = m->crtc_hsync_start - m->crtc_hdisplay;
13862306a36Sopenharmony_ci	vm.hback_porch = m->crtc_htotal - m->crtc_hsync_end;
13962306a36Sopenharmony_ci	vm.hsync_len = m->crtc_hsync_end - m->crtc_hsync_start;
14062306a36Sopenharmony_ci
14162306a36Sopenharmony_ci	polarities = HDLCD_POLARITY_DATAEN | HDLCD_POLARITY_DATA;
14262306a36Sopenharmony_ci
14362306a36Sopenharmony_ci	if (m->flags & DRM_MODE_FLAG_PHSYNC)
14462306a36Sopenharmony_ci		polarities |= HDLCD_POLARITY_HSYNC;
14562306a36Sopenharmony_ci	if (m->flags & DRM_MODE_FLAG_PVSYNC)
14662306a36Sopenharmony_ci		polarities |= HDLCD_POLARITY_VSYNC;
14762306a36Sopenharmony_ci
14862306a36Sopenharmony_ci	/* Allow max number of outstanding requests and largest burst size */
14962306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_BUS_OPTIONS,
15062306a36Sopenharmony_ci		    HDLCD_BUS_MAX_OUTSTAND | HDLCD_BUS_BURST_16);
15162306a36Sopenharmony_ci
15262306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_V_DATA, m->crtc_vdisplay - 1);
15362306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_V_BACK_PORCH, vm.vback_porch - 1);
15462306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_V_FRONT_PORCH, vm.vfront_porch - 1);
15562306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_V_SYNC, vm.vsync_len - 1);
15662306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_H_DATA, m->crtc_hdisplay - 1);
15762306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_H_BACK_PORCH, vm.hback_porch - 1);
15862306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_H_FRONT_PORCH, vm.hfront_porch - 1);
15962306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_H_SYNC, vm.hsync_len - 1);
16062306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_POLARITIES, polarities);
16162306a36Sopenharmony_ci
16262306a36Sopenharmony_ci	err = hdlcd_set_pxl_fmt(crtc);
16362306a36Sopenharmony_ci	if (err)
16462306a36Sopenharmony_ci		return;
16562306a36Sopenharmony_ci
16662306a36Sopenharmony_ci	clk_set_rate(hdlcd->clk, m->crtc_clock * 1000);
16762306a36Sopenharmony_ci}
16862306a36Sopenharmony_ci
16962306a36Sopenharmony_cistatic void hdlcd_crtc_atomic_enable(struct drm_crtc *crtc,
17062306a36Sopenharmony_ci				     struct drm_atomic_state *state)
17162306a36Sopenharmony_ci{
17262306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
17362306a36Sopenharmony_ci
17462306a36Sopenharmony_ci	clk_prepare_enable(hdlcd->clk);
17562306a36Sopenharmony_ci	hdlcd_crtc_mode_set_nofb(crtc);
17662306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_COMMAND, 1);
17762306a36Sopenharmony_ci	drm_crtc_vblank_on(crtc);
17862306a36Sopenharmony_ci}
17962306a36Sopenharmony_ci
18062306a36Sopenharmony_cistatic void hdlcd_crtc_atomic_disable(struct drm_crtc *crtc,
18162306a36Sopenharmony_ci				      struct drm_atomic_state *state)
18262306a36Sopenharmony_ci{
18362306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
18462306a36Sopenharmony_ci
18562306a36Sopenharmony_ci	drm_crtc_vblank_off(crtc);
18662306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_COMMAND, 0);
18762306a36Sopenharmony_ci	clk_disable_unprepare(hdlcd->clk);
18862306a36Sopenharmony_ci}
18962306a36Sopenharmony_ci
19062306a36Sopenharmony_cistatic enum drm_mode_status hdlcd_crtc_mode_valid(struct drm_crtc *crtc,
19162306a36Sopenharmony_ci		const struct drm_display_mode *mode)
19262306a36Sopenharmony_ci{
19362306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = crtc_to_hdlcd_priv(crtc);
19462306a36Sopenharmony_ci	long rate, clk_rate = mode->clock * 1000;
19562306a36Sopenharmony_ci
19662306a36Sopenharmony_ci	rate = clk_round_rate(hdlcd->clk, clk_rate);
19762306a36Sopenharmony_ci	/* 0.1% seems a close enough tolerance for the TDA19988 on Juno */
19862306a36Sopenharmony_ci	if (abs(rate - clk_rate) * 1000 > clk_rate) {
19962306a36Sopenharmony_ci		/* clock required by mode not supported by hardware */
20062306a36Sopenharmony_ci		return MODE_NOCLOCK;
20162306a36Sopenharmony_ci	}
20262306a36Sopenharmony_ci
20362306a36Sopenharmony_ci	return MODE_OK;
20462306a36Sopenharmony_ci}
20562306a36Sopenharmony_ci
20662306a36Sopenharmony_cistatic void hdlcd_crtc_atomic_begin(struct drm_crtc *crtc,
20762306a36Sopenharmony_ci				    struct drm_atomic_state *state)
20862306a36Sopenharmony_ci{
20962306a36Sopenharmony_ci	struct drm_pending_vblank_event *event = crtc->state->event;
21062306a36Sopenharmony_ci
21162306a36Sopenharmony_ci	if (event) {
21262306a36Sopenharmony_ci		crtc->state->event = NULL;
21362306a36Sopenharmony_ci
21462306a36Sopenharmony_ci		spin_lock_irq(&crtc->dev->event_lock);
21562306a36Sopenharmony_ci		if (drm_crtc_vblank_get(crtc) == 0)
21662306a36Sopenharmony_ci			drm_crtc_arm_vblank_event(crtc, event);
21762306a36Sopenharmony_ci		else
21862306a36Sopenharmony_ci			drm_crtc_send_vblank_event(crtc, event);
21962306a36Sopenharmony_ci		spin_unlock_irq(&crtc->dev->event_lock);
22062306a36Sopenharmony_ci	}
22162306a36Sopenharmony_ci}
22262306a36Sopenharmony_ci
22362306a36Sopenharmony_cistatic const struct drm_crtc_helper_funcs hdlcd_crtc_helper_funcs = {
22462306a36Sopenharmony_ci	.mode_valid	= hdlcd_crtc_mode_valid,
22562306a36Sopenharmony_ci	.atomic_begin	= hdlcd_crtc_atomic_begin,
22662306a36Sopenharmony_ci	.atomic_enable	= hdlcd_crtc_atomic_enable,
22762306a36Sopenharmony_ci	.atomic_disable	= hdlcd_crtc_atomic_disable,
22862306a36Sopenharmony_ci};
22962306a36Sopenharmony_ci
23062306a36Sopenharmony_cistatic int hdlcd_plane_atomic_check(struct drm_plane *plane,
23162306a36Sopenharmony_ci				    struct drm_atomic_state *state)
23262306a36Sopenharmony_ci{
23362306a36Sopenharmony_ci	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
23462306a36Sopenharmony_ci										 plane);
23562306a36Sopenharmony_ci	int i;
23662306a36Sopenharmony_ci	struct drm_crtc *crtc;
23762306a36Sopenharmony_ci	struct drm_crtc_state *crtc_state;
23862306a36Sopenharmony_ci	u32 src_h = new_plane_state->src_h >> 16;
23962306a36Sopenharmony_ci
24062306a36Sopenharmony_ci	/* only the HDLCD_REG_FB_LINE_COUNT register has a limit */
24162306a36Sopenharmony_ci	if (src_h >= HDLCD_MAX_YRES) {
24262306a36Sopenharmony_ci		DRM_DEBUG_KMS("Invalid source width: %d\n", src_h);
24362306a36Sopenharmony_ci		return -EINVAL;
24462306a36Sopenharmony_ci	}
24562306a36Sopenharmony_ci
24662306a36Sopenharmony_ci	for_each_new_crtc_in_state(state, crtc, crtc_state,
24762306a36Sopenharmony_ci				   i) {
24862306a36Sopenharmony_ci		/* we cannot disable the plane while the CRTC is active */
24962306a36Sopenharmony_ci		if (!new_plane_state->fb && crtc_state->active)
25062306a36Sopenharmony_ci			return -EINVAL;
25162306a36Sopenharmony_ci		return drm_atomic_helper_check_plane_state(new_plane_state,
25262306a36Sopenharmony_ci							   crtc_state,
25362306a36Sopenharmony_ci							   DRM_PLANE_NO_SCALING,
25462306a36Sopenharmony_ci							   DRM_PLANE_NO_SCALING,
25562306a36Sopenharmony_ci							   false, true);
25662306a36Sopenharmony_ci	}
25762306a36Sopenharmony_ci
25862306a36Sopenharmony_ci	return 0;
25962306a36Sopenharmony_ci}
26062306a36Sopenharmony_ci
26162306a36Sopenharmony_cistatic void hdlcd_plane_atomic_update(struct drm_plane *plane,
26262306a36Sopenharmony_ci				      struct drm_atomic_state *state)
26362306a36Sopenharmony_ci{
26462306a36Sopenharmony_ci	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
26562306a36Sopenharmony_ci										 plane);
26662306a36Sopenharmony_ci	struct drm_framebuffer *fb = new_plane_state->fb;
26762306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd;
26862306a36Sopenharmony_ci	u32 dest_h;
26962306a36Sopenharmony_ci	dma_addr_t scanout_start;
27062306a36Sopenharmony_ci
27162306a36Sopenharmony_ci	if (!fb)
27262306a36Sopenharmony_ci		return;
27362306a36Sopenharmony_ci
27462306a36Sopenharmony_ci	dest_h = drm_rect_height(&new_plane_state->dst);
27562306a36Sopenharmony_ci	scanout_start = drm_fb_dma_get_gem_addr(fb, new_plane_state, 0);
27662306a36Sopenharmony_ci
27762306a36Sopenharmony_ci	hdlcd = drm_to_hdlcd_priv(plane->dev);
27862306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_FB_LINE_LENGTH, fb->pitches[0]);
27962306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_FB_LINE_PITCH, fb->pitches[0]);
28062306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_FB_LINE_COUNT, dest_h - 1);
28162306a36Sopenharmony_ci	hdlcd_write(hdlcd, HDLCD_REG_FB_BASE, scanout_start);
28262306a36Sopenharmony_ci}
28362306a36Sopenharmony_ci
28462306a36Sopenharmony_cistatic const struct drm_plane_helper_funcs hdlcd_plane_helper_funcs = {
28562306a36Sopenharmony_ci	.atomic_check = hdlcd_plane_atomic_check,
28662306a36Sopenharmony_ci	.atomic_update = hdlcd_plane_atomic_update,
28762306a36Sopenharmony_ci};
28862306a36Sopenharmony_ci
28962306a36Sopenharmony_cistatic const struct drm_plane_funcs hdlcd_plane_funcs = {
29062306a36Sopenharmony_ci	.update_plane		= drm_atomic_helper_update_plane,
29162306a36Sopenharmony_ci	.disable_plane		= drm_atomic_helper_disable_plane,
29262306a36Sopenharmony_ci	.reset			= drm_atomic_helper_plane_reset,
29362306a36Sopenharmony_ci	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
29462306a36Sopenharmony_ci	.atomic_destroy_state	= drm_atomic_helper_plane_destroy_state,
29562306a36Sopenharmony_ci};
29662306a36Sopenharmony_ci
29762306a36Sopenharmony_cistatic struct drm_plane *hdlcd_plane_init(struct drm_device *drm)
29862306a36Sopenharmony_ci{
29962306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = drm_to_hdlcd_priv(drm);
30062306a36Sopenharmony_ci	struct drm_plane *plane = NULL;
30162306a36Sopenharmony_ci	u32 formats[ARRAY_SIZE(supported_formats)], i;
30262306a36Sopenharmony_ci
30362306a36Sopenharmony_ci	for (i = 0; i < ARRAY_SIZE(supported_formats); i++)
30462306a36Sopenharmony_ci		formats[i] = supported_formats[i].fourcc;
30562306a36Sopenharmony_ci
30662306a36Sopenharmony_ci	plane = drmm_universal_plane_alloc(drm, struct drm_plane, dev, 0xff,
30762306a36Sopenharmony_ci					   &hdlcd_plane_funcs,
30862306a36Sopenharmony_ci					   formats, ARRAY_SIZE(formats),
30962306a36Sopenharmony_ci					   NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
31062306a36Sopenharmony_ci	if (IS_ERR(plane))
31162306a36Sopenharmony_ci		return plane;
31262306a36Sopenharmony_ci
31362306a36Sopenharmony_ci	drm_plane_helper_add(plane, &hdlcd_plane_helper_funcs);
31462306a36Sopenharmony_ci	hdlcd->plane = plane;
31562306a36Sopenharmony_ci
31662306a36Sopenharmony_ci	return plane;
31762306a36Sopenharmony_ci}
31862306a36Sopenharmony_ci
31962306a36Sopenharmony_ciint hdlcd_setup_crtc(struct drm_device *drm)
32062306a36Sopenharmony_ci{
32162306a36Sopenharmony_ci	struct hdlcd_drm_private *hdlcd = drm_to_hdlcd_priv(drm);
32262306a36Sopenharmony_ci	struct drm_plane *primary;
32362306a36Sopenharmony_ci	int ret;
32462306a36Sopenharmony_ci
32562306a36Sopenharmony_ci	primary = hdlcd_plane_init(drm);
32662306a36Sopenharmony_ci	if (IS_ERR(primary))
32762306a36Sopenharmony_ci		return PTR_ERR(primary);
32862306a36Sopenharmony_ci
32962306a36Sopenharmony_ci	ret = drm_crtc_init_with_planes(drm, &hdlcd->crtc, primary, NULL,
33062306a36Sopenharmony_ci					&hdlcd_crtc_funcs, NULL);
33162306a36Sopenharmony_ci	if (ret)
33262306a36Sopenharmony_ci		return ret;
33362306a36Sopenharmony_ci
33462306a36Sopenharmony_ci	drm_crtc_helper_add(&hdlcd->crtc, &hdlcd_crtc_helper_funcs);
33562306a36Sopenharmony_ci	return 0;
33662306a36Sopenharmony_ci}
337