162306a36Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only 262306a36Sopenharmony_ci/* 362306a36Sopenharmony_ci * Copyright (C) 2012 ST Microelectronics 462306a36Sopenharmony_ci * Viresh Kumar <vireshk@kernel.org> 562306a36Sopenharmony_ci * 662306a36Sopenharmony_ci * VCO-PLL clock implementation 762306a36Sopenharmony_ci */ 862306a36Sopenharmony_ci 962306a36Sopenharmony_ci#define pr_fmt(fmt) "clk-vco-pll: " fmt 1062306a36Sopenharmony_ci 1162306a36Sopenharmony_ci#include <linux/clk-provider.h> 1262306a36Sopenharmony_ci#include <linux/slab.h> 1362306a36Sopenharmony_ci#include <linux/io.h> 1462306a36Sopenharmony_ci#include <linux/err.h> 1562306a36Sopenharmony_ci#include "clk.h" 1662306a36Sopenharmony_ci 1762306a36Sopenharmony_ci/* 1862306a36Sopenharmony_ci * DOC: VCO-PLL clock 1962306a36Sopenharmony_ci * 2062306a36Sopenharmony_ci * VCO and PLL rate are derived from following equations: 2162306a36Sopenharmony_ci * 2262306a36Sopenharmony_ci * In normal mode 2362306a36Sopenharmony_ci * vco = (2 * M[15:8] * Fin)/N 2462306a36Sopenharmony_ci * 2562306a36Sopenharmony_ci * In Dithered mode 2662306a36Sopenharmony_ci * vco = (2 * M[15:0] * Fin)/(256 * N) 2762306a36Sopenharmony_ci * 2862306a36Sopenharmony_ci * pll_rate = pll/2^p 2962306a36Sopenharmony_ci * 3062306a36Sopenharmony_ci * vco and pll are very closely bound to each other, "vco needs to program: 3162306a36Sopenharmony_ci * mode, m & n" and "pll needs to program p", both share common enable/disable 3262306a36Sopenharmony_ci * logic. 3362306a36Sopenharmony_ci * 3462306a36Sopenharmony_ci * clk_register_vco_pll() registers instances of both vco & pll. 3562306a36Sopenharmony_ci * CLK_SET_RATE_PARENT flag is forced for pll, as it will always pass its 3662306a36Sopenharmony_ci * set_rate to vco. A single rate table exists for both the clocks, which 3762306a36Sopenharmony_ci * configures m, n and p. 3862306a36Sopenharmony_ci */ 3962306a36Sopenharmony_ci 4062306a36Sopenharmony_ci/* PLL_CTR register masks */ 4162306a36Sopenharmony_ci#define PLL_MODE_NORMAL 0 4262306a36Sopenharmony_ci#define PLL_MODE_FRACTION 1 4362306a36Sopenharmony_ci#define PLL_MODE_DITH_DSM 2 4462306a36Sopenharmony_ci#define PLL_MODE_DITH_SSM 3 4562306a36Sopenharmony_ci#define PLL_MODE_MASK 3 4662306a36Sopenharmony_ci#define PLL_MODE_SHIFT 3 4762306a36Sopenharmony_ci#define PLL_ENABLE 2 4862306a36Sopenharmony_ci 4962306a36Sopenharmony_ci#define PLL_LOCK_SHIFT 0 5062306a36Sopenharmony_ci#define PLL_LOCK_MASK 1 5162306a36Sopenharmony_ci 5262306a36Sopenharmony_ci/* PLL FRQ register masks */ 5362306a36Sopenharmony_ci#define PLL_NORM_FDBK_M_MASK 0xFF 5462306a36Sopenharmony_ci#define PLL_NORM_FDBK_M_SHIFT 24 5562306a36Sopenharmony_ci#define PLL_DITH_FDBK_M_MASK 0xFFFF 5662306a36Sopenharmony_ci#define PLL_DITH_FDBK_M_SHIFT 16 5762306a36Sopenharmony_ci#define PLL_DIV_P_MASK 0x7 5862306a36Sopenharmony_ci#define PLL_DIV_P_SHIFT 8 5962306a36Sopenharmony_ci#define PLL_DIV_N_MASK 0xFF 6062306a36Sopenharmony_ci#define PLL_DIV_N_SHIFT 0 6162306a36Sopenharmony_ci 6262306a36Sopenharmony_ci#define to_clk_vco(_hw) container_of(_hw, struct clk_vco, hw) 6362306a36Sopenharmony_ci#define to_clk_pll(_hw) container_of(_hw, struct clk_pll, hw) 6462306a36Sopenharmony_ci 6562306a36Sopenharmony_ci/* Calculates pll clk rate for specific value of mode, m, n and p */ 6662306a36Sopenharmony_cistatic unsigned long pll_calc_rate(struct pll_rate_tbl *rtbl, 6762306a36Sopenharmony_ci unsigned long prate, int index, unsigned long *pll_rate) 6862306a36Sopenharmony_ci{ 6962306a36Sopenharmony_ci unsigned long rate = prate; 7062306a36Sopenharmony_ci unsigned int mode; 7162306a36Sopenharmony_ci 7262306a36Sopenharmony_ci mode = rtbl[index].mode ? 256 : 1; 7362306a36Sopenharmony_ci rate = (((2 * rate / 10000) * rtbl[index].m) / (mode * rtbl[index].n)); 7462306a36Sopenharmony_ci 7562306a36Sopenharmony_ci if (pll_rate) 7662306a36Sopenharmony_ci *pll_rate = (rate / (1 << rtbl[index].p)) * 10000; 7762306a36Sopenharmony_ci 7862306a36Sopenharmony_ci return rate * 10000; 7962306a36Sopenharmony_ci} 8062306a36Sopenharmony_ci 8162306a36Sopenharmony_cistatic long clk_pll_round_rate_index(struct clk_hw *hw, unsigned long drate, 8262306a36Sopenharmony_ci unsigned long *prate, int *index) 8362306a36Sopenharmony_ci{ 8462306a36Sopenharmony_ci struct clk_pll *pll = to_clk_pll(hw); 8562306a36Sopenharmony_ci unsigned long prev_rate, vco_prev_rate, rate = 0; 8662306a36Sopenharmony_ci unsigned long vco_parent_rate = 8762306a36Sopenharmony_ci clk_hw_get_rate(clk_hw_get_parent(clk_hw_get_parent(hw))); 8862306a36Sopenharmony_ci 8962306a36Sopenharmony_ci if (!prate) { 9062306a36Sopenharmony_ci pr_err("%s: prate is must for pll clk\n", __func__); 9162306a36Sopenharmony_ci return -EINVAL; 9262306a36Sopenharmony_ci } 9362306a36Sopenharmony_ci 9462306a36Sopenharmony_ci for (*index = 0; *index < pll->vco->rtbl_cnt; (*index)++) { 9562306a36Sopenharmony_ci prev_rate = rate; 9662306a36Sopenharmony_ci vco_prev_rate = *prate; 9762306a36Sopenharmony_ci *prate = pll_calc_rate(pll->vco->rtbl, vco_parent_rate, *index, 9862306a36Sopenharmony_ci &rate); 9962306a36Sopenharmony_ci if (drate < rate) { 10062306a36Sopenharmony_ci /* previous clock was best */ 10162306a36Sopenharmony_ci if (*index) { 10262306a36Sopenharmony_ci rate = prev_rate; 10362306a36Sopenharmony_ci *prate = vco_prev_rate; 10462306a36Sopenharmony_ci (*index)--; 10562306a36Sopenharmony_ci } 10662306a36Sopenharmony_ci break; 10762306a36Sopenharmony_ci } 10862306a36Sopenharmony_ci } 10962306a36Sopenharmony_ci 11062306a36Sopenharmony_ci return rate; 11162306a36Sopenharmony_ci} 11262306a36Sopenharmony_ci 11362306a36Sopenharmony_cistatic long clk_pll_round_rate(struct clk_hw *hw, unsigned long drate, 11462306a36Sopenharmony_ci unsigned long *prate) 11562306a36Sopenharmony_ci{ 11662306a36Sopenharmony_ci int unused; 11762306a36Sopenharmony_ci 11862306a36Sopenharmony_ci return clk_pll_round_rate_index(hw, drate, prate, &unused); 11962306a36Sopenharmony_ci} 12062306a36Sopenharmony_ci 12162306a36Sopenharmony_cistatic unsigned long clk_pll_recalc_rate(struct clk_hw *hw, unsigned long 12262306a36Sopenharmony_ci parent_rate) 12362306a36Sopenharmony_ci{ 12462306a36Sopenharmony_ci struct clk_pll *pll = to_clk_pll(hw); 12562306a36Sopenharmony_ci unsigned long flags = 0; 12662306a36Sopenharmony_ci unsigned int p; 12762306a36Sopenharmony_ci 12862306a36Sopenharmony_ci if (pll->vco->lock) 12962306a36Sopenharmony_ci spin_lock_irqsave(pll->vco->lock, flags); 13062306a36Sopenharmony_ci 13162306a36Sopenharmony_ci p = readl_relaxed(pll->vco->cfg_reg); 13262306a36Sopenharmony_ci 13362306a36Sopenharmony_ci if (pll->vco->lock) 13462306a36Sopenharmony_ci spin_unlock_irqrestore(pll->vco->lock, flags); 13562306a36Sopenharmony_ci 13662306a36Sopenharmony_ci p = (p >> PLL_DIV_P_SHIFT) & PLL_DIV_P_MASK; 13762306a36Sopenharmony_ci 13862306a36Sopenharmony_ci return parent_rate / (1 << p); 13962306a36Sopenharmony_ci} 14062306a36Sopenharmony_ci 14162306a36Sopenharmony_cistatic int clk_pll_set_rate(struct clk_hw *hw, unsigned long drate, 14262306a36Sopenharmony_ci unsigned long prate) 14362306a36Sopenharmony_ci{ 14462306a36Sopenharmony_ci struct clk_pll *pll = to_clk_pll(hw); 14562306a36Sopenharmony_ci struct pll_rate_tbl *rtbl = pll->vco->rtbl; 14662306a36Sopenharmony_ci unsigned long flags = 0, val; 14762306a36Sopenharmony_ci int i = 0; 14862306a36Sopenharmony_ci 14962306a36Sopenharmony_ci clk_pll_round_rate_index(hw, drate, NULL, &i); 15062306a36Sopenharmony_ci 15162306a36Sopenharmony_ci if (pll->vco->lock) 15262306a36Sopenharmony_ci spin_lock_irqsave(pll->vco->lock, flags); 15362306a36Sopenharmony_ci 15462306a36Sopenharmony_ci val = readl_relaxed(pll->vco->cfg_reg); 15562306a36Sopenharmony_ci val &= ~(PLL_DIV_P_MASK << PLL_DIV_P_SHIFT); 15662306a36Sopenharmony_ci val |= (rtbl[i].p & PLL_DIV_P_MASK) << PLL_DIV_P_SHIFT; 15762306a36Sopenharmony_ci writel_relaxed(val, pll->vco->cfg_reg); 15862306a36Sopenharmony_ci 15962306a36Sopenharmony_ci if (pll->vco->lock) 16062306a36Sopenharmony_ci spin_unlock_irqrestore(pll->vco->lock, flags); 16162306a36Sopenharmony_ci 16262306a36Sopenharmony_ci return 0; 16362306a36Sopenharmony_ci} 16462306a36Sopenharmony_ci 16562306a36Sopenharmony_cistatic const struct clk_ops clk_pll_ops = { 16662306a36Sopenharmony_ci .recalc_rate = clk_pll_recalc_rate, 16762306a36Sopenharmony_ci .round_rate = clk_pll_round_rate, 16862306a36Sopenharmony_ci .set_rate = clk_pll_set_rate, 16962306a36Sopenharmony_ci}; 17062306a36Sopenharmony_ci 17162306a36Sopenharmony_cistatic inline unsigned long vco_calc_rate(struct clk_hw *hw, 17262306a36Sopenharmony_ci unsigned long prate, int index) 17362306a36Sopenharmony_ci{ 17462306a36Sopenharmony_ci struct clk_vco *vco = to_clk_vco(hw); 17562306a36Sopenharmony_ci 17662306a36Sopenharmony_ci return pll_calc_rate(vco->rtbl, prate, index, NULL); 17762306a36Sopenharmony_ci} 17862306a36Sopenharmony_ci 17962306a36Sopenharmony_cistatic long clk_vco_round_rate(struct clk_hw *hw, unsigned long drate, 18062306a36Sopenharmony_ci unsigned long *prate) 18162306a36Sopenharmony_ci{ 18262306a36Sopenharmony_ci struct clk_vco *vco = to_clk_vco(hw); 18362306a36Sopenharmony_ci int unused; 18462306a36Sopenharmony_ci 18562306a36Sopenharmony_ci return clk_round_rate_index(hw, drate, *prate, vco_calc_rate, 18662306a36Sopenharmony_ci vco->rtbl_cnt, &unused); 18762306a36Sopenharmony_ci} 18862306a36Sopenharmony_ci 18962306a36Sopenharmony_cistatic unsigned long clk_vco_recalc_rate(struct clk_hw *hw, 19062306a36Sopenharmony_ci unsigned long parent_rate) 19162306a36Sopenharmony_ci{ 19262306a36Sopenharmony_ci struct clk_vco *vco = to_clk_vco(hw); 19362306a36Sopenharmony_ci unsigned long flags = 0; 19462306a36Sopenharmony_ci unsigned int num = 2, den = 0, val, mode = 0; 19562306a36Sopenharmony_ci 19662306a36Sopenharmony_ci if (vco->lock) 19762306a36Sopenharmony_ci spin_lock_irqsave(vco->lock, flags); 19862306a36Sopenharmony_ci 19962306a36Sopenharmony_ci mode = (readl_relaxed(vco->mode_reg) >> PLL_MODE_SHIFT) & PLL_MODE_MASK; 20062306a36Sopenharmony_ci 20162306a36Sopenharmony_ci val = readl_relaxed(vco->cfg_reg); 20262306a36Sopenharmony_ci 20362306a36Sopenharmony_ci if (vco->lock) 20462306a36Sopenharmony_ci spin_unlock_irqrestore(vco->lock, flags); 20562306a36Sopenharmony_ci 20662306a36Sopenharmony_ci den = (val >> PLL_DIV_N_SHIFT) & PLL_DIV_N_MASK; 20762306a36Sopenharmony_ci 20862306a36Sopenharmony_ci /* calculate numerator & denominator */ 20962306a36Sopenharmony_ci if (!mode) { 21062306a36Sopenharmony_ci /* Normal mode */ 21162306a36Sopenharmony_ci num *= (val >> PLL_NORM_FDBK_M_SHIFT) & PLL_NORM_FDBK_M_MASK; 21262306a36Sopenharmony_ci } else { 21362306a36Sopenharmony_ci /* Dithered mode */ 21462306a36Sopenharmony_ci num *= (val >> PLL_DITH_FDBK_M_SHIFT) & PLL_DITH_FDBK_M_MASK; 21562306a36Sopenharmony_ci den *= 256; 21662306a36Sopenharmony_ci } 21762306a36Sopenharmony_ci 21862306a36Sopenharmony_ci if (!den) { 21962306a36Sopenharmony_ci WARN(1, "%s: denominator can't be zero\n", __func__); 22062306a36Sopenharmony_ci return 0; 22162306a36Sopenharmony_ci } 22262306a36Sopenharmony_ci 22362306a36Sopenharmony_ci return (((parent_rate / 10000) * num) / den) * 10000; 22462306a36Sopenharmony_ci} 22562306a36Sopenharmony_ci 22662306a36Sopenharmony_ci/* Configures new clock rate of vco */ 22762306a36Sopenharmony_cistatic int clk_vco_set_rate(struct clk_hw *hw, unsigned long drate, 22862306a36Sopenharmony_ci unsigned long prate) 22962306a36Sopenharmony_ci{ 23062306a36Sopenharmony_ci struct clk_vco *vco = to_clk_vco(hw); 23162306a36Sopenharmony_ci struct pll_rate_tbl *rtbl = vco->rtbl; 23262306a36Sopenharmony_ci unsigned long flags = 0, val; 23362306a36Sopenharmony_ci int i; 23462306a36Sopenharmony_ci 23562306a36Sopenharmony_ci clk_round_rate_index(hw, drate, prate, vco_calc_rate, vco->rtbl_cnt, 23662306a36Sopenharmony_ci &i); 23762306a36Sopenharmony_ci 23862306a36Sopenharmony_ci if (vco->lock) 23962306a36Sopenharmony_ci spin_lock_irqsave(vco->lock, flags); 24062306a36Sopenharmony_ci 24162306a36Sopenharmony_ci val = readl_relaxed(vco->mode_reg); 24262306a36Sopenharmony_ci val &= ~(PLL_MODE_MASK << PLL_MODE_SHIFT); 24362306a36Sopenharmony_ci val |= (rtbl[i].mode & PLL_MODE_MASK) << PLL_MODE_SHIFT; 24462306a36Sopenharmony_ci writel_relaxed(val, vco->mode_reg); 24562306a36Sopenharmony_ci 24662306a36Sopenharmony_ci val = readl_relaxed(vco->cfg_reg); 24762306a36Sopenharmony_ci val &= ~(PLL_DIV_N_MASK << PLL_DIV_N_SHIFT); 24862306a36Sopenharmony_ci val |= (rtbl[i].n & PLL_DIV_N_MASK) << PLL_DIV_N_SHIFT; 24962306a36Sopenharmony_ci 25062306a36Sopenharmony_ci val &= ~(PLL_DITH_FDBK_M_MASK << PLL_DITH_FDBK_M_SHIFT); 25162306a36Sopenharmony_ci if (rtbl[i].mode) 25262306a36Sopenharmony_ci val |= (rtbl[i].m & PLL_DITH_FDBK_M_MASK) << 25362306a36Sopenharmony_ci PLL_DITH_FDBK_M_SHIFT; 25462306a36Sopenharmony_ci else 25562306a36Sopenharmony_ci val |= (rtbl[i].m & PLL_NORM_FDBK_M_MASK) << 25662306a36Sopenharmony_ci PLL_NORM_FDBK_M_SHIFT; 25762306a36Sopenharmony_ci 25862306a36Sopenharmony_ci writel_relaxed(val, vco->cfg_reg); 25962306a36Sopenharmony_ci 26062306a36Sopenharmony_ci if (vco->lock) 26162306a36Sopenharmony_ci spin_unlock_irqrestore(vco->lock, flags); 26262306a36Sopenharmony_ci 26362306a36Sopenharmony_ci return 0; 26462306a36Sopenharmony_ci} 26562306a36Sopenharmony_ci 26662306a36Sopenharmony_cistatic const struct clk_ops clk_vco_ops = { 26762306a36Sopenharmony_ci .recalc_rate = clk_vco_recalc_rate, 26862306a36Sopenharmony_ci .round_rate = clk_vco_round_rate, 26962306a36Sopenharmony_ci .set_rate = clk_vco_set_rate, 27062306a36Sopenharmony_ci}; 27162306a36Sopenharmony_ci 27262306a36Sopenharmony_cistruct clk *clk_register_vco_pll(const char *vco_name, const char *pll_name, 27362306a36Sopenharmony_ci const char *vco_gate_name, const char *parent_name, 27462306a36Sopenharmony_ci unsigned long flags, void __iomem *mode_reg, void __iomem 27562306a36Sopenharmony_ci *cfg_reg, struct pll_rate_tbl *rtbl, u8 rtbl_cnt, 27662306a36Sopenharmony_ci spinlock_t *lock, struct clk **pll_clk, 27762306a36Sopenharmony_ci struct clk **vco_gate_clk) 27862306a36Sopenharmony_ci{ 27962306a36Sopenharmony_ci struct clk_vco *vco; 28062306a36Sopenharmony_ci struct clk_pll *pll; 28162306a36Sopenharmony_ci struct clk *vco_clk, *tpll_clk, *tvco_gate_clk; 28262306a36Sopenharmony_ci struct clk_init_data vco_init, pll_init; 28362306a36Sopenharmony_ci const char **vco_parent_name; 28462306a36Sopenharmony_ci 28562306a36Sopenharmony_ci if (!vco_name || !pll_name || !parent_name || !mode_reg || !cfg_reg || 28662306a36Sopenharmony_ci !rtbl || !rtbl_cnt) { 28762306a36Sopenharmony_ci pr_err("Invalid arguments passed"); 28862306a36Sopenharmony_ci return ERR_PTR(-EINVAL); 28962306a36Sopenharmony_ci } 29062306a36Sopenharmony_ci 29162306a36Sopenharmony_ci vco = kzalloc(sizeof(*vco), GFP_KERNEL); 29262306a36Sopenharmony_ci if (!vco) 29362306a36Sopenharmony_ci return ERR_PTR(-ENOMEM); 29462306a36Sopenharmony_ci 29562306a36Sopenharmony_ci pll = kzalloc(sizeof(*pll), GFP_KERNEL); 29662306a36Sopenharmony_ci if (!pll) 29762306a36Sopenharmony_ci goto free_vco; 29862306a36Sopenharmony_ci 29962306a36Sopenharmony_ci /* struct clk_vco assignments */ 30062306a36Sopenharmony_ci vco->mode_reg = mode_reg; 30162306a36Sopenharmony_ci vco->cfg_reg = cfg_reg; 30262306a36Sopenharmony_ci vco->rtbl = rtbl; 30362306a36Sopenharmony_ci vco->rtbl_cnt = rtbl_cnt; 30462306a36Sopenharmony_ci vco->lock = lock; 30562306a36Sopenharmony_ci vco->hw.init = &vco_init; 30662306a36Sopenharmony_ci 30762306a36Sopenharmony_ci pll->vco = vco; 30862306a36Sopenharmony_ci pll->hw.init = &pll_init; 30962306a36Sopenharmony_ci 31062306a36Sopenharmony_ci if (vco_gate_name) { 31162306a36Sopenharmony_ci tvco_gate_clk = clk_register_gate(NULL, vco_gate_name, 31262306a36Sopenharmony_ci parent_name, 0, mode_reg, PLL_ENABLE, 0, lock); 31362306a36Sopenharmony_ci if (IS_ERR_OR_NULL(tvco_gate_clk)) 31462306a36Sopenharmony_ci goto free_pll; 31562306a36Sopenharmony_ci 31662306a36Sopenharmony_ci if (vco_gate_clk) 31762306a36Sopenharmony_ci *vco_gate_clk = tvco_gate_clk; 31862306a36Sopenharmony_ci vco_parent_name = &vco_gate_name; 31962306a36Sopenharmony_ci } else { 32062306a36Sopenharmony_ci vco_parent_name = &parent_name; 32162306a36Sopenharmony_ci } 32262306a36Sopenharmony_ci 32362306a36Sopenharmony_ci vco_init.name = vco_name; 32462306a36Sopenharmony_ci vco_init.ops = &clk_vco_ops; 32562306a36Sopenharmony_ci vco_init.flags = flags; 32662306a36Sopenharmony_ci vco_init.parent_names = vco_parent_name; 32762306a36Sopenharmony_ci vco_init.num_parents = 1; 32862306a36Sopenharmony_ci 32962306a36Sopenharmony_ci pll_init.name = pll_name; 33062306a36Sopenharmony_ci pll_init.ops = &clk_pll_ops; 33162306a36Sopenharmony_ci pll_init.flags = CLK_SET_RATE_PARENT; 33262306a36Sopenharmony_ci pll_init.parent_names = &vco_name; 33362306a36Sopenharmony_ci pll_init.num_parents = 1; 33462306a36Sopenharmony_ci 33562306a36Sopenharmony_ci vco_clk = clk_register(NULL, &vco->hw); 33662306a36Sopenharmony_ci if (IS_ERR_OR_NULL(vco_clk)) 33762306a36Sopenharmony_ci goto free_pll; 33862306a36Sopenharmony_ci 33962306a36Sopenharmony_ci tpll_clk = clk_register(NULL, &pll->hw); 34062306a36Sopenharmony_ci if (IS_ERR_OR_NULL(tpll_clk)) 34162306a36Sopenharmony_ci goto free_pll; 34262306a36Sopenharmony_ci 34362306a36Sopenharmony_ci if (pll_clk) 34462306a36Sopenharmony_ci *pll_clk = tpll_clk; 34562306a36Sopenharmony_ci 34662306a36Sopenharmony_ci return vco_clk; 34762306a36Sopenharmony_ci 34862306a36Sopenharmony_cifree_pll: 34962306a36Sopenharmony_ci kfree(pll); 35062306a36Sopenharmony_cifree_vco: 35162306a36Sopenharmony_ci kfree(vco); 35262306a36Sopenharmony_ci 35362306a36Sopenharmony_ci pr_err("Failed to register vco pll clock\n"); 35462306a36Sopenharmony_ci 35562306a36Sopenharmony_ci return ERR_PTR(-ENOMEM); 35662306a36Sopenharmony_ci} 357