18c2ecf20Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-or-later
28c2ecf20Sopenharmony_ci/* Filesystem parameter parser.
38c2ecf20Sopenharmony_ci *
48c2ecf20Sopenharmony_ci * Copyright (C) 2018 Red Hat, Inc. All Rights Reserved.
58c2ecf20Sopenharmony_ci * Written by David Howells (dhowells@redhat.com)
68c2ecf20Sopenharmony_ci */
78c2ecf20Sopenharmony_ci
88c2ecf20Sopenharmony_ci#include <linux/export.h>
98c2ecf20Sopenharmony_ci#include <linux/fs_context.h>
108c2ecf20Sopenharmony_ci#include <linux/fs_parser.h>
118c2ecf20Sopenharmony_ci#include <linux/slab.h>
128c2ecf20Sopenharmony_ci#include <linux/security.h>
138c2ecf20Sopenharmony_ci#include <linux/namei.h>
148c2ecf20Sopenharmony_ci#include "internal.h"
158c2ecf20Sopenharmony_ci
168c2ecf20Sopenharmony_cistatic const struct constant_table bool_names[] = {
178c2ecf20Sopenharmony_ci	{ "0",		false },
188c2ecf20Sopenharmony_ci	{ "1",		true },
198c2ecf20Sopenharmony_ci	{ "false",	false },
208c2ecf20Sopenharmony_ci	{ "no",		false },
218c2ecf20Sopenharmony_ci	{ "true",	true },
228c2ecf20Sopenharmony_ci	{ "yes",	true },
238c2ecf20Sopenharmony_ci	{ },
248c2ecf20Sopenharmony_ci};
258c2ecf20Sopenharmony_ci
268c2ecf20Sopenharmony_cistatic const struct constant_table *
278c2ecf20Sopenharmony_ci__lookup_constant(const struct constant_table *tbl, const char *name)
288c2ecf20Sopenharmony_ci{
298c2ecf20Sopenharmony_ci	for ( ; tbl->name; tbl++)
308c2ecf20Sopenharmony_ci		if (strcmp(name, tbl->name) == 0)
318c2ecf20Sopenharmony_ci			return tbl;
328c2ecf20Sopenharmony_ci	return NULL;
338c2ecf20Sopenharmony_ci}
348c2ecf20Sopenharmony_ci
358c2ecf20Sopenharmony_ci/**
368c2ecf20Sopenharmony_ci * lookup_constant - Look up a constant by name in an ordered table
378c2ecf20Sopenharmony_ci * @tbl: The table of constants to search.
388c2ecf20Sopenharmony_ci * @name: The name to look up.
398c2ecf20Sopenharmony_ci * @not_found: The value to return if the name is not found.
408c2ecf20Sopenharmony_ci */
418c2ecf20Sopenharmony_ciint lookup_constant(const struct constant_table *tbl, const char *name, int not_found)
428c2ecf20Sopenharmony_ci{
438c2ecf20Sopenharmony_ci	const struct constant_table *p = __lookup_constant(tbl, name);
448c2ecf20Sopenharmony_ci
458c2ecf20Sopenharmony_ci	return p ? p->value : not_found;
468c2ecf20Sopenharmony_ci}
478c2ecf20Sopenharmony_ciEXPORT_SYMBOL(lookup_constant);
488c2ecf20Sopenharmony_ci
498c2ecf20Sopenharmony_cistatic inline bool is_flag(const struct fs_parameter_spec *p)
508c2ecf20Sopenharmony_ci{
518c2ecf20Sopenharmony_ci	return p->type == NULL;
528c2ecf20Sopenharmony_ci}
538c2ecf20Sopenharmony_ci
548c2ecf20Sopenharmony_cistatic const struct fs_parameter_spec *fs_lookup_key(
558c2ecf20Sopenharmony_ci	const struct fs_parameter_spec *desc,
568c2ecf20Sopenharmony_ci	struct fs_parameter *param, bool *negated)
578c2ecf20Sopenharmony_ci{
588c2ecf20Sopenharmony_ci	const struct fs_parameter_spec *p, *other = NULL;
598c2ecf20Sopenharmony_ci	const char *name = param->key;
608c2ecf20Sopenharmony_ci	bool want_flag = param->type == fs_value_is_flag;
618c2ecf20Sopenharmony_ci
628c2ecf20Sopenharmony_ci	*negated = false;
638c2ecf20Sopenharmony_ci	for (p = desc; p->name; p++) {
648c2ecf20Sopenharmony_ci		if (strcmp(p->name, name) != 0)
658c2ecf20Sopenharmony_ci			continue;
668c2ecf20Sopenharmony_ci		if (likely(is_flag(p) == want_flag))
678c2ecf20Sopenharmony_ci			return p;
688c2ecf20Sopenharmony_ci		other = p;
698c2ecf20Sopenharmony_ci	}
708c2ecf20Sopenharmony_ci	if (want_flag) {
718c2ecf20Sopenharmony_ci		if (name[0] == 'n' && name[1] == 'o' && name[2]) {
728c2ecf20Sopenharmony_ci			for (p = desc; p->name; p++) {
738c2ecf20Sopenharmony_ci				if (strcmp(p->name, name + 2) != 0)
748c2ecf20Sopenharmony_ci					continue;
758c2ecf20Sopenharmony_ci				if (!(p->flags & fs_param_neg_with_no))
768c2ecf20Sopenharmony_ci					continue;
778c2ecf20Sopenharmony_ci				*negated = true;
788c2ecf20Sopenharmony_ci				return p;
798c2ecf20Sopenharmony_ci			}
808c2ecf20Sopenharmony_ci		}
818c2ecf20Sopenharmony_ci	}
828c2ecf20Sopenharmony_ci	return other;
838c2ecf20Sopenharmony_ci}
848c2ecf20Sopenharmony_ci
858c2ecf20Sopenharmony_ci/*
868c2ecf20Sopenharmony_ci * fs_parse - Parse a filesystem configuration parameter
878c2ecf20Sopenharmony_ci * @fc: The filesystem context to log errors through.
888c2ecf20Sopenharmony_ci * @desc: The parameter description to use.
898c2ecf20Sopenharmony_ci * @param: The parameter.
908c2ecf20Sopenharmony_ci * @result: Where to place the result of the parse
918c2ecf20Sopenharmony_ci *
928c2ecf20Sopenharmony_ci * Parse a filesystem configuration parameter and attempt a conversion for a
938c2ecf20Sopenharmony_ci * simple parameter for which this is requested.  If successful, the determined
948c2ecf20Sopenharmony_ci * parameter ID is placed into @result->key, the desired type is indicated in
958c2ecf20Sopenharmony_ci * @result->t and any converted value is placed into an appropriate member of
968c2ecf20Sopenharmony_ci * the union in @result.
978c2ecf20Sopenharmony_ci *
988c2ecf20Sopenharmony_ci * The function returns the parameter number if the parameter was matched,
998c2ecf20Sopenharmony_ci * -ENOPARAM if it wasn't matched and @desc->ignore_unknown indicated that
1008c2ecf20Sopenharmony_ci * unknown parameters are okay and -EINVAL if there was a conversion issue or
1018c2ecf20Sopenharmony_ci * the parameter wasn't recognised and unknowns aren't okay.
1028c2ecf20Sopenharmony_ci */
1038c2ecf20Sopenharmony_ciint __fs_parse(struct p_log *log,
1048c2ecf20Sopenharmony_ci	     const struct fs_parameter_spec *desc,
1058c2ecf20Sopenharmony_ci	     struct fs_parameter *param,
1068c2ecf20Sopenharmony_ci	     struct fs_parse_result *result)
1078c2ecf20Sopenharmony_ci{
1088c2ecf20Sopenharmony_ci	const struct fs_parameter_spec *p;
1098c2ecf20Sopenharmony_ci
1108c2ecf20Sopenharmony_ci	result->uint_64 = 0;
1118c2ecf20Sopenharmony_ci
1128c2ecf20Sopenharmony_ci	p = fs_lookup_key(desc, param, &result->negated);
1138c2ecf20Sopenharmony_ci	if (!p)
1148c2ecf20Sopenharmony_ci		return -ENOPARAM;
1158c2ecf20Sopenharmony_ci
1168c2ecf20Sopenharmony_ci	if (p->flags & fs_param_deprecated)
1178c2ecf20Sopenharmony_ci		warn_plog(log, "Deprecated parameter '%s'", param->key);
1188c2ecf20Sopenharmony_ci
1198c2ecf20Sopenharmony_ci	/* Try to turn the type we were given into the type desired by the
1208c2ecf20Sopenharmony_ci	 * parameter and give an error if we can't.
1218c2ecf20Sopenharmony_ci	 */
1228c2ecf20Sopenharmony_ci	if (is_flag(p)) {
1238c2ecf20Sopenharmony_ci		if (param->type != fs_value_is_flag)
1248c2ecf20Sopenharmony_ci			return inval_plog(log, "Unexpected value for '%s'",
1258c2ecf20Sopenharmony_ci				      param->key);
1268c2ecf20Sopenharmony_ci		result->boolean = !result->negated;
1278c2ecf20Sopenharmony_ci	} else  {
1288c2ecf20Sopenharmony_ci		int ret = p->type(log, p, param, result);
1298c2ecf20Sopenharmony_ci		if (ret)
1308c2ecf20Sopenharmony_ci			return ret;
1318c2ecf20Sopenharmony_ci	}
1328c2ecf20Sopenharmony_ci	return p->opt;
1338c2ecf20Sopenharmony_ci}
1348c2ecf20Sopenharmony_ciEXPORT_SYMBOL(__fs_parse);
1358c2ecf20Sopenharmony_ci
1368c2ecf20Sopenharmony_ci/**
1378c2ecf20Sopenharmony_ci * fs_lookup_param - Look up a path referred to by a parameter
1388c2ecf20Sopenharmony_ci * @fc: The filesystem context to log errors through.
1398c2ecf20Sopenharmony_ci * @param: The parameter.
1408c2ecf20Sopenharmony_ci * @want_bdev: T if want a blockdev
1418c2ecf20Sopenharmony_ci * @_path: The result of the lookup
1428c2ecf20Sopenharmony_ci */
1438c2ecf20Sopenharmony_ciint fs_lookup_param(struct fs_context *fc,
1448c2ecf20Sopenharmony_ci		    struct fs_parameter *param,
1458c2ecf20Sopenharmony_ci		    bool want_bdev,
1468c2ecf20Sopenharmony_ci		    struct path *_path)
1478c2ecf20Sopenharmony_ci{
1488c2ecf20Sopenharmony_ci	struct filename *f;
1498c2ecf20Sopenharmony_ci	unsigned int flags = 0;
1508c2ecf20Sopenharmony_ci	bool put_f;
1518c2ecf20Sopenharmony_ci	int ret;
1528c2ecf20Sopenharmony_ci
1538c2ecf20Sopenharmony_ci	switch (param->type) {
1548c2ecf20Sopenharmony_ci	case fs_value_is_string:
1558c2ecf20Sopenharmony_ci		f = getname_kernel(param->string);
1568c2ecf20Sopenharmony_ci		if (IS_ERR(f))
1578c2ecf20Sopenharmony_ci			return PTR_ERR(f);
1588c2ecf20Sopenharmony_ci		put_f = true;
1598c2ecf20Sopenharmony_ci		break;
1608c2ecf20Sopenharmony_ci	case fs_value_is_filename:
1618c2ecf20Sopenharmony_ci		f = param->name;
1628c2ecf20Sopenharmony_ci		put_f = false;
1638c2ecf20Sopenharmony_ci		break;
1648c2ecf20Sopenharmony_ci	default:
1658c2ecf20Sopenharmony_ci		return invalf(fc, "%s: not usable as path", param->key);
1668c2ecf20Sopenharmony_ci	}
1678c2ecf20Sopenharmony_ci
1688c2ecf20Sopenharmony_ci	f->refcnt++; /* filename_lookup() drops our ref. */
1698c2ecf20Sopenharmony_ci	ret = filename_lookup(param->dirfd, f, flags, _path, NULL);
1708c2ecf20Sopenharmony_ci	if (ret < 0) {
1718c2ecf20Sopenharmony_ci		errorf(fc, "%s: Lookup failure for '%s'", param->key, f->name);
1728c2ecf20Sopenharmony_ci		goto out;
1738c2ecf20Sopenharmony_ci	}
1748c2ecf20Sopenharmony_ci
1758c2ecf20Sopenharmony_ci	if (want_bdev &&
1768c2ecf20Sopenharmony_ci	    !S_ISBLK(d_backing_inode(_path->dentry)->i_mode)) {
1778c2ecf20Sopenharmony_ci		path_put(_path);
1788c2ecf20Sopenharmony_ci		_path->dentry = NULL;
1798c2ecf20Sopenharmony_ci		_path->mnt = NULL;
1808c2ecf20Sopenharmony_ci		errorf(fc, "%s: Non-blockdev passed as '%s'",
1818c2ecf20Sopenharmony_ci		       param->key, f->name);
1828c2ecf20Sopenharmony_ci		ret = -ENOTBLK;
1838c2ecf20Sopenharmony_ci	}
1848c2ecf20Sopenharmony_ci
1858c2ecf20Sopenharmony_ciout:
1868c2ecf20Sopenharmony_ci	if (put_f)
1878c2ecf20Sopenharmony_ci		putname(f);
1888c2ecf20Sopenharmony_ci	return ret;
1898c2ecf20Sopenharmony_ci}
1908c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_lookup_param);
1918c2ecf20Sopenharmony_ci
1928c2ecf20Sopenharmony_cistatic int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
1938c2ecf20Sopenharmony_ci{
1948c2ecf20Sopenharmony_ci	return inval_plog(log, "Bad value for '%s'", param->key);
1958c2ecf20Sopenharmony_ci}
1968c2ecf20Sopenharmony_ci
1978c2ecf20Sopenharmony_ciint fs_param_is_bool(struct p_log *log, const struct fs_parameter_spec *p,
1988c2ecf20Sopenharmony_ci		     struct fs_parameter *param, struct fs_parse_result *result)
1998c2ecf20Sopenharmony_ci{
2008c2ecf20Sopenharmony_ci	int b;
2018c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string)
2028c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2038c2ecf20Sopenharmony_ci	b = lookup_constant(bool_names, param->string, -1);
2048c2ecf20Sopenharmony_ci	if (b == -1)
2058c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2068c2ecf20Sopenharmony_ci	result->boolean = b;
2078c2ecf20Sopenharmony_ci	return 0;
2088c2ecf20Sopenharmony_ci}
2098c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_bool);
2108c2ecf20Sopenharmony_ci
2118c2ecf20Sopenharmony_ciint fs_param_is_u32(struct p_log *log, const struct fs_parameter_spec *p,
2128c2ecf20Sopenharmony_ci		    struct fs_parameter *param, struct fs_parse_result *result)
2138c2ecf20Sopenharmony_ci{
2148c2ecf20Sopenharmony_ci	int base = (unsigned long)p->data;
2158c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string ||
2168c2ecf20Sopenharmony_ci	    kstrtouint(param->string, base, &result->uint_32) < 0)
2178c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2188c2ecf20Sopenharmony_ci	return 0;
2198c2ecf20Sopenharmony_ci}
2208c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_u32);
2218c2ecf20Sopenharmony_ci
2228c2ecf20Sopenharmony_ciint fs_param_is_s32(struct p_log *log, const struct fs_parameter_spec *p,
2238c2ecf20Sopenharmony_ci		    struct fs_parameter *param, struct fs_parse_result *result)
2248c2ecf20Sopenharmony_ci{
2258c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string ||
2268c2ecf20Sopenharmony_ci	    kstrtoint(param->string, 0, &result->int_32) < 0)
2278c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2288c2ecf20Sopenharmony_ci	return 0;
2298c2ecf20Sopenharmony_ci}
2308c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_s32);
2318c2ecf20Sopenharmony_ci
2328c2ecf20Sopenharmony_ciint fs_param_is_u64(struct p_log *log, const struct fs_parameter_spec *p,
2338c2ecf20Sopenharmony_ci		    struct fs_parameter *param, struct fs_parse_result *result)
2348c2ecf20Sopenharmony_ci{
2358c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string ||
2368c2ecf20Sopenharmony_ci	    kstrtoull(param->string, 0, &result->uint_64) < 0)
2378c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2388c2ecf20Sopenharmony_ci	return 0;
2398c2ecf20Sopenharmony_ci}
2408c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_u64);
2418c2ecf20Sopenharmony_ci
2428c2ecf20Sopenharmony_ciint fs_param_is_enum(struct p_log *log, const struct fs_parameter_spec *p,
2438c2ecf20Sopenharmony_ci		     struct fs_parameter *param, struct fs_parse_result *result)
2448c2ecf20Sopenharmony_ci{
2458c2ecf20Sopenharmony_ci	const struct constant_table *c;
2468c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string)
2478c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2488c2ecf20Sopenharmony_ci	c = __lookup_constant(p->data, param->string);
2498c2ecf20Sopenharmony_ci	if (!c)
2508c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2518c2ecf20Sopenharmony_ci	result->uint_32 = c->value;
2528c2ecf20Sopenharmony_ci	return 0;
2538c2ecf20Sopenharmony_ci}
2548c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_enum);
2558c2ecf20Sopenharmony_ci
2568c2ecf20Sopenharmony_ciint fs_param_is_string(struct p_log *log, const struct fs_parameter_spec *p,
2578c2ecf20Sopenharmony_ci		       struct fs_parameter *param, struct fs_parse_result *result)
2588c2ecf20Sopenharmony_ci{
2598c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_string || !*param->string)
2608c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2618c2ecf20Sopenharmony_ci	return 0;
2628c2ecf20Sopenharmony_ci}
2638c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_string);
2648c2ecf20Sopenharmony_ci
2658c2ecf20Sopenharmony_ciint fs_param_is_blob(struct p_log *log, const struct fs_parameter_spec *p,
2668c2ecf20Sopenharmony_ci		     struct fs_parameter *param, struct fs_parse_result *result)
2678c2ecf20Sopenharmony_ci{
2688c2ecf20Sopenharmony_ci	if (param->type != fs_value_is_blob)
2698c2ecf20Sopenharmony_ci		return fs_param_bad_value(log, param);
2708c2ecf20Sopenharmony_ci	return 0;
2718c2ecf20Sopenharmony_ci}
2728c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_blob);
2738c2ecf20Sopenharmony_ci
2748c2ecf20Sopenharmony_ciint fs_param_is_fd(struct p_log *log, const struct fs_parameter_spec *p,
2758c2ecf20Sopenharmony_ci		  struct fs_parameter *param, struct fs_parse_result *result)
2768c2ecf20Sopenharmony_ci{
2778c2ecf20Sopenharmony_ci	switch (param->type) {
2788c2ecf20Sopenharmony_ci	case fs_value_is_string:
2798c2ecf20Sopenharmony_ci		if (kstrtouint(param->string, 0, &result->uint_32) < 0)
2808c2ecf20Sopenharmony_ci			break;
2818c2ecf20Sopenharmony_ci		if (result->uint_32 <= INT_MAX)
2828c2ecf20Sopenharmony_ci			return 0;
2838c2ecf20Sopenharmony_ci		break;
2848c2ecf20Sopenharmony_ci	case fs_value_is_file:
2858c2ecf20Sopenharmony_ci		result->uint_32 = param->dirfd;
2868c2ecf20Sopenharmony_ci		if (result->uint_32 <= INT_MAX)
2878c2ecf20Sopenharmony_ci			return 0;
2888c2ecf20Sopenharmony_ci		break;
2898c2ecf20Sopenharmony_ci	default:
2908c2ecf20Sopenharmony_ci		break;
2918c2ecf20Sopenharmony_ci	}
2928c2ecf20Sopenharmony_ci	return fs_param_bad_value(log, param);
2938c2ecf20Sopenharmony_ci}
2948c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_fd);
2958c2ecf20Sopenharmony_ci
2968c2ecf20Sopenharmony_ciint fs_param_is_blockdev(struct p_log *log, const struct fs_parameter_spec *p,
2978c2ecf20Sopenharmony_ci		  struct fs_parameter *param, struct fs_parse_result *result)
2988c2ecf20Sopenharmony_ci{
2998c2ecf20Sopenharmony_ci	return 0;
3008c2ecf20Sopenharmony_ci}
3018c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_blockdev);
3028c2ecf20Sopenharmony_ci
3038c2ecf20Sopenharmony_ciint fs_param_is_path(struct p_log *log, const struct fs_parameter_spec *p,
3048c2ecf20Sopenharmony_ci		     struct fs_parameter *param, struct fs_parse_result *result)
3058c2ecf20Sopenharmony_ci{
3068c2ecf20Sopenharmony_ci	return 0;
3078c2ecf20Sopenharmony_ci}
3088c2ecf20Sopenharmony_ciEXPORT_SYMBOL(fs_param_is_path);
3098c2ecf20Sopenharmony_ci
3108c2ecf20Sopenharmony_ci#ifdef CONFIG_VALIDATE_FS_PARSER
3118c2ecf20Sopenharmony_ci/**
3128c2ecf20Sopenharmony_ci * validate_constant_table - Validate a constant table
3138c2ecf20Sopenharmony_ci * @name: Name to use in reporting
3148c2ecf20Sopenharmony_ci * @tbl: The constant table to validate.
3158c2ecf20Sopenharmony_ci * @tbl_size: The size of the table.
3168c2ecf20Sopenharmony_ci * @low: The lowest permissible value.
3178c2ecf20Sopenharmony_ci * @high: The highest permissible value.
3188c2ecf20Sopenharmony_ci * @special: One special permissible value outside of the range.
3198c2ecf20Sopenharmony_ci */
3208c2ecf20Sopenharmony_cibool validate_constant_table(const struct constant_table *tbl, size_t tbl_size,
3218c2ecf20Sopenharmony_ci			     int low, int high, int special)
3228c2ecf20Sopenharmony_ci{
3238c2ecf20Sopenharmony_ci	size_t i;
3248c2ecf20Sopenharmony_ci	bool good = true;
3258c2ecf20Sopenharmony_ci
3268c2ecf20Sopenharmony_ci	if (tbl_size == 0) {
3278c2ecf20Sopenharmony_ci		pr_warn("VALIDATE C-TBL: Empty\n");
3288c2ecf20Sopenharmony_ci		return true;
3298c2ecf20Sopenharmony_ci	}
3308c2ecf20Sopenharmony_ci
3318c2ecf20Sopenharmony_ci	for (i = 0; i < tbl_size; i++) {
3328c2ecf20Sopenharmony_ci		if (!tbl[i].name) {
3338c2ecf20Sopenharmony_ci			pr_err("VALIDATE C-TBL[%zu]: Null\n", i);
3348c2ecf20Sopenharmony_ci			good = false;
3358c2ecf20Sopenharmony_ci		} else if (i > 0 && tbl[i - 1].name) {
3368c2ecf20Sopenharmony_ci			int c = strcmp(tbl[i-1].name, tbl[i].name);
3378c2ecf20Sopenharmony_ci
3388c2ecf20Sopenharmony_ci			if (c == 0) {
3398c2ecf20Sopenharmony_ci				pr_err("VALIDATE C-TBL[%zu]: Duplicate %s\n",
3408c2ecf20Sopenharmony_ci				       i, tbl[i].name);
3418c2ecf20Sopenharmony_ci				good = false;
3428c2ecf20Sopenharmony_ci			}
3438c2ecf20Sopenharmony_ci			if (c > 0) {
3448c2ecf20Sopenharmony_ci				pr_err("VALIDATE C-TBL[%zu]: Missorted %s>=%s\n",
3458c2ecf20Sopenharmony_ci				       i, tbl[i-1].name, tbl[i].name);
3468c2ecf20Sopenharmony_ci				good = false;
3478c2ecf20Sopenharmony_ci			}
3488c2ecf20Sopenharmony_ci		}
3498c2ecf20Sopenharmony_ci
3508c2ecf20Sopenharmony_ci		if (tbl[i].value != special &&
3518c2ecf20Sopenharmony_ci		    (tbl[i].value < low || tbl[i].value > high)) {
3528c2ecf20Sopenharmony_ci			pr_err("VALIDATE C-TBL[%zu]: %s->%d const out of range (%d-%d)\n",
3538c2ecf20Sopenharmony_ci			       i, tbl[i].name, tbl[i].value, low, high);
3548c2ecf20Sopenharmony_ci			good = false;
3558c2ecf20Sopenharmony_ci		}
3568c2ecf20Sopenharmony_ci	}
3578c2ecf20Sopenharmony_ci
3588c2ecf20Sopenharmony_ci	return good;
3598c2ecf20Sopenharmony_ci}
3608c2ecf20Sopenharmony_ci
3618c2ecf20Sopenharmony_ci/**
3628c2ecf20Sopenharmony_ci * fs_validate_description - Validate a parameter description
3638c2ecf20Sopenharmony_ci * @desc: The parameter description to validate.
3648c2ecf20Sopenharmony_ci */
3658c2ecf20Sopenharmony_cibool fs_validate_description(const char *name,
3668c2ecf20Sopenharmony_ci	const struct fs_parameter_spec *desc)
3678c2ecf20Sopenharmony_ci{
3688c2ecf20Sopenharmony_ci	const struct fs_parameter_spec *param, *p2;
3698c2ecf20Sopenharmony_ci	bool good = true;
3708c2ecf20Sopenharmony_ci
3718c2ecf20Sopenharmony_ci	for (param = desc; param->name; param++) {
3728c2ecf20Sopenharmony_ci		/* Check for duplicate parameter names */
3738c2ecf20Sopenharmony_ci		for (p2 = desc; p2 < param; p2++) {
3748c2ecf20Sopenharmony_ci			if (strcmp(param->name, p2->name) == 0) {
3758c2ecf20Sopenharmony_ci				if (is_flag(param) != is_flag(p2))
3768c2ecf20Sopenharmony_ci					continue;
3778c2ecf20Sopenharmony_ci				pr_err("VALIDATE %s: PARAM[%s]: Duplicate\n",
3788c2ecf20Sopenharmony_ci				       name, param->name);
3798c2ecf20Sopenharmony_ci				good = false;
3808c2ecf20Sopenharmony_ci			}
3818c2ecf20Sopenharmony_ci		}
3828c2ecf20Sopenharmony_ci	}
3838c2ecf20Sopenharmony_ci	return good;
3848c2ecf20Sopenharmony_ci}
3858c2ecf20Sopenharmony_ci#endif /* CONFIG_VALIDATE_FS_PARSER */
386