18c2ecf20Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only
28c2ecf20Sopenharmony_ci/*
38c2ecf20Sopenharmony_ci * Remote processor machine-specific module for DA8XX
48c2ecf20Sopenharmony_ci *
58c2ecf20Sopenharmony_ci * Copyright (C) 2013 Texas Instruments, Inc.
68c2ecf20Sopenharmony_ci */
78c2ecf20Sopenharmony_ci
88c2ecf20Sopenharmony_ci#include <linux/bitops.h>
98c2ecf20Sopenharmony_ci#include <linux/clk.h>
108c2ecf20Sopenharmony_ci#include <linux/reset.h>
118c2ecf20Sopenharmony_ci#include <linux/err.h>
128c2ecf20Sopenharmony_ci#include <linux/interrupt.h>
138c2ecf20Sopenharmony_ci#include <linux/io.h>
148c2ecf20Sopenharmony_ci#include <linux/irq.h>
158c2ecf20Sopenharmony_ci#include <linux/kernel.h>
168c2ecf20Sopenharmony_ci#include <linux/module.h>
178c2ecf20Sopenharmony_ci#include <linux/of_reserved_mem.h>
188c2ecf20Sopenharmony_ci#include <linux/platform_device.h>
198c2ecf20Sopenharmony_ci#include <linux/remoteproc.h>
208c2ecf20Sopenharmony_ci
218c2ecf20Sopenharmony_ci#include "remoteproc_internal.h"
228c2ecf20Sopenharmony_ci
238c2ecf20Sopenharmony_cistatic char *da8xx_fw_name;
248c2ecf20Sopenharmony_cimodule_param(da8xx_fw_name, charp, 0444);
258c2ecf20Sopenharmony_ciMODULE_PARM_DESC(da8xx_fw_name,
268c2ecf20Sopenharmony_ci		 "Name of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')");
278c2ecf20Sopenharmony_ci
288c2ecf20Sopenharmony_ci/*
298c2ecf20Sopenharmony_ci * OMAP-L138 Technical References:
308c2ecf20Sopenharmony_ci * http://www.ti.com/product/omap-l138
318c2ecf20Sopenharmony_ci */
328c2ecf20Sopenharmony_ci#define SYSCFG_CHIPSIG0 BIT(0)
338c2ecf20Sopenharmony_ci#define SYSCFG_CHIPSIG1 BIT(1)
348c2ecf20Sopenharmony_ci#define SYSCFG_CHIPSIG2 BIT(2)
358c2ecf20Sopenharmony_ci#define SYSCFG_CHIPSIG3 BIT(3)
368c2ecf20Sopenharmony_ci#define SYSCFG_CHIPSIG4 BIT(4)
378c2ecf20Sopenharmony_ci
388c2ecf20Sopenharmony_ci#define DA8XX_RPROC_LOCAL_ADDRESS_MASK	(SZ_16M - 1)
398c2ecf20Sopenharmony_ci
408c2ecf20Sopenharmony_ci/**
418c2ecf20Sopenharmony_ci * struct da8xx_rproc_mem - internal memory structure
428c2ecf20Sopenharmony_ci * @cpu_addr: MPU virtual address of the memory region
438c2ecf20Sopenharmony_ci * @bus_addr: Bus address used to access the memory region
448c2ecf20Sopenharmony_ci * @dev_addr: Device address of the memory region from DSP view
458c2ecf20Sopenharmony_ci * @size: Size of the memory region
468c2ecf20Sopenharmony_ci */
478c2ecf20Sopenharmony_cistruct da8xx_rproc_mem {
488c2ecf20Sopenharmony_ci	void __iomem *cpu_addr;
498c2ecf20Sopenharmony_ci	phys_addr_t bus_addr;
508c2ecf20Sopenharmony_ci	u32 dev_addr;
518c2ecf20Sopenharmony_ci	size_t size;
528c2ecf20Sopenharmony_ci};
538c2ecf20Sopenharmony_ci
548c2ecf20Sopenharmony_ci/**
558c2ecf20Sopenharmony_ci * struct da8xx_rproc - da8xx remote processor instance state
568c2ecf20Sopenharmony_ci * @rproc: rproc handle
578c2ecf20Sopenharmony_ci * @mem: internal memory regions data
588c2ecf20Sopenharmony_ci * @num_mems: number of internal memory regions
598c2ecf20Sopenharmony_ci * @dsp_clk: placeholder for platform's DSP clk
608c2ecf20Sopenharmony_ci * @ack_fxn: chip-specific ack function for ack'ing irq
618c2ecf20Sopenharmony_ci * @irq_data: ack_fxn function parameter
628c2ecf20Sopenharmony_ci * @chipsig: virt ptr to DSP interrupt registers (CHIPSIG & CHIPSIG_CLR)
638c2ecf20Sopenharmony_ci * @bootreg: virt ptr to DSP boot address register (HOST1CFG)
648c2ecf20Sopenharmony_ci * @irq: irq # used by this instance
658c2ecf20Sopenharmony_ci */
668c2ecf20Sopenharmony_cistruct da8xx_rproc {
678c2ecf20Sopenharmony_ci	struct rproc *rproc;
688c2ecf20Sopenharmony_ci	struct da8xx_rproc_mem *mem;
698c2ecf20Sopenharmony_ci	int num_mems;
708c2ecf20Sopenharmony_ci	struct clk *dsp_clk;
718c2ecf20Sopenharmony_ci	struct reset_control *dsp_reset;
728c2ecf20Sopenharmony_ci	void (*ack_fxn)(struct irq_data *data);
738c2ecf20Sopenharmony_ci	struct irq_data *irq_data;
748c2ecf20Sopenharmony_ci	void __iomem *chipsig;
758c2ecf20Sopenharmony_ci	void __iomem *bootreg;
768c2ecf20Sopenharmony_ci	int irq;
778c2ecf20Sopenharmony_ci};
788c2ecf20Sopenharmony_ci
798c2ecf20Sopenharmony_ci/**
808c2ecf20Sopenharmony_ci * handle_event() - inbound virtqueue message workqueue function
818c2ecf20Sopenharmony_ci *
828c2ecf20Sopenharmony_ci * This function is registered as a kernel thread and is scheduled by the
838c2ecf20Sopenharmony_ci * kernel handler.
848c2ecf20Sopenharmony_ci */
858c2ecf20Sopenharmony_cistatic irqreturn_t handle_event(int irq, void *p)
868c2ecf20Sopenharmony_ci{
878c2ecf20Sopenharmony_ci	struct rproc *rproc = (struct rproc *)p;
888c2ecf20Sopenharmony_ci
898c2ecf20Sopenharmony_ci	/* Process incoming buffers on all our vrings */
908c2ecf20Sopenharmony_ci	rproc_vq_interrupt(rproc, 0);
918c2ecf20Sopenharmony_ci	rproc_vq_interrupt(rproc, 1);
928c2ecf20Sopenharmony_ci
938c2ecf20Sopenharmony_ci	return IRQ_HANDLED;
948c2ecf20Sopenharmony_ci}
958c2ecf20Sopenharmony_ci
968c2ecf20Sopenharmony_ci/**
978c2ecf20Sopenharmony_ci * da8xx_rproc_callback() - inbound virtqueue message handler
988c2ecf20Sopenharmony_ci *
998c2ecf20Sopenharmony_ci * This handler is invoked directly by the kernel whenever the remote
1008c2ecf20Sopenharmony_ci * core (DSP) has modified the state of a virtqueue.  There is no
1018c2ecf20Sopenharmony_ci * "payload" message indicating the virtqueue index as is the case with
1028c2ecf20Sopenharmony_ci * mailbox-based implementations on OMAP4.  As such, this handler "polls"
1038c2ecf20Sopenharmony_ci * each known virtqueue index for every invocation.
1048c2ecf20Sopenharmony_ci */
1058c2ecf20Sopenharmony_cistatic irqreturn_t da8xx_rproc_callback(int irq, void *p)
1068c2ecf20Sopenharmony_ci{
1078c2ecf20Sopenharmony_ci	struct rproc *rproc = (struct rproc *)p;
1088c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
1098c2ecf20Sopenharmony_ci	u32 chipsig;
1108c2ecf20Sopenharmony_ci
1118c2ecf20Sopenharmony_ci	chipsig = readl(drproc->chipsig);
1128c2ecf20Sopenharmony_ci	if (chipsig & SYSCFG_CHIPSIG0) {
1138c2ecf20Sopenharmony_ci		/* Clear interrupt level source */
1148c2ecf20Sopenharmony_ci		writel(SYSCFG_CHIPSIG0, drproc->chipsig + 4);
1158c2ecf20Sopenharmony_ci
1168c2ecf20Sopenharmony_ci		/*
1178c2ecf20Sopenharmony_ci		 * ACK intr to AINTC.
1188c2ecf20Sopenharmony_ci		 *
1198c2ecf20Sopenharmony_ci		 * It has already been ack'ed by the kernel before calling
1208c2ecf20Sopenharmony_ci		 * this function, but since the ARM<->DSP interrupts in the
1218c2ecf20Sopenharmony_ci		 * CHIPSIG register are "level" instead of "pulse" variety,
1228c2ecf20Sopenharmony_ci		 * we need to ack it after taking down the level else we'll
1238c2ecf20Sopenharmony_ci		 * be called again immediately after returning.
1248c2ecf20Sopenharmony_ci		 */
1258c2ecf20Sopenharmony_ci		drproc->ack_fxn(drproc->irq_data);
1268c2ecf20Sopenharmony_ci
1278c2ecf20Sopenharmony_ci		return IRQ_WAKE_THREAD;
1288c2ecf20Sopenharmony_ci	}
1298c2ecf20Sopenharmony_ci
1308c2ecf20Sopenharmony_ci	return IRQ_HANDLED;
1318c2ecf20Sopenharmony_ci}
1328c2ecf20Sopenharmony_ci
1338c2ecf20Sopenharmony_cistatic int da8xx_rproc_start(struct rproc *rproc)
1348c2ecf20Sopenharmony_ci{
1358c2ecf20Sopenharmony_ci	struct device *dev = rproc->dev.parent;
1368c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
1378c2ecf20Sopenharmony_ci	struct clk *dsp_clk = drproc->dsp_clk;
1388c2ecf20Sopenharmony_ci	struct reset_control *dsp_reset = drproc->dsp_reset;
1398c2ecf20Sopenharmony_ci	int ret;
1408c2ecf20Sopenharmony_ci
1418c2ecf20Sopenharmony_ci	/* hw requires the start (boot) address be on 1KB boundary */
1428c2ecf20Sopenharmony_ci	if (rproc->bootaddr & 0x3ff) {
1438c2ecf20Sopenharmony_ci		dev_err(dev, "invalid boot address: must be aligned to 1KB\n");
1448c2ecf20Sopenharmony_ci
1458c2ecf20Sopenharmony_ci		return -EINVAL;
1468c2ecf20Sopenharmony_ci	}
1478c2ecf20Sopenharmony_ci
1488c2ecf20Sopenharmony_ci	writel(rproc->bootaddr, drproc->bootreg);
1498c2ecf20Sopenharmony_ci
1508c2ecf20Sopenharmony_ci	ret = clk_prepare_enable(dsp_clk);
1518c2ecf20Sopenharmony_ci	if (ret) {
1528c2ecf20Sopenharmony_ci		dev_err(dev, "clk_prepare_enable() failed: %d\n", ret);
1538c2ecf20Sopenharmony_ci		return ret;
1548c2ecf20Sopenharmony_ci	}
1558c2ecf20Sopenharmony_ci
1568c2ecf20Sopenharmony_ci	ret = reset_control_deassert(dsp_reset);
1578c2ecf20Sopenharmony_ci	if (ret) {
1588c2ecf20Sopenharmony_ci		dev_err(dev, "reset_control_deassert() failed: %d\n", ret);
1598c2ecf20Sopenharmony_ci		clk_disable_unprepare(dsp_clk);
1608c2ecf20Sopenharmony_ci		return ret;
1618c2ecf20Sopenharmony_ci	}
1628c2ecf20Sopenharmony_ci
1638c2ecf20Sopenharmony_ci	return 0;
1648c2ecf20Sopenharmony_ci}
1658c2ecf20Sopenharmony_ci
1668c2ecf20Sopenharmony_cistatic int da8xx_rproc_stop(struct rproc *rproc)
1678c2ecf20Sopenharmony_ci{
1688c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc = rproc->priv;
1698c2ecf20Sopenharmony_ci	struct device *dev = rproc->dev.parent;
1708c2ecf20Sopenharmony_ci	int ret;
1718c2ecf20Sopenharmony_ci
1728c2ecf20Sopenharmony_ci	ret = reset_control_assert(drproc->dsp_reset);
1738c2ecf20Sopenharmony_ci	if (ret) {
1748c2ecf20Sopenharmony_ci		dev_err(dev, "reset_control_assert() failed: %d\n", ret);
1758c2ecf20Sopenharmony_ci		return ret;
1768c2ecf20Sopenharmony_ci	}
1778c2ecf20Sopenharmony_ci
1788c2ecf20Sopenharmony_ci	clk_disable_unprepare(drproc->dsp_clk);
1798c2ecf20Sopenharmony_ci
1808c2ecf20Sopenharmony_ci	return 0;
1818c2ecf20Sopenharmony_ci}
1828c2ecf20Sopenharmony_ci
1838c2ecf20Sopenharmony_ci/* kick a virtqueue */
1848c2ecf20Sopenharmony_cistatic void da8xx_rproc_kick(struct rproc *rproc, int vqid)
1858c2ecf20Sopenharmony_ci{
1868c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
1878c2ecf20Sopenharmony_ci
1888c2ecf20Sopenharmony_ci	/* Interrupt remote proc */
1898c2ecf20Sopenharmony_ci	writel(SYSCFG_CHIPSIG2, drproc->chipsig);
1908c2ecf20Sopenharmony_ci}
1918c2ecf20Sopenharmony_ci
1928c2ecf20Sopenharmony_cistatic const struct rproc_ops da8xx_rproc_ops = {
1938c2ecf20Sopenharmony_ci	.start = da8xx_rproc_start,
1948c2ecf20Sopenharmony_ci	.stop = da8xx_rproc_stop,
1958c2ecf20Sopenharmony_ci	.kick = da8xx_rproc_kick,
1968c2ecf20Sopenharmony_ci};
1978c2ecf20Sopenharmony_ci
1988c2ecf20Sopenharmony_cistatic int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
1998c2ecf20Sopenharmony_ci					     struct da8xx_rproc *drproc)
2008c2ecf20Sopenharmony_ci{
2018c2ecf20Sopenharmony_ci	static const char * const mem_names[] = {"l2sram", "l1pram", "l1dram"};
2028c2ecf20Sopenharmony_ci	int num_mems = ARRAY_SIZE(mem_names);
2038c2ecf20Sopenharmony_ci	struct device *dev = &pdev->dev;
2048c2ecf20Sopenharmony_ci	struct resource *res;
2058c2ecf20Sopenharmony_ci	int i;
2068c2ecf20Sopenharmony_ci
2078c2ecf20Sopenharmony_ci	drproc->mem = devm_kcalloc(dev, num_mems, sizeof(*drproc->mem),
2088c2ecf20Sopenharmony_ci				   GFP_KERNEL);
2098c2ecf20Sopenharmony_ci	if (!drproc->mem)
2108c2ecf20Sopenharmony_ci		return -ENOMEM;
2118c2ecf20Sopenharmony_ci
2128c2ecf20Sopenharmony_ci	for (i = 0; i < num_mems; i++) {
2138c2ecf20Sopenharmony_ci		res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
2148c2ecf20Sopenharmony_ci						   mem_names[i]);
2158c2ecf20Sopenharmony_ci		drproc->mem[i].cpu_addr = devm_ioremap_resource(dev, res);
2168c2ecf20Sopenharmony_ci		if (IS_ERR(drproc->mem[i].cpu_addr)) {
2178c2ecf20Sopenharmony_ci			dev_err(dev, "failed to parse and map %s memory\n",
2188c2ecf20Sopenharmony_ci				mem_names[i]);
2198c2ecf20Sopenharmony_ci			return PTR_ERR(drproc->mem[i].cpu_addr);
2208c2ecf20Sopenharmony_ci		}
2218c2ecf20Sopenharmony_ci		drproc->mem[i].bus_addr = res->start;
2228c2ecf20Sopenharmony_ci		drproc->mem[i].dev_addr =
2238c2ecf20Sopenharmony_ci				res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
2248c2ecf20Sopenharmony_ci		drproc->mem[i].size = resource_size(res);
2258c2ecf20Sopenharmony_ci
2268c2ecf20Sopenharmony_ci		dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
2278c2ecf20Sopenharmony_ci			mem_names[i], &drproc->mem[i].bus_addr,
2288c2ecf20Sopenharmony_ci			drproc->mem[i].size, drproc->mem[i].cpu_addr,
2298c2ecf20Sopenharmony_ci			drproc->mem[i].dev_addr);
2308c2ecf20Sopenharmony_ci	}
2318c2ecf20Sopenharmony_ci	drproc->num_mems = num_mems;
2328c2ecf20Sopenharmony_ci
2338c2ecf20Sopenharmony_ci	return 0;
2348c2ecf20Sopenharmony_ci}
2358c2ecf20Sopenharmony_ci
2368c2ecf20Sopenharmony_cistatic int da8xx_rproc_probe(struct platform_device *pdev)
2378c2ecf20Sopenharmony_ci{
2388c2ecf20Sopenharmony_ci	struct device *dev = &pdev->dev;
2398c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc;
2408c2ecf20Sopenharmony_ci	struct rproc *rproc;
2418c2ecf20Sopenharmony_ci	struct irq_data *irq_data;
2428c2ecf20Sopenharmony_ci	struct resource *bootreg_res;
2438c2ecf20Sopenharmony_ci	struct resource *chipsig_res;
2448c2ecf20Sopenharmony_ci	struct clk *dsp_clk;
2458c2ecf20Sopenharmony_ci	struct reset_control *dsp_reset;
2468c2ecf20Sopenharmony_ci	void __iomem *chipsig;
2478c2ecf20Sopenharmony_ci	void __iomem *bootreg;
2488c2ecf20Sopenharmony_ci	int irq;
2498c2ecf20Sopenharmony_ci	int ret;
2508c2ecf20Sopenharmony_ci
2518c2ecf20Sopenharmony_ci	irq = platform_get_irq(pdev, 0);
2528c2ecf20Sopenharmony_ci	if (irq < 0)
2538c2ecf20Sopenharmony_ci		return irq;
2548c2ecf20Sopenharmony_ci
2558c2ecf20Sopenharmony_ci	irq_data = irq_get_irq_data(irq);
2568c2ecf20Sopenharmony_ci	if (!irq_data) {
2578c2ecf20Sopenharmony_ci		dev_err(dev, "irq_get_irq_data(%d): NULL\n", irq);
2588c2ecf20Sopenharmony_ci		return -EINVAL;
2598c2ecf20Sopenharmony_ci	}
2608c2ecf20Sopenharmony_ci
2618c2ecf20Sopenharmony_ci	bootreg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
2628c2ecf20Sopenharmony_ci						   "host1cfg");
2638c2ecf20Sopenharmony_ci	bootreg = devm_ioremap_resource(dev, bootreg_res);
2648c2ecf20Sopenharmony_ci	if (IS_ERR(bootreg))
2658c2ecf20Sopenharmony_ci		return PTR_ERR(bootreg);
2668c2ecf20Sopenharmony_ci
2678c2ecf20Sopenharmony_ci	chipsig_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
2688c2ecf20Sopenharmony_ci						   "chipsig");
2698c2ecf20Sopenharmony_ci	chipsig = devm_ioremap_resource(dev, chipsig_res);
2708c2ecf20Sopenharmony_ci	if (IS_ERR(chipsig))
2718c2ecf20Sopenharmony_ci		return PTR_ERR(chipsig);
2728c2ecf20Sopenharmony_ci
2738c2ecf20Sopenharmony_ci	dsp_clk = devm_clk_get(dev, NULL);
2748c2ecf20Sopenharmony_ci	if (IS_ERR(dsp_clk)) {
2758c2ecf20Sopenharmony_ci		dev_err(dev, "clk_get error: %ld\n", PTR_ERR(dsp_clk));
2768c2ecf20Sopenharmony_ci
2778c2ecf20Sopenharmony_ci		return PTR_ERR(dsp_clk);
2788c2ecf20Sopenharmony_ci	}
2798c2ecf20Sopenharmony_ci
2808c2ecf20Sopenharmony_ci	dsp_reset = devm_reset_control_get_exclusive(dev, NULL);
2818c2ecf20Sopenharmony_ci	if (IS_ERR(dsp_reset)) {
2828c2ecf20Sopenharmony_ci		if (PTR_ERR(dsp_reset) != -EPROBE_DEFER)
2838c2ecf20Sopenharmony_ci			dev_err(dev, "unable to get reset control: %ld\n",
2848c2ecf20Sopenharmony_ci				PTR_ERR(dsp_reset));
2858c2ecf20Sopenharmony_ci
2868c2ecf20Sopenharmony_ci		return PTR_ERR(dsp_reset);
2878c2ecf20Sopenharmony_ci	}
2888c2ecf20Sopenharmony_ci
2898c2ecf20Sopenharmony_ci	if (dev->of_node) {
2908c2ecf20Sopenharmony_ci		ret = of_reserved_mem_device_init(dev);
2918c2ecf20Sopenharmony_ci		if (ret) {
2928c2ecf20Sopenharmony_ci			dev_err(dev, "device does not have specific CMA pool: %d\n",
2938c2ecf20Sopenharmony_ci				ret);
2948c2ecf20Sopenharmony_ci			return ret;
2958c2ecf20Sopenharmony_ci		}
2968c2ecf20Sopenharmony_ci	}
2978c2ecf20Sopenharmony_ci
2988c2ecf20Sopenharmony_ci	rproc = rproc_alloc(dev, "dsp", &da8xx_rproc_ops, da8xx_fw_name,
2998c2ecf20Sopenharmony_ci		sizeof(*drproc));
3008c2ecf20Sopenharmony_ci	if (!rproc) {
3018c2ecf20Sopenharmony_ci		ret = -ENOMEM;
3028c2ecf20Sopenharmony_ci		goto free_mem;
3038c2ecf20Sopenharmony_ci	}
3048c2ecf20Sopenharmony_ci
3058c2ecf20Sopenharmony_ci	/* error recovery is not supported at present */
3068c2ecf20Sopenharmony_ci	rproc->recovery_disabled = true;
3078c2ecf20Sopenharmony_ci
3088c2ecf20Sopenharmony_ci	drproc = rproc->priv;
3098c2ecf20Sopenharmony_ci	drproc->rproc = rproc;
3108c2ecf20Sopenharmony_ci	drproc->dsp_clk = dsp_clk;
3118c2ecf20Sopenharmony_ci	drproc->dsp_reset = dsp_reset;
3128c2ecf20Sopenharmony_ci	rproc->has_iommu = false;
3138c2ecf20Sopenharmony_ci
3148c2ecf20Sopenharmony_ci	ret = da8xx_rproc_get_internal_memories(pdev, drproc);
3158c2ecf20Sopenharmony_ci	if (ret)
3168c2ecf20Sopenharmony_ci		goto free_rproc;
3178c2ecf20Sopenharmony_ci
3188c2ecf20Sopenharmony_ci	platform_set_drvdata(pdev, rproc);
3198c2ecf20Sopenharmony_ci
3208c2ecf20Sopenharmony_ci	/* everything the ISR needs is now setup, so hook it up */
3218c2ecf20Sopenharmony_ci	ret = devm_request_threaded_irq(dev, irq, da8xx_rproc_callback,
3228c2ecf20Sopenharmony_ci					handle_event, 0, "da8xx-remoteproc",
3238c2ecf20Sopenharmony_ci					rproc);
3248c2ecf20Sopenharmony_ci	if (ret) {
3258c2ecf20Sopenharmony_ci		dev_err(dev, "devm_request_threaded_irq error: %d\n", ret);
3268c2ecf20Sopenharmony_ci		goto free_rproc;
3278c2ecf20Sopenharmony_ci	}
3288c2ecf20Sopenharmony_ci
3298c2ecf20Sopenharmony_ci	/*
3308c2ecf20Sopenharmony_ci	 * rproc_add() can end up enabling the DSP's clk with the DSP
3318c2ecf20Sopenharmony_ci	 * *not* in reset, but da8xx_rproc_start() needs the DSP to be
3328c2ecf20Sopenharmony_ci	 * held in reset at the time it is called.
3338c2ecf20Sopenharmony_ci	 */
3348c2ecf20Sopenharmony_ci	ret = reset_control_assert(dsp_reset);
3358c2ecf20Sopenharmony_ci	if (ret)
3368c2ecf20Sopenharmony_ci		goto free_rproc;
3378c2ecf20Sopenharmony_ci
3388c2ecf20Sopenharmony_ci	drproc->chipsig = chipsig;
3398c2ecf20Sopenharmony_ci	drproc->bootreg = bootreg;
3408c2ecf20Sopenharmony_ci	drproc->ack_fxn = irq_data->chip->irq_ack;
3418c2ecf20Sopenharmony_ci	drproc->irq_data = irq_data;
3428c2ecf20Sopenharmony_ci	drproc->irq = irq;
3438c2ecf20Sopenharmony_ci
3448c2ecf20Sopenharmony_ci	ret = rproc_add(rproc);
3458c2ecf20Sopenharmony_ci	if (ret) {
3468c2ecf20Sopenharmony_ci		dev_err(dev, "rproc_add failed: %d\n", ret);
3478c2ecf20Sopenharmony_ci		goto free_rproc;
3488c2ecf20Sopenharmony_ci	}
3498c2ecf20Sopenharmony_ci
3508c2ecf20Sopenharmony_ci	return 0;
3518c2ecf20Sopenharmony_ci
3528c2ecf20Sopenharmony_cifree_rproc:
3538c2ecf20Sopenharmony_ci	rproc_free(rproc);
3548c2ecf20Sopenharmony_cifree_mem:
3558c2ecf20Sopenharmony_ci	if (dev->of_node)
3568c2ecf20Sopenharmony_ci		of_reserved_mem_device_release(dev);
3578c2ecf20Sopenharmony_ci	return ret;
3588c2ecf20Sopenharmony_ci}
3598c2ecf20Sopenharmony_ci
3608c2ecf20Sopenharmony_cistatic int da8xx_rproc_remove(struct platform_device *pdev)
3618c2ecf20Sopenharmony_ci{
3628c2ecf20Sopenharmony_ci	struct rproc *rproc = platform_get_drvdata(pdev);
3638c2ecf20Sopenharmony_ci	struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
3648c2ecf20Sopenharmony_ci	struct device *dev = &pdev->dev;
3658c2ecf20Sopenharmony_ci
3668c2ecf20Sopenharmony_ci	/*
3678c2ecf20Sopenharmony_ci	 * The devm subsystem might end up releasing things before
3688c2ecf20Sopenharmony_ci	 * freeing the irq, thus allowing an interrupt to sneak in while
3698c2ecf20Sopenharmony_ci	 * the device is being removed.  This should prevent that.
3708c2ecf20Sopenharmony_ci	 */
3718c2ecf20Sopenharmony_ci	disable_irq(drproc->irq);
3728c2ecf20Sopenharmony_ci
3738c2ecf20Sopenharmony_ci	rproc_del(rproc);
3748c2ecf20Sopenharmony_ci	rproc_free(rproc);
3758c2ecf20Sopenharmony_ci	if (dev->of_node)
3768c2ecf20Sopenharmony_ci		of_reserved_mem_device_release(dev);
3778c2ecf20Sopenharmony_ci
3788c2ecf20Sopenharmony_ci	return 0;
3798c2ecf20Sopenharmony_ci}
3808c2ecf20Sopenharmony_ci
3818c2ecf20Sopenharmony_cistatic const struct of_device_id davinci_rproc_of_match[] __maybe_unused = {
3828c2ecf20Sopenharmony_ci	{ .compatible = "ti,da850-dsp", },
3838c2ecf20Sopenharmony_ci	{ /* sentinel */ },
3848c2ecf20Sopenharmony_ci};
3858c2ecf20Sopenharmony_ciMODULE_DEVICE_TABLE(of, davinci_rproc_of_match);
3868c2ecf20Sopenharmony_ci
3878c2ecf20Sopenharmony_cistatic struct platform_driver da8xx_rproc_driver = {
3888c2ecf20Sopenharmony_ci	.probe = da8xx_rproc_probe,
3898c2ecf20Sopenharmony_ci	.remove = da8xx_rproc_remove,
3908c2ecf20Sopenharmony_ci	.driver = {
3918c2ecf20Sopenharmony_ci		.name = "davinci-rproc",
3928c2ecf20Sopenharmony_ci		.of_match_table = of_match_ptr(davinci_rproc_of_match),
3938c2ecf20Sopenharmony_ci	},
3948c2ecf20Sopenharmony_ci};
3958c2ecf20Sopenharmony_ci
3968c2ecf20Sopenharmony_cimodule_platform_driver(da8xx_rproc_driver);
3978c2ecf20Sopenharmony_ci
3988c2ecf20Sopenharmony_ciMODULE_LICENSE("GPL v2");
3998c2ecf20Sopenharmony_ciMODULE_DESCRIPTION("DA8XX Remote Processor control driver");
400