18c2ecf20Sopenharmony_ci// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
28c2ecf20Sopenharmony_ci#include "dpaa2-eth.h"
38c2ecf20Sopenharmony_ci/* Copyright 2020 NXP
48c2ecf20Sopenharmony_ci */
58c2ecf20Sopenharmony_ci
68c2ecf20Sopenharmony_ci#define DPAA2_ETH_TRAP_DROP(_id, _group_id)					\
78c2ecf20Sopenharmony_ci	DEVLINK_TRAP_GENERIC(DROP, DROP, _id,					\
88c2ecf20Sopenharmony_ci			     DEVLINK_TRAP_GROUP_GENERIC_ID_##_group_id, 0)
98c2ecf20Sopenharmony_ci
108c2ecf20Sopenharmony_cistatic const struct devlink_trap_group dpaa2_eth_trap_groups_arr[] = {
118c2ecf20Sopenharmony_ci	DEVLINK_TRAP_GROUP_GENERIC(PARSER_ERROR_DROPS, 0),
128c2ecf20Sopenharmony_ci};
138c2ecf20Sopenharmony_ci
148c2ecf20Sopenharmony_cistatic const struct devlink_trap dpaa2_eth_traps_arr[] = {
158c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(VXLAN_PARSING, PARSER_ERROR_DROPS),
168c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(LLC_SNAP_PARSING, PARSER_ERROR_DROPS),
178c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(VLAN_PARSING, PARSER_ERROR_DROPS),
188c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(PPPOE_PPP_PARSING, PARSER_ERROR_DROPS),
198c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(MPLS_PARSING, PARSER_ERROR_DROPS),
208c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(ARP_PARSING, PARSER_ERROR_DROPS),
218c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(IP_1_PARSING, PARSER_ERROR_DROPS),
228c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(IP_N_PARSING, PARSER_ERROR_DROPS),
238c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(GRE_PARSING, PARSER_ERROR_DROPS),
248c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(UDP_PARSING, PARSER_ERROR_DROPS),
258c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(TCP_PARSING, PARSER_ERROR_DROPS),
268c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(IPSEC_PARSING, PARSER_ERROR_DROPS),
278c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(SCTP_PARSING, PARSER_ERROR_DROPS),
288c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(DCCP_PARSING, PARSER_ERROR_DROPS),
298c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(GTP_PARSING, PARSER_ERROR_DROPS),
308c2ecf20Sopenharmony_ci	DPAA2_ETH_TRAP_DROP(ESP_PARSING, PARSER_ERROR_DROPS),
318c2ecf20Sopenharmony_ci};
328c2ecf20Sopenharmony_ci
338c2ecf20Sopenharmony_cistatic int dpaa2_eth_dl_info_get(struct devlink *devlink,
348c2ecf20Sopenharmony_ci				 struct devlink_info_req *req,
358c2ecf20Sopenharmony_ci				 struct netlink_ext_ack *extack)
368c2ecf20Sopenharmony_ci{
378c2ecf20Sopenharmony_ci	struct dpaa2_eth_devlink_priv *dl_priv = devlink_priv(devlink);
388c2ecf20Sopenharmony_ci	struct dpaa2_eth_priv *priv = dl_priv->dpaa2_priv;
398c2ecf20Sopenharmony_ci	char buf[10];
408c2ecf20Sopenharmony_ci	int err;
418c2ecf20Sopenharmony_ci
428c2ecf20Sopenharmony_ci	err = devlink_info_driver_name_put(req, KBUILD_MODNAME);
438c2ecf20Sopenharmony_ci	if (err)
448c2ecf20Sopenharmony_ci		return err;
458c2ecf20Sopenharmony_ci
468c2ecf20Sopenharmony_ci	scnprintf(buf, 10, "%d.%d", priv->dpni_ver_major, priv->dpni_ver_minor);
478c2ecf20Sopenharmony_ci	err = devlink_info_version_running_put(req, "dpni", buf);
488c2ecf20Sopenharmony_ci	if (err)
498c2ecf20Sopenharmony_ci		return err;
508c2ecf20Sopenharmony_ci
518c2ecf20Sopenharmony_ci	return 0;
528c2ecf20Sopenharmony_ci}
538c2ecf20Sopenharmony_ci
548c2ecf20Sopenharmony_cistatic struct dpaa2_eth_trap_item *
558c2ecf20Sopenharmony_cidpaa2_eth_dl_trap_item_lookup(struct dpaa2_eth_priv *priv, u16 trap_id)
568c2ecf20Sopenharmony_ci{
578c2ecf20Sopenharmony_ci	struct dpaa2_eth_trap_data *dpaa2_eth_trap_data = priv->trap_data;
588c2ecf20Sopenharmony_ci	int i;
598c2ecf20Sopenharmony_ci
608c2ecf20Sopenharmony_ci	for (i = 0; i < ARRAY_SIZE(dpaa2_eth_traps_arr); i++) {
618c2ecf20Sopenharmony_ci		if (dpaa2_eth_traps_arr[i].id == trap_id)
628c2ecf20Sopenharmony_ci			return &dpaa2_eth_trap_data->trap_items_arr[i];
638c2ecf20Sopenharmony_ci	}
648c2ecf20Sopenharmony_ci
658c2ecf20Sopenharmony_ci	return NULL;
668c2ecf20Sopenharmony_ci}
678c2ecf20Sopenharmony_ci
688c2ecf20Sopenharmony_cistruct dpaa2_eth_trap_item *dpaa2_eth_dl_get_trap(struct dpaa2_eth_priv *priv,
698c2ecf20Sopenharmony_ci						  struct dpaa2_fapr *fapr)
708c2ecf20Sopenharmony_ci{
718c2ecf20Sopenharmony_ci	struct dpaa2_faf_error_bit {
728c2ecf20Sopenharmony_ci		int position;
738c2ecf20Sopenharmony_ci		enum devlink_trap_generic_id trap_id;
748c2ecf20Sopenharmony_ci	} faf_bits[] = {
758c2ecf20Sopenharmony_ci		{ .position = 5,  .trap_id = DEVLINK_TRAP_GENERIC_ID_VXLAN_PARSING },
768c2ecf20Sopenharmony_ci		{ .position = 20, .trap_id = DEVLINK_TRAP_GENERIC_ID_LLC_SNAP_PARSING },
778c2ecf20Sopenharmony_ci		{ .position = 24, .trap_id = DEVLINK_TRAP_GENERIC_ID_VLAN_PARSING },
788c2ecf20Sopenharmony_ci		{ .position = 26, .trap_id = DEVLINK_TRAP_GENERIC_ID_PPPOE_PPP_PARSING },
798c2ecf20Sopenharmony_ci		{ .position = 29, .trap_id = DEVLINK_TRAP_GENERIC_ID_MPLS_PARSING },
808c2ecf20Sopenharmony_ci		{ .position = 31, .trap_id = DEVLINK_TRAP_GENERIC_ID_ARP_PARSING },
818c2ecf20Sopenharmony_ci		{ .position = 52, .trap_id = DEVLINK_TRAP_GENERIC_ID_IP_1_PARSING },
828c2ecf20Sopenharmony_ci		{ .position = 61, .trap_id = DEVLINK_TRAP_GENERIC_ID_IP_N_PARSING },
838c2ecf20Sopenharmony_ci		{ .position = 67, .trap_id = DEVLINK_TRAP_GENERIC_ID_GRE_PARSING },
848c2ecf20Sopenharmony_ci		{ .position = 71, .trap_id = DEVLINK_TRAP_GENERIC_ID_UDP_PARSING },
858c2ecf20Sopenharmony_ci		{ .position = 76, .trap_id = DEVLINK_TRAP_GENERIC_ID_TCP_PARSING },
868c2ecf20Sopenharmony_ci		{ .position = 80, .trap_id = DEVLINK_TRAP_GENERIC_ID_IPSEC_PARSING },
878c2ecf20Sopenharmony_ci		{ .position = 82, .trap_id = DEVLINK_TRAP_GENERIC_ID_SCTP_PARSING },
888c2ecf20Sopenharmony_ci		{ .position = 84, .trap_id = DEVLINK_TRAP_GENERIC_ID_DCCP_PARSING },
898c2ecf20Sopenharmony_ci		{ .position = 88, .trap_id = DEVLINK_TRAP_GENERIC_ID_GTP_PARSING },
908c2ecf20Sopenharmony_ci		{ .position = 90, .trap_id = DEVLINK_TRAP_GENERIC_ID_ESP_PARSING },
918c2ecf20Sopenharmony_ci	};
928c2ecf20Sopenharmony_ci	u64 faf_word;
938c2ecf20Sopenharmony_ci	u64 mask;
948c2ecf20Sopenharmony_ci	int i;
958c2ecf20Sopenharmony_ci
968c2ecf20Sopenharmony_ci	for (i = 0; i < ARRAY_SIZE(faf_bits); i++) {
978c2ecf20Sopenharmony_ci		if (faf_bits[i].position < 32) {
988c2ecf20Sopenharmony_ci			/* Low part of FAF.
998c2ecf20Sopenharmony_ci			 * position ranges from 31 to 0, mask from 0 to 31.
1008c2ecf20Sopenharmony_ci			 */
1018c2ecf20Sopenharmony_ci			mask = 1ull << (31 - faf_bits[i].position);
1028c2ecf20Sopenharmony_ci			faf_word = __le32_to_cpu(fapr->faf_lo);
1038c2ecf20Sopenharmony_ci		} else {
1048c2ecf20Sopenharmony_ci			/* High part of FAF.
1058c2ecf20Sopenharmony_ci			 * position ranges from 95 to 32, mask from 0 to 63.
1068c2ecf20Sopenharmony_ci			 */
1078c2ecf20Sopenharmony_ci			mask = 1ull << (63 - (faf_bits[i].position - 32));
1088c2ecf20Sopenharmony_ci			faf_word = __le64_to_cpu(fapr->faf_hi);
1098c2ecf20Sopenharmony_ci		}
1108c2ecf20Sopenharmony_ci		if (faf_word & mask)
1118c2ecf20Sopenharmony_ci			return dpaa2_eth_dl_trap_item_lookup(priv, faf_bits[i].trap_id);
1128c2ecf20Sopenharmony_ci	}
1138c2ecf20Sopenharmony_ci	return NULL;
1148c2ecf20Sopenharmony_ci}
1158c2ecf20Sopenharmony_ci
1168c2ecf20Sopenharmony_cistatic int dpaa2_eth_dl_trap_init(struct devlink *devlink,
1178c2ecf20Sopenharmony_ci				  const struct devlink_trap *trap,
1188c2ecf20Sopenharmony_ci				  void *trap_ctx)
1198c2ecf20Sopenharmony_ci{
1208c2ecf20Sopenharmony_ci	struct dpaa2_eth_devlink_priv *dl_priv = devlink_priv(devlink);
1218c2ecf20Sopenharmony_ci	struct dpaa2_eth_priv *priv = dl_priv->dpaa2_priv;
1228c2ecf20Sopenharmony_ci	struct dpaa2_eth_trap_item *dpaa2_eth_trap_item;
1238c2ecf20Sopenharmony_ci
1248c2ecf20Sopenharmony_ci	dpaa2_eth_trap_item = dpaa2_eth_dl_trap_item_lookup(priv, trap->id);
1258c2ecf20Sopenharmony_ci	if (WARN_ON(!dpaa2_eth_trap_item))
1268c2ecf20Sopenharmony_ci		return -ENOENT;
1278c2ecf20Sopenharmony_ci
1288c2ecf20Sopenharmony_ci	dpaa2_eth_trap_item->trap_ctx = trap_ctx;
1298c2ecf20Sopenharmony_ci
1308c2ecf20Sopenharmony_ci	return 0;
1318c2ecf20Sopenharmony_ci}
1328c2ecf20Sopenharmony_ci
1338c2ecf20Sopenharmony_cistatic int dpaa2_eth_dl_trap_action_set(struct devlink *devlink,
1348c2ecf20Sopenharmony_ci					const struct devlink_trap *trap,
1358c2ecf20Sopenharmony_ci					enum devlink_trap_action action,
1368c2ecf20Sopenharmony_ci					struct netlink_ext_ack *extack)
1378c2ecf20Sopenharmony_ci{
1388c2ecf20Sopenharmony_ci	/* No support for changing the action of an independent packet trap,
1398c2ecf20Sopenharmony_ci	 * only per trap group - parser error drops
1408c2ecf20Sopenharmony_ci	 */
1418c2ecf20Sopenharmony_ci	NL_SET_ERR_MSG_MOD(extack,
1428c2ecf20Sopenharmony_ci			   "Cannot change trap action independently of group");
1438c2ecf20Sopenharmony_ci	return -EOPNOTSUPP;
1448c2ecf20Sopenharmony_ci}
1458c2ecf20Sopenharmony_ci
1468c2ecf20Sopenharmony_cistatic int dpaa2_eth_dl_trap_group_action_set(struct devlink *devlink,
1478c2ecf20Sopenharmony_ci					      const struct devlink_trap_group *group,
1488c2ecf20Sopenharmony_ci					      enum devlink_trap_action action,
1498c2ecf20Sopenharmony_ci					      struct netlink_ext_ack *extack)
1508c2ecf20Sopenharmony_ci{
1518c2ecf20Sopenharmony_ci	struct dpaa2_eth_devlink_priv *dl_priv = devlink_priv(devlink);
1528c2ecf20Sopenharmony_ci	struct dpaa2_eth_priv *priv = dl_priv->dpaa2_priv;
1538c2ecf20Sopenharmony_ci	struct net_device *net_dev = priv->net_dev;
1548c2ecf20Sopenharmony_ci	struct device *dev = net_dev->dev.parent;
1558c2ecf20Sopenharmony_ci	struct dpni_error_cfg err_cfg = {0};
1568c2ecf20Sopenharmony_ci	int err;
1578c2ecf20Sopenharmony_ci
1588c2ecf20Sopenharmony_ci	if (group->id != DEVLINK_TRAP_GROUP_GENERIC_ID_PARSER_ERROR_DROPS)
1598c2ecf20Sopenharmony_ci		return -EOPNOTSUPP;
1608c2ecf20Sopenharmony_ci
1618c2ecf20Sopenharmony_ci	/* Configure handling of frames marked as errors from the parser */
1628c2ecf20Sopenharmony_ci	err_cfg.errors = DPAA2_FAS_RX_ERR_MASK;
1638c2ecf20Sopenharmony_ci	err_cfg.set_frame_annotation = 1;
1648c2ecf20Sopenharmony_ci
1658c2ecf20Sopenharmony_ci	switch (action) {
1668c2ecf20Sopenharmony_ci	case DEVLINK_TRAP_ACTION_DROP:
1678c2ecf20Sopenharmony_ci		err_cfg.error_action = DPNI_ERROR_ACTION_DISCARD;
1688c2ecf20Sopenharmony_ci		break;
1698c2ecf20Sopenharmony_ci	case DEVLINK_TRAP_ACTION_TRAP:
1708c2ecf20Sopenharmony_ci		err_cfg.error_action = DPNI_ERROR_ACTION_SEND_TO_ERROR_QUEUE;
1718c2ecf20Sopenharmony_ci		break;
1728c2ecf20Sopenharmony_ci	default:
1738c2ecf20Sopenharmony_ci		return -EOPNOTSUPP;
1748c2ecf20Sopenharmony_ci	}
1758c2ecf20Sopenharmony_ci
1768c2ecf20Sopenharmony_ci	err = dpni_set_errors_behavior(priv->mc_io, 0, priv->mc_token, &err_cfg);
1778c2ecf20Sopenharmony_ci	if (err) {
1788c2ecf20Sopenharmony_ci		dev_err(dev, "dpni_set_errors_behavior failed\n");
1798c2ecf20Sopenharmony_ci		return err;
1808c2ecf20Sopenharmony_ci	}
1818c2ecf20Sopenharmony_ci
1828c2ecf20Sopenharmony_ci	return 0;
1838c2ecf20Sopenharmony_ci}
1848c2ecf20Sopenharmony_ci
1858c2ecf20Sopenharmony_cistatic const struct devlink_ops dpaa2_eth_devlink_ops = {
1868c2ecf20Sopenharmony_ci	.info_get = dpaa2_eth_dl_info_get,
1878c2ecf20Sopenharmony_ci	.trap_init = dpaa2_eth_dl_trap_init,
1888c2ecf20Sopenharmony_ci	.trap_action_set = dpaa2_eth_dl_trap_action_set,
1898c2ecf20Sopenharmony_ci	.trap_group_action_set = dpaa2_eth_dl_trap_group_action_set,
1908c2ecf20Sopenharmony_ci};
1918c2ecf20Sopenharmony_ci
1928c2ecf20Sopenharmony_ciint dpaa2_eth_dl_register(struct dpaa2_eth_priv *priv)
1938c2ecf20Sopenharmony_ci{
1948c2ecf20Sopenharmony_ci	struct net_device *net_dev = priv->net_dev;
1958c2ecf20Sopenharmony_ci	struct device *dev = net_dev->dev.parent;
1968c2ecf20Sopenharmony_ci	struct dpaa2_eth_devlink_priv *dl_priv;
1978c2ecf20Sopenharmony_ci	int err;
1988c2ecf20Sopenharmony_ci
1998c2ecf20Sopenharmony_ci	priv->devlink = devlink_alloc(&dpaa2_eth_devlink_ops, sizeof(*dl_priv));
2008c2ecf20Sopenharmony_ci	if (!priv->devlink) {
2018c2ecf20Sopenharmony_ci		dev_err(dev, "devlink_alloc failed\n");
2028c2ecf20Sopenharmony_ci		return -ENOMEM;
2038c2ecf20Sopenharmony_ci	}
2048c2ecf20Sopenharmony_ci	dl_priv = devlink_priv(priv->devlink);
2058c2ecf20Sopenharmony_ci	dl_priv->dpaa2_priv = priv;
2068c2ecf20Sopenharmony_ci
2078c2ecf20Sopenharmony_ci	err = devlink_register(priv->devlink, dev);
2088c2ecf20Sopenharmony_ci	if (err) {
2098c2ecf20Sopenharmony_ci		dev_err(dev, "devlink_register() = %d\n", err);
2108c2ecf20Sopenharmony_ci		goto devlink_free;
2118c2ecf20Sopenharmony_ci	}
2128c2ecf20Sopenharmony_ci
2138c2ecf20Sopenharmony_ci	return 0;
2148c2ecf20Sopenharmony_ci
2158c2ecf20Sopenharmony_cidevlink_free:
2168c2ecf20Sopenharmony_ci	devlink_free(priv->devlink);
2178c2ecf20Sopenharmony_ci
2188c2ecf20Sopenharmony_ci	return err;
2198c2ecf20Sopenharmony_ci}
2208c2ecf20Sopenharmony_ci
2218c2ecf20Sopenharmony_civoid dpaa2_eth_dl_unregister(struct dpaa2_eth_priv *priv)
2228c2ecf20Sopenharmony_ci{
2238c2ecf20Sopenharmony_ci	devlink_unregister(priv->devlink);
2248c2ecf20Sopenharmony_ci	devlink_free(priv->devlink);
2258c2ecf20Sopenharmony_ci}
2268c2ecf20Sopenharmony_ci
2278c2ecf20Sopenharmony_ciint dpaa2_eth_dl_port_add(struct dpaa2_eth_priv *priv)
2288c2ecf20Sopenharmony_ci{
2298c2ecf20Sopenharmony_ci	struct devlink_port *devlink_port = &priv->devlink_port;
2308c2ecf20Sopenharmony_ci	struct devlink_port_attrs attrs = {};
2318c2ecf20Sopenharmony_ci	int err;
2328c2ecf20Sopenharmony_ci
2338c2ecf20Sopenharmony_ci	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
2348c2ecf20Sopenharmony_ci	devlink_port_attrs_set(devlink_port, &attrs);
2358c2ecf20Sopenharmony_ci
2368c2ecf20Sopenharmony_ci	err = devlink_port_register(priv->devlink, devlink_port, 0);
2378c2ecf20Sopenharmony_ci	if (err)
2388c2ecf20Sopenharmony_ci		return err;
2398c2ecf20Sopenharmony_ci
2408c2ecf20Sopenharmony_ci	devlink_port_type_eth_set(devlink_port, priv->net_dev);
2418c2ecf20Sopenharmony_ci
2428c2ecf20Sopenharmony_ci	return 0;
2438c2ecf20Sopenharmony_ci}
2448c2ecf20Sopenharmony_ci
2458c2ecf20Sopenharmony_civoid dpaa2_eth_dl_port_del(struct dpaa2_eth_priv *priv)
2468c2ecf20Sopenharmony_ci{
2478c2ecf20Sopenharmony_ci	struct devlink_port *devlink_port = &priv->devlink_port;
2488c2ecf20Sopenharmony_ci
2498c2ecf20Sopenharmony_ci	devlink_port_type_clear(devlink_port);
2508c2ecf20Sopenharmony_ci	devlink_port_unregister(devlink_port);
2518c2ecf20Sopenharmony_ci}
2528c2ecf20Sopenharmony_ci
2538c2ecf20Sopenharmony_ciint dpaa2_eth_dl_traps_register(struct dpaa2_eth_priv *priv)
2548c2ecf20Sopenharmony_ci{
2558c2ecf20Sopenharmony_ci	struct dpaa2_eth_trap_data *dpaa2_eth_trap_data;
2568c2ecf20Sopenharmony_ci	struct net_device *net_dev = priv->net_dev;
2578c2ecf20Sopenharmony_ci	struct device *dev = net_dev->dev.parent;
2588c2ecf20Sopenharmony_ci	int err;
2598c2ecf20Sopenharmony_ci
2608c2ecf20Sopenharmony_ci	dpaa2_eth_trap_data = kzalloc(sizeof(*dpaa2_eth_trap_data), GFP_KERNEL);
2618c2ecf20Sopenharmony_ci	if (!dpaa2_eth_trap_data)
2628c2ecf20Sopenharmony_ci		return -ENOMEM;
2638c2ecf20Sopenharmony_ci	priv->trap_data = dpaa2_eth_trap_data;
2648c2ecf20Sopenharmony_ci
2658c2ecf20Sopenharmony_ci	dpaa2_eth_trap_data->trap_items_arr = kcalloc(ARRAY_SIZE(dpaa2_eth_traps_arr),
2668c2ecf20Sopenharmony_ci						      sizeof(struct dpaa2_eth_trap_item),
2678c2ecf20Sopenharmony_ci						      GFP_KERNEL);
2688c2ecf20Sopenharmony_ci	if (!dpaa2_eth_trap_data->trap_items_arr) {
2698c2ecf20Sopenharmony_ci		err = -ENOMEM;
2708c2ecf20Sopenharmony_ci		goto trap_data_free;
2718c2ecf20Sopenharmony_ci	}
2728c2ecf20Sopenharmony_ci
2738c2ecf20Sopenharmony_ci	err = devlink_trap_groups_register(priv->devlink, dpaa2_eth_trap_groups_arr,
2748c2ecf20Sopenharmony_ci					   ARRAY_SIZE(dpaa2_eth_trap_groups_arr));
2758c2ecf20Sopenharmony_ci	if (err) {
2768c2ecf20Sopenharmony_ci		dev_err(dev, "devlink_trap_groups_register() = %d\n", err);
2778c2ecf20Sopenharmony_ci		goto trap_items_arr_free;
2788c2ecf20Sopenharmony_ci	}
2798c2ecf20Sopenharmony_ci
2808c2ecf20Sopenharmony_ci	err = devlink_traps_register(priv->devlink, dpaa2_eth_traps_arr,
2818c2ecf20Sopenharmony_ci				     ARRAY_SIZE(dpaa2_eth_traps_arr), priv);
2828c2ecf20Sopenharmony_ci	if (err) {
2838c2ecf20Sopenharmony_ci		dev_err(dev, "devlink_traps_register() = %d\n", err);
2848c2ecf20Sopenharmony_ci		goto trap_groups_unregiser;
2858c2ecf20Sopenharmony_ci	}
2868c2ecf20Sopenharmony_ci
2878c2ecf20Sopenharmony_ci	return 0;
2888c2ecf20Sopenharmony_ci
2898c2ecf20Sopenharmony_citrap_groups_unregiser:
2908c2ecf20Sopenharmony_ci	devlink_trap_groups_unregister(priv->devlink, dpaa2_eth_trap_groups_arr,
2918c2ecf20Sopenharmony_ci				       ARRAY_SIZE(dpaa2_eth_trap_groups_arr));
2928c2ecf20Sopenharmony_citrap_items_arr_free:
2938c2ecf20Sopenharmony_ci	kfree(dpaa2_eth_trap_data->trap_items_arr);
2948c2ecf20Sopenharmony_citrap_data_free:
2958c2ecf20Sopenharmony_ci	kfree(dpaa2_eth_trap_data);
2968c2ecf20Sopenharmony_ci	priv->trap_data = NULL;
2978c2ecf20Sopenharmony_ci
2988c2ecf20Sopenharmony_ci	return err;
2998c2ecf20Sopenharmony_ci}
3008c2ecf20Sopenharmony_ci
3018c2ecf20Sopenharmony_civoid dpaa2_eth_dl_traps_unregister(struct dpaa2_eth_priv *priv)
3028c2ecf20Sopenharmony_ci{
3038c2ecf20Sopenharmony_ci	devlink_traps_unregister(priv->devlink, dpaa2_eth_traps_arr,
3048c2ecf20Sopenharmony_ci				 ARRAY_SIZE(dpaa2_eth_traps_arr));
3058c2ecf20Sopenharmony_ci	devlink_trap_groups_unregister(priv->devlink, dpaa2_eth_trap_groups_arr,
3068c2ecf20Sopenharmony_ci				       ARRAY_SIZE(dpaa2_eth_trap_groups_arr));
3078c2ecf20Sopenharmony_ci	kfree(priv->trap_data->trap_items_arr);
3088c2ecf20Sopenharmony_ci	kfree(priv->trap_data);
3098c2ecf20Sopenharmony_ci}
310