18c2ecf20Sopenharmony_ci// SPDX-License-Identifier: GPL-2.0-only
28c2ecf20Sopenharmony_ci/*
38c2ecf20Sopenharmony_ci * Copyright (C) 2012 Red Hat
48c2ecf20Sopenharmony_ci *
58c2ecf20Sopenharmony_ci * based in parts on udlfb.c:
68c2ecf20Sopenharmony_ci * Copyright (C) 2009 Roberto De Ioris <roberto@unbit.it>
78c2ecf20Sopenharmony_ci * Copyright (C) 2009 Jaya Kumar <jayakumar.lkml@gmail.com>
88c2ecf20Sopenharmony_ci * Copyright (C) 2009 Bernie Thompson <bernie@plugable.com>
98c2ecf20Sopenharmony_ci */
108c2ecf20Sopenharmony_ci
118c2ecf20Sopenharmony_ci#include <drm/drm.h>
128c2ecf20Sopenharmony_ci#include <drm/drm_print.h>
138c2ecf20Sopenharmony_ci#include <drm/drm_probe_helper.h>
148c2ecf20Sopenharmony_ci
158c2ecf20Sopenharmony_ci#include "udl_drv.h"
168c2ecf20Sopenharmony_ci
178c2ecf20Sopenharmony_ci/* -BULK_SIZE as per usb-skeleton. Can we get full page and avoid overhead? */
188c2ecf20Sopenharmony_ci#define BULK_SIZE 512
198c2ecf20Sopenharmony_ci
208c2ecf20Sopenharmony_ci#define NR_USB_REQUEST_CHANNEL 0x12
218c2ecf20Sopenharmony_ci
228c2ecf20Sopenharmony_ci#define MAX_TRANSFER (PAGE_SIZE*16 - BULK_SIZE)
238c2ecf20Sopenharmony_ci#define WRITES_IN_FLIGHT (4)
248c2ecf20Sopenharmony_ci#define MAX_VENDOR_DESCRIPTOR_SIZE 256
258c2ecf20Sopenharmony_ci
268c2ecf20Sopenharmony_ci#define GET_URB_TIMEOUT	HZ
278c2ecf20Sopenharmony_ci#define FREE_URB_TIMEOUT (HZ*2)
288c2ecf20Sopenharmony_ci
298c2ecf20Sopenharmony_cistatic int udl_parse_vendor_descriptor(struct drm_device *dev,
308c2ecf20Sopenharmony_ci				       struct usb_device *usbdev)
318c2ecf20Sopenharmony_ci{
328c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
338c2ecf20Sopenharmony_ci	char *desc;
348c2ecf20Sopenharmony_ci	char *buf;
358c2ecf20Sopenharmony_ci	char *desc_end;
368c2ecf20Sopenharmony_ci
378c2ecf20Sopenharmony_ci	u8 total_len = 0;
388c2ecf20Sopenharmony_ci
398c2ecf20Sopenharmony_ci	buf = kzalloc(MAX_VENDOR_DESCRIPTOR_SIZE, GFP_KERNEL);
408c2ecf20Sopenharmony_ci	if (!buf)
418c2ecf20Sopenharmony_ci		return false;
428c2ecf20Sopenharmony_ci	desc = buf;
438c2ecf20Sopenharmony_ci
448c2ecf20Sopenharmony_ci	total_len = usb_get_descriptor(usbdev, 0x5f, /* vendor specific */
458c2ecf20Sopenharmony_ci				    0, desc, MAX_VENDOR_DESCRIPTOR_SIZE);
468c2ecf20Sopenharmony_ci	if (total_len > 5) {
478c2ecf20Sopenharmony_ci		DRM_INFO("vendor descriptor length:%x data:%11ph\n",
488c2ecf20Sopenharmony_ci			total_len, desc);
498c2ecf20Sopenharmony_ci
508c2ecf20Sopenharmony_ci		if ((desc[0] != total_len) || /* descriptor length */
518c2ecf20Sopenharmony_ci		    (desc[1] != 0x5f) ||   /* vendor descriptor type */
528c2ecf20Sopenharmony_ci		    (desc[2] != 0x01) ||   /* version (2 bytes) */
538c2ecf20Sopenharmony_ci		    (desc[3] != 0x00) ||
548c2ecf20Sopenharmony_ci		    (desc[4] != total_len - 2)) /* length after type */
558c2ecf20Sopenharmony_ci			goto unrecognized;
568c2ecf20Sopenharmony_ci
578c2ecf20Sopenharmony_ci		desc_end = desc + total_len;
588c2ecf20Sopenharmony_ci		desc += 5; /* the fixed header we've already parsed */
598c2ecf20Sopenharmony_ci
608c2ecf20Sopenharmony_ci		while (desc < desc_end) {
618c2ecf20Sopenharmony_ci			u8 length;
628c2ecf20Sopenharmony_ci			u16 key;
638c2ecf20Sopenharmony_ci
648c2ecf20Sopenharmony_ci			key = le16_to_cpu(*((u16 *) desc));
658c2ecf20Sopenharmony_ci			desc += sizeof(u16);
668c2ecf20Sopenharmony_ci			length = *desc;
678c2ecf20Sopenharmony_ci			desc++;
688c2ecf20Sopenharmony_ci
698c2ecf20Sopenharmony_ci			switch (key) {
708c2ecf20Sopenharmony_ci			case 0x0200: { /* max_area */
718c2ecf20Sopenharmony_ci				u32 max_area;
728c2ecf20Sopenharmony_ci				max_area = le32_to_cpu(*((u32 *)desc));
738c2ecf20Sopenharmony_ci				DRM_DEBUG("DL chip limited to %d pixel modes\n",
748c2ecf20Sopenharmony_ci					max_area);
758c2ecf20Sopenharmony_ci				udl->sku_pixel_limit = max_area;
768c2ecf20Sopenharmony_ci				break;
778c2ecf20Sopenharmony_ci			}
788c2ecf20Sopenharmony_ci			default:
798c2ecf20Sopenharmony_ci				break;
808c2ecf20Sopenharmony_ci			}
818c2ecf20Sopenharmony_ci			desc += length;
828c2ecf20Sopenharmony_ci		}
838c2ecf20Sopenharmony_ci	}
848c2ecf20Sopenharmony_ci
858c2ecf20Sopenharmony_ci	goto success;
868c2ecf20Sopenharmony_ci
878c2ecf20Sopenharmony_ciunrecognized:
888c2ecf20Sopenharmony_ci	/* allow udlfb to load for now even if firmware unrecognized */
898c2ecf20Sopenharmony_ci	DRM_ERROR("Unrecognized vendor firmware descriptor\n");
908c2ecf20Sopenharmony_ci
918c2ecf20Sopenharmony_cisuccess:
928c2ecf20Sopenharmony_ci	kfree(buf);
938c2ecf20Sopenharmony_ci	return true;
948c2ecf20Sopenharmony_ci}
958c2ecf20Sopenharmony_ci
968c2ecf20Sopenharmony_ci/*
978c2ecf20Sopenharmony_ci * Need to ensure a channel is selected before submitting URBs
988c2ecf20Sopenharmony_ci */
998c2ecf20Sopenharmony_cistatic int udl_select_std_channel(struct udl_device *udl)
1008c2ecf20Sopenharmony_ci{
1018c2ecf20Sopenharmony_ci	int ret;
1028c2ecf20Sopenharmony_ci	static const u8 set_def_chn[] = {0x57, 0xCD, 0xDC, 0xA7,
1038c2ecf20Sopenharmony_ci					 0x1C, 0x88, 0x5E, 0x15,
1048c2ecf20Sopenharmony_ci					 0x60, 0xFE, 0xC6, 0x97,
1058c2ecf20Sopenharmony_ci					 0x16, 0x3D, 0x47, 0xF2};
1068c2ecf20Sopenharmony_ci	void *sendbuf;
1078c2ecf20Sopenharmony_ci
1088c2ecf20Sopenharmony_ci	sendbuf = kmemdup(set_def_chn, sizeof(set_def_chn), GFP_KERNEL);
1098c2ecf20Sopenharmony_ci	if (!sendbuf)
1108c2ecf20Sopenharmony_ci		return -ENOMEM;
1118c2ecf20Sopenharmony_ci
1128c2ecf20Sopenharmony_ci	ret = usb_control_msg(udl->udev,
1138c2ecf20Sopenharmony_ci			      usb_sndctrlpipe(udl->udev, 0),
1148c2ecf20Sopenharmony_ci			      NR_USB_REQUEST_CHANNEL,
1158c2ecf20Sopenharmony_ci			      (USB_DIR_OUT | USB_TYPE_VENDOR), 0, 0,
1168c2ecf20Sopenharmony_ci			      sendbuf, sizeof(set_def_chn),
1178c2ecf20Sopenharmony_ci			      USB_CTRL_SET_TIMEOUT);
1188c2ecf20Sopenharmony_ci	kfree(sendbuf);
1198c2ecf20Sopenharmony_ci	return ret < 0 ? ret : 0;
1208c2ecf20Sopenharmony_ci}
1218c2ecf20Sopenharmony_ci
1228c2ecf20Sopenharmony_cistatic void udl_release_urb_work(struct work_struct *work)
1238c2ecf20Sopenharmony_ci{
1248c2ecf20Sopenharmony_ci	struct urb_node *unode = container_of(work, struct urb_node,
1258c2ecf20Sopenharmony_ci					      release_urb_work.work);
1268c2ecf20Sopenharmony_ci
1278c2ecf20Sopenharmony_ci	up(&unode->dev->urbs.limit_sem);
1288c2ecf20Sopenharmony_ci}
1298c2ecf20Sopenharmony_ci
1308c2ecf20Sopenharmony_civoid udl_urb_completion(struct urb *urb)
1318c2ecf20Sopenharmony_ci{
1328c2ecf20Sopenharmony_ci	struct urb_node *unode = urb->context;
1338c2ecf20Sopenharmony_ci	struct udl_device *udl = unode->dev;
1348c2ecf20Sopenharmony_ci	unsigned long flags;
1358c2ecf20Sopenharmony_ci
1368c2ecf20Sopenharmony_ci	/* sync/async unlink faults aren't errors */
1378c2ecf20Sopenharmony_ci	if (urb->status) {
1388c2ecf20Sopenharmony_ci		if (!(urb->status == -ENOENT ||
1398c2ecf20Sopenharmony_ci		    urb->status == -ECONNRESET ||
1408c2ecf20Sopenharmony_ci		    urb->status == -ESHUTDOWN)) {
1418c2ecf20Sopenharmony_ci			DRM_ERROR("%s - nonzero write bulk status received: %d\n",
1428c2ecf20Sopenharmony_ci				__func__, urb->status);
1438c2ecf20Sopenharmony_ci		}
1448c2ecf20Sopenharmony_ci	}
1458c2ecf20Sopenharmony_ci
1468c2ecf20Sopenharmony_ci	urb->transfer_buffer_length = udl->urbs.size; /* reset to actual */
1478c2ecf20Sopenharmony_ci
1488c2ecf20Sopenharmony_ci	spin_lock_irqsave(&udl->urbs.lock, flags);
1498c2ecf20Sopenharmony_ci	list_add_tail(&unode->entry, &udl->urbs.list);
1508c2ecf20Sopenharmony_ci	udl->urbs.available++;
1518c2ecf20Sopenharmony_ci	spin_unlock_irqrestore(&udl->urbs.lock, flags);
1528c2ecf20Sopenharmony_ci
1538c2ecf20Sopenharmony_ci#if 0
1548c2ecf20Sopenharmony_ci	/*
1558c2ecf20Sopenharmony_ci	 * When using fb_defio, we deadlock if up() is called
1568c2ecf20Sopenharmony_ci	 * while another is waiting. So queue to another process.
1578c2ecf20Sopenharmony_ci	 */
1588c2ecf20Sopenharmony_ci	if (fb_defio)
1598c2ecf20Sopenharmony_ci		schedule_delayed_work(&unode->release_urb_work, 0);
1608c2ecf20Sopenharmony_ci	else
1618c2ecf20Sopenharmony_ci#endif
1628c2ecf20Sopenharmony_ci		up(&udl->urbs.limit_sem);
1638c2ecf20Sopenharmony_ci}
1648c2ecf20Sopenharmony_ci
1658c2ecf20Sopenharmony_cistatic void udl_free_urb_list(struct drm_device *dev)
1668c2ecf20Sopenharmony_ci{
1678c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
1688c2ecf20Sopenharmony_ci	int count = udl->urbs.count;
1698c2ecf20Sopenharmony_ci	struct list_head *node;
1708c2ecf20Sopenharmony_ci	struct urb_node *unode;
1718c2ecf20Sopenharmony_ci	struct urb *urb;
1728c2ecf20Sopenharmony_ci
1738c2ecf20Sopenharmony_ci	DRM_DEBUG("Waiting for completes and freeing all render urbs\n");
1748c2ecf20Sopenharmony_ci
1758c2ecf20Sopenharmony_ci	/* keep waiting and freeing, until we've got 'em all */
1768c2ecf20Sopenharmony_ci	while (count--) {
1778c2ecf20Sopenharmony_ci		down(&udl->urbs.limit_sem);
1788c2ecf20Sopenharmony_ci
1798c2ecf20Sopenharmony_ci		spin_lock_irq(&udl->urbs.lock);
1808c2ecf20Sopenharmony_ci
1818c2ecf20Sopenharmony_ci		node = udl->urbs.list.next; /* have reserved one with sem */
1828c2ecf20Sopenharmony_ci		list_del_init(node);
1838c2ecf20Sopenharmony_ci
1848c2ecf20Sopenharmony_ci		spin_unlock_irq(&udl->urbs.lock);
1858c2ecf20Sopenharmony_ci
1868c2ecf20Sopenharmony_ci		unode = list_entry(node, struct urb_node, entry);
1878c2ecf20Sopenharmony_ci		urb = unode->urb;
1888c2ecf20Sopenharmony_ci
1898c2ecf20Sopenharmony_ci		/* Free each separately allocated piece */
1908c2ecf20Sopenharmony_ci		usb_free_coherent(urb->dev, udl->urbs.size,
1918c2ecf20Sopenharmony_ci				  urb->transfer_buffer, urb->transfer_dma);
1928c2ecf20Sopenharmony_ci		usb_free_urb(urb);
1938c2ecf20Sopenharmony_ci		kfree(node);
1948c2ecf20Sopenharmony_ci	}
1958c2ecf20Sopenharmony_ci	udl->urbs.count = 0;
1968c2ecf20Sopenharmony_ci}
1978c2ecf20Sopenharmony_ci
1988c2ecf20Sopenharmony_cistatic int udl_alloc_urb_list(struct drm_device *dev, int count, size_t size)
1998c2ecf20Sopenharmony_ci{
2008c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
2018c2ecf20Sopenharmony_ci	struct urb *urb;
2028c2ecf20Sopenharmony_ci	struct urb_node *unode;
2038c2ecf20Sopenharmony_ci	char *buf;
2048c2ecf20Sopenharmony_ci	size_t wanted_size = count * size;
2058c2ecf20Sopenharmony_ci
2068c2ecf20Sopenharmony_ci	spin_lock_init(&udl->urbs.lock);
2078c2ecf20Sopenharmony_ci
2088c2ecf20Sopenharmony_ciretry:
2098c2ecf20Sopenharmony_ci	udl->urbs.size = size;
2108c2ecf20Sopenharmony_ci	INIT_LIST_HEAD(&udl->urbs.list);
2118c2ecf20Sopenharmony_ci
2128c2ecf20Sopenharmony_ci	sema_init(&udl->urbs.limit_sem, 0);
2138c2ecf20Sopenharmony_ci	udl->urbs.count = 0;
2148c2ecf20Sopenharmony_ci	udl->urbs.available = 0;
2158c2ecf20Sopenharmony_ci
2168c2ecf20Sopenharmony_ci	while (udl->urbs.count * size < wanted_size) {
2178c2ecf20Sopenharmony_ci		unode = kzalloc(sizeof(struct urb_node), GFP_KERNEL);
2188c2ecf20Sopenharmony_ci		if (!unode)
2198c2ecf20Sopenharmony_ci			break;
2208c2ecf20Sopenharmony_ci		unode->dev = udl;
2218c2ecf20Sopenharmony_ci
2228c2ecf20Sopenharmony_ci		INIT_DELAYED_WORK(&unode->release_urb_work,
2238c2ecf20Sopenharmony_ci			  udl_release_urb_work);
2248c2ecf20Sopenharmony_ci
2258c2ecf20Sopenharmony_ci		urb = usb_alloc_urb(0, GFP_KERNEL);
2268c2ecf20Sopenharmony_ci		if (!urb) {
2278c2ecf20Sopenharmony_ci			kfree(unode);
2288c2ecf20Sopenharmony_ci			break;
2298c2ecf20Sopenharmony_ci		}
2308c2ecf20Sopenharmony_ci		unode->urb = urb;
2318c2ecf20Sopenharmony_ci
2328c2ecf20Sopenharmony_ci		buf = usb_alloc_coherent(udl->udev, size, GFP_KERNEL,
2338c2ecf20Sopenharmony_ci					 &urb->transfer_dma);
2348c2ecf20Sopenharmony_ci		if (!buf) {
2358c2ecf20Sopenharmony_ci			kfree(unode);
2368c2ecf20Sopenharmony_ci			usb_free_urb(urb);
2378c2ecf20Sopenharmony_ci			if (size > PAGE_SIZE) {
2388c2ecf20Sopenharmony_ci				size /= 2;
2398c2ecf20Sopenharmony_ci				udl_free_urb_list(dev);
2408c2ecf20Sopenharmony_ci				goto retry;
2418c2ecf20Sopenharmony_ci			}
2428c2ecf20Sopenharmony_ci			break;
2438c2ecf20Sopenharmony_ci		}
2448c2ecf20Sopenharmony_ci
2458c2ecf20Sopenharmony_ci		/* urb->transfer_buffer_length set to actual before submit */
2468c2ecf20Sopenharmony_ci		usb_fill_bulk_urb(urb, udl->udev, usb_sndbulkpipe(udl->udev, 1),
2478c2ecf20Sopenharmony_ci			buf, size, udl_urb_completion, unode);
2488c2ecf20Sopenharmony_ci		urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
2498c2ecf20Sopenharmony_ci
2508c2ecf20Sopenharmony_ci		list_add_tail(&unode->entry, &udl->urbs.list);
2518c2ecf20Sopenharmony_ci
2528c2ecf20Sopenharmony_ci		up(&udl->urbs.limit_sem);
2538c2ecf20Sopenharmony_ci		udl->urbs.count++;
2548c2ecf20Sopenharmony_ci		udl->urbs.available++;
2558c2ecf20Sopenharmony_ci	}
2568c2ecf20Sopenharmony_ci
2578c2ecf20Sopenharmony_ci	DRM_DEBUG("allocated %d %d byte urbs\n", udl->urbs.count, (int) size);
2588c2ecf20Sopenharmony_ci
2598c2ecf20Sopenharmony_ci	return udl->urbs.count;
2608c2ecf20Sopenharmony_ci}
2618c2ecf20Sopenharmony_ci
2628c2ecf20Sopenharmony_cistruct urb *udl_get_urb(struct drm_device *dev)
2638c2ecf20Sopenharmony_ci{
2648c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
2658c2ecf20Sopenharmony_ci	int ret = 0;
2668c2ecf20Sopenharmony_ci	struct list_head *entry;
2678c2ecf20Sopenharmony_ci	struct urb_node *unode;
2688c2ecf20Sopenharmony_ci	struct urb *urb = NULL;
2698c2ecf20Sopenharmony_ci
2708c2ecf20Sopenharmony_ci	/* Wait for an in-flight buffer to complete and get re-queued */
2718c2ecf20Sopenharmony_ci	ret = down_timeout(&udl->urbs.limit_sem, GET_URB_TIMEOUT);
2728c2ecf20Sopenharmony_ci	if (ret) {
2738c2ecf20Sopenharmony_ci		DRM_INFO("wait for urb interrupted: %x available: %d\n",
2748c2ecf20Sopenharmony_ci		       ret, udl->urbs.available);
2758c2ecf20Sopenharmony_ci		goto error;
2768c2ecf20Sopenharmony_ci	}
2778c2ecf20Sopenharmony_ci
2788c2ecf20Sopenharmony_ci	spin_lock_irq(&udl->urbs.lock);
2798c2ecf20Sopenharmony_ci
2808c2ecf20Sopenharmony_ci	BUG_ON(list_empty(&udl->urbs.list)); /* reserved one with limit_sem */
2818c2ecf20Sopenharmony_ci	entry = udl->urbs.list.next;
2828c2ecf20Sopenharmony_ci	list_del_init(entry);
2838c2ecf20Sopenharmony_ci	udl->urbs.available--;
2848c2ecf20Sopenharmony_ci
2858c2ecf20Sopenharmony_ci	spin_unlock_irq(&udl->urbs.lock);
2868c2ecf20Sopenharmony_ci
2878c2ecf20Sopenharmony_ci	unode = list_entry(entry, struct urb_node, entry);
2888c2ecf20Sopenharmony_ci	urb = unode->urb;
2898c2ecf20Sopenharmony_ci
2908c2ecf20Sopenharmony_cierror:
2918c2ecf20Sopenharmony_ci	return urb;
2928c2ecf20Sopenharmony_ci}
2938c2ecf20Sopenharmony_ci
2948c2ecf20Sopenharmony_ciint udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
2958c2ecf20Sopenharmony_ci{
2968c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
2978c2ecf20Sopenharmony_ci	int ret;
2988c2ecf20Sopenharmony_ci
2998c2ecf20Sopenharmony_ci	BUG_ON(len > udl->urbs.size);
3008c2ecf20Sopenharmony_ci
3018c2ecf20Sopenharmony_ci	urb->transfer_buffer_length = len; /* set to actual payload len */
3028c2ecf20Sopenharmony_ci	ret = usb_submit_urb(urb, GFP_ATOMIC);
3038c2ecf20Sopenharmony_ci	if (ret) {
3048c2ecf20Sopenharmony_ci		udl_urb_completion(urb); /* because no one else will */
3058c2ecf20Sopenharmony_ci		DRM_ERROR("usb_submit_urb error %x\n", ret);
3068c2ecf20Sopenharmony_ci	}
3078c2ecf20Sopenharmony_ci	return ret;
3088c2ecf20Sopenharmony_ci}
3098c2ecf20Sopenharmony_ci
3108c2ecf20Sopenharmony_ciint udl_init(struct udl_device *udl)
3118c2ecf20Sopenharmony_ci{
3128c2ecf20Sopenharmony_ci	struct drm_device *dev = &udl->drm;
3138c2ecf20Sopenharmony_ci	int ret = -ENOMEM;
3148c2ecf20Sopenharmony_ci
3158c2ecf20Sopenharmony_ci	DRM_DEBUG("\n");
3168c2ecf20Sopenharmony_ci
3178c2ecf20Sopenharmony_ci	udl->dmadev = usb_intf_get_dma_device(to_usb_interface(dev->dev));
3188c2ecf20Sopenharmony_ci	if (!udl->dmadev)
3198c2ecf20Sopenharmony_ci		drm_warn(dev, "buffer sharing not supported"); /* not an error */
3208c2ecf20Sopenharmony_ci
3218c2ecf20Sopenharmony_ci	mutex_init(&udl->gem_lock);
3228c2ecf20Sopenharmony_ci
3238c2ecf20Sopenharmony_ci	if (!udl_parse_vendor_descriptor(dev, udl->udev)) {
3248c2ecf20Sopenharmony_ci		ret = -ENODEV;
3258c2ecf20Sopenharmony_ci		DRM_ERROR("firmware not recognized. Assume incompatible device\n");
3268c2ecf20Sopenharmony_ci		goto err;
3278c2ecf20Sopenharmony_ci	}
3288c2ecf20Sopenharmony_ci
3298c2ecf20Sopenharmony_ci	if (udl_select_std_channel(udl))
3308c2ecf20Sopenharmony_ci		DRM_ERROR("Selecting channel failed\n");
3318c2ecf20Sopenharmony_ci
3328c2ecf20Sopenharmony_ci	if (!udl_alloc_urb_list(dev, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
3338c2ecf20Sopenharmony_ci		DRM_ERROR("udl_alloc_urb_list failed\n");
3348c2ecf20Sopenharmony_ci		goto err;
3358c2ecf20Sopenharmony_ci	}
3368c2ecf20Sopenharmony_ci
3378c2ecf20Sopenharmony_ci	DRM_DEBUG("\n");
3388c2ecf20Sopenharmony_ci	ret = udl_modeset_init(dev);
3398c2ecf20Sopenharmony_ci	if (ret)
3408c2ecf20Sopenharmony_ci		goto err;
3418c2ecf20Sopenharmony_ci
3428c2ecf20Sopenharmony_ci	drm_kms_helper_poll_init(dev);
3438c2ecf20Sopenharmony_ci
3448c2ecf20Sopenharmony_ci	return 0;
3458c2ecf20Sopenharmony_ci
3468c2ecf20Sopenharmony_cierr:
3478c2ecf20Sopenharmony_ci	if (udl->urbs.count)
3488c2ecf20Sopenharmony_ci		udl_free_urb_list(dev);
3498c2ecf20Sopenharmony_ci	put_device(udl->dmadev);
3508c2ecf20Sopenharmony_ci	DRM_ERROR("%d\n", ret);
3518c2ecf20Sopenharmony_ci	return ret;
3528c2ecf20Sopenharmony_ci}
3538c2ecf20Sopenharmony_ci
3548c2ecf20Sopenharmony_ciint udl_drop_usb(struct drm_device *dev)
3558c2ecf20Sopenharmony_ci{
3568c2ecf20Sopenharmony_ci	struct udl_device *udl = to_udl(dev);
3578c2ecf20Sopenharmony_ci
3588c2ecf20Sopenharmony_ci	udl_free_urb_list(dev);
3598c2ecf20Sopenharmony_ci	put_device(udl->dmadev);
3608c2ecf20Sopenharmony_ci	udl->dmadev = NULL;
3618c2ecf20Sopenharmony_ci
3628c2ecf20Sopenharmony_ci	return 0;
3638c2ecf20Sopenharmony_ci}
364