1// SPDX-License-Identifier: GPL-2.0-only 2/* 3 * Copyright © 2006-2011 Intel Corporation 4 * 5 * Authors: 6 * Eric Anholt <eric@anholt.net> 7 * Dave Airlie <airlied@linux.ie> 8 * Jesse Barnes <jesse.barnes@intel.com> 9 */ 10 11#include <linux/dmi.h> 12#include <linux/i2c.h> 13#include <linux/pm_runtime.h> 14 15#include <drm/drm_simple_kms_helper.h> 16 17#include "cdv_device.h" 18#include "intel_bios.h" 19#include "power.h" 20#include "psb_drv.h" 21#include "psb_intel_drv.h" 22#include "psb_intel_reg.h" 23 24/** 25 * LVDS I2C backlight control macros 26 */ 27#define BRIGHTNESS_MAX_LEVEL 100 28#define BRIGHTNESS_MASK 0xFF 29#define BLC_I2C_TYPE 0x01 30#define BLC_PWM_TYPT 0x02 31 32#define BLC_POLARITY_NORMAL 0 33#define BLC_POLARITY_INVERSE 1 34 35#define PSB_BLC_MAX_PWM_REG_FREQ (0xFFFE) 36#define PSB_BLC_MIN_PWM_REG_FREQ (0x2) 37#define PSB_BLC_PWM_PRECISION_FACTOR (10) 38#define PSB_BACKLIGHT_PWM_CTL_SHIFT (16) 39#define PSB_BACKLIGHT_PWM_POLARITY_BIT_CLEAR (0xFFFE) 40 41struct cdv_intel_lvds_priv { 42 /** 43 * Saved LVDO output states 44 */ 45 uint32_t savePP_ON; 46 uint32_t savePP_OFF; 47 uint32_t saveLVDS; 48 uint32_t savePP_CONTROL; 49 uint32_t savePP_CYCLE; 50 uint32_t savePFIT_CONTROL; 51 uint32_t savePFIT_PGM_RATIOS; 52 uint32_t saveBLC_PWM_CTL; 53}; 54 55/* 56 * Returns the maximum level of the backlight duty cycle field. 57 */ 58static u32 cdv_intel_lvds_get_max_backlight(struct drm_device *dev) 59{ 60 struct drm_psb_private *dev_priv = dev->dev_private; 61 u32 retval; 62 63 if (gma_power_begin(dev, false)) { 64 retval = ((REG_READ(BLC_PWM_CTL) & 65 BACKLIGHT_MODULATION_FREQ_MASK) >> 66 BACKLIGHT_MODULATION_FREQ_SHIFT) * 2; 67 68 gma_power_end(dev); 69 } else 70 retval = ((dev_priv->regs.saveBLC_PWM_CTL & 71 BACKLIGHT_MODULATION_FREQ_MASK) >> 72 BACKLIGHT_MODULATION_FREQ_SHIFT) * 2; 73 74 return retval; 75} 76 77/** 78 * Sets the backlight level. 79 * 80 * level backlight level, from 0 to cdv_intel_lvds_get_max_backlight(). 81 */ 82static void cdv_intel_lvds_set_backlight(struct drm_device *dev, int level) 83{ 84 struct drm_psb_private *dev_priv = dev->dev_private; 85 u32 blc_pwm_ctl; 86 87 if (gma_power_begin(dev, false)) { 88 blc_pwm_ctl = 89 REG_READ(BLC_PWM_CTL) & ~BACKLIGHT_DUTY_CYCLE_MASK; 90 REG_WRITE(BLC_PWM_CTL, 91 (blc_pwm_ctl | 92 (level << BACKLIGHT_DUTY_CYCLE_SHIFT))); 93 gma_power_end(dev); 94 } else { 95 blc_pwm_ctl = dev_priv->regs.saveBLC_PWM_CTL & 96 ~BACKLIGHT_DUTY_CYCLE_MASK; 97 dev_priv->regs.saveBLC_PWM_CTL = (blc_pwm_ctl | 98 (level << BACKLIGHT_DUTY_CYCLE_SHIFT)); 99 } 100} 101 102/** 103 * Sets the power state for the panel. 104 */ 105static void cdv_intel_lvds_set_power(struct drm_device *dev, 106 struct drm_encoder *encoder, bool on) 107{ 108 struct drm_psb_private *dev_priv = dev->dev_private; 109 u32 pp_status; 110 111 if (!gma_power_begin(dev, true)) 112 return; 113 114 if (on) { 115 REG_WRITE(PP_CONTROL, REG_READ(PP_CONTROL) | 116 POWER_TARGET_ON); 117 do { 118 pp_status = REG_READ(PP_STATUS); 119 } while ((pp_status & PP_ON) == 0); 120 121 cdv_intel_lvds_set_backlight(dev, 122 dev_priv->mode_dev.backlight_duty_cycle); 123 } else { 124 cdv_intel_lvds_set_backlight(dev, 0); 125 126 REG_WRITE(PP_CONTROL, REG_READ(PP_CONTROL) & 127 ~POWER_TARGET_ON); 128 do { 129 pp_status = REG_READ(PP_STATUS); 130 } while (pp_status & PP_ON); 131 } 132 gma_power_end(dev); 133} 134 135static void cdv_intel_lvds_encoder_dpms(struct drm_encoder *encoder, int mode) 136{ 137 struct drm_device *dev = encoder->dev; 138 if (mode == DRM_MODE_DPMS_ON) 139 cdv_intel_lvds_set_power(dev, encoder, true); 140 else 141 cdv_intel_lvds_set_power(dev, encoder, false); 142 /* XXX: We never power down the LVDS pairs. */ 143} 144 145static void cdv_intel_lvds_save(struct drm_connector *connector) 146{ 147} 148 149static void cdv_intel_lvds_restore(struct drm_connector *connector) 150{ 151} 152 153static enum drm_mode_status cdv_intel_lvds_mode_valid(struct drm_connector *connector, 154 struct drm_display_mode *mode) 155{ 156 struct drm_device *dev = connector->dev; 157 struct drm_psb_private *dev_priv = dev->dev_private; 158 struct drm_display_mode *fixed_mode = 159 dev_priv->mode_dev.panel_fixed_mode; 160 161 /* just in case */ 162 if (mode->flags & DRM_MODE_FLAG_DBLSCAN) 163 return MODE_NO_DBLESCAN; 164 165 /* just in case */ 166 if (mode->flags & DRM_MODE_FLAG_INTERLACE) 167 return MODE_NO_INTERLACE; 168 169 if (fixed_mode) { 170 if (mode->hdisplay > fixed_mode->hdisplay) 171 return MODE_PANEL; 172 if (mode->vdisplay > fixed_mode->vdisplay) 173 return MODE_PANEL; 174 } 175 return MODE_OK; 176} 177 178static bool cdv_intel_lvds_mode_fixup(struct drm_encoder *encoder, 179 const struct drm_display_mode *mode, 180 struct drm_display_mode *adjusted_mode) 181{ 182 struct drm_device *dev = encoder->dev; 183 struct drm_psb_private *dev_priv = dev->dev_private; 184 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev; 185 struct drm_encoder *tmp_encoder; 186 struct drm_display_mode *panel_fixed_mode = mode_dev->panel_fixed_mode; 187 188 /* Should never happen!! */ 189 list_for_each_entry(tmp_encoder, &dev->mode_config.encoder_list, 190 head) { 191 if (tmp_encoder != encoder 192 && tmp_encoder->crtc == encoder->crtc) { 193 pr_err("Can't enable LVDS and another encoder on the same pipe\n"); 194 return false; 195 } 196 } 197 198 /* 199 * If we have timings from the BIOS for the panel, put them in 200 * to the adjusted mode. The CRTC will be set up for this mode, 201 * with the panel scaling set up to source from the H/VDisplay 202 * of the original mode. 203 */ 204 if (panel_fixed_mode != NULL) { 205 adjusted_mode->hdisplay = panel_fixed_mode->hdisplay; 206 adjusted_mode->hsync_start = panel_fixed_mode->hsync_start; 207 adjusted_mode->hsync_end = panel_fixed_mode->hsync_end; 208 adjusted_mode->htotal = panel_fixed_mode->htotal; 209 adjusted_mode->vdisplay = panel_fixed_mode->vdisplay; 210 adjusted_mode->vsync_start = panel_fixed_mode->vsync_start; 211 adjusted_mode->vsync_end = panel_fixed_mode->vsync_end; 212 adjusted_mode->vtotal = panel_fixed_mode->vtotal; 213 adjusted_mode->clock = panel_fixed_mode->clock; 214 drm_mode_set_crtcinfo(adjusted_mode, 215 CRTC_INTERLACE_HALVE_V); 216 } 217 218 /* 219 * XXX: It would be nice to support lower refresh rates on the 220 * panels to reduce power consumption, and perhaps match the 221 * user's requested refresh rate. 222 */ 223 224 return true; 225} 226 227static void cdv_intel_lvds_prepare(struct drm_encoder *encoder) 228{ 229 struct drm_device *dev = encoder->dev; 230 struct drm_psb_private *dev_priv = dev->dev_private; 231 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev; 232 233 if (!gma_power_begin(dev, true)) 234 return; 235 236 mode_dev->saveBLC_PWM_CTL = REG_READ(BLC_PWM_CTL); 237 mode_dev->backlight_duty_cycle = (mode_dev->saveBLC_PWM_CTL & 238 BACKLIGHT_DUTY_CYCLE_MASK); 239 240 cdv_intel_lvds_set_power(dev, encoder, false); 241 242 gma_power_end(dev); 243} 244 245static void cdv_intel_lvds_commit(struct drm_encoder *encoder) 246{ 247 struct drm_device *dev = encoder->dev; 248 struct drm_psb_private *dev_priv = dev->dev_private; 249 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev; 250 251 if (mode_dev->backlight_duty_cycle == 0) 252 mode_dev->backlight_duty_cycle = 253 cdv_intel_lvds_get_max_backlight(dev); 254 255 cdv_intel_lvds_set_power(dev, encoder, true); 256} 257 258static void cdv_intel_lvds_mode_set(struct drm_encoder *encoder, 259 struct drm_display_mode *mode, 260 struct drm_display_mode *adjusted_mode) 261{ 262 struct drm_device *dev = encoder->dev; 263 struct drm_psb_private *dev_priv = dev->dev_private; 264 struct gma_crtc *gma_crtc = to_gma_crtc(encoder->crtc); 265 u32 pfit_control; 266 267 /* 268 * The LVDS pin pair will already have been turned on in the 269 * cdv_intel_crtc_mode_set since it has a large impact on the DPLL 270 * settings. 271 */ 272 273 /* 274 * Enable automatic panel scaling so that non-native modes fill the 275 * screen. Should be enabled before the pipe is enabled, according to 276 * register description and PRM. 277 */ 278 if (mode->hdisplay != adjusted_mode->hdisplay || 279 mode->vdisplay != adjusted_mode->vdisplay) 280 pfit_control = (PFIT_ENABLE | VERT_AUTO_SCALE | 281 HORIZ_AUTO_SCALE | VERT_INTERP_BILINEAR | 282 HORIZ_INTERP_BILINEAR); 283 else 284 pfit_control = 0; 285 286 pfit_control |= gma_crtc->pipe << PFIT_PIPE_SHIFT; 287 288 if (dev_priv->lvds_dither) 289 pfit_control |= PANEL_8TO6_DITHER_ENABLE; 290 291 REG_WRITE(PFIT_CONTROL, pfit_control); 292} 293 294/** 295 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise. 296 */ 297static int cdv_intel_lvds_get_modes(struct drm_connector *connector) 298{ 299 struct drm_device *dev = connector->dev; 300 struct drm_psb_private *dev_priv = dev->dev_private; 301 struct gma_encoder *gma_encoder = gma_attached_encoder(connector); 302 struct psb_intel_mode_device *mode_dev = &dev_priv->mode_dev; 303 int ret; 304 305 ret = psb_intel_ddc_get_modes(connector, &gma_encoder->i2c_bus->adapter); 306 307 if (ret) 308 return ret; 309 310 if (mode_dev->panel_fixed_mode != NULL) { 311 struct drm_display_mode *mode = 312 drm_mode_duplicate(dev, mode_dev->panel_fixed_mode); 313 if (!mode) 314 return 0; 315 316 drm_mode_probed_add(connector, mode); 317 return 1; 318 } 319 320 return 0; 321} 322 323/** 324 * cdv_intel_lvds_destroy - unregister and free LVDS structures 325 * @connector: connector to free 326 * 327 * Unregister the DDC bus for this connector then free the driver private 328 * structure. 329 */ 330static void cdv_intel_lvds_destroy(struct drm_connector *connector) 331{ 332 struct gma_encoder *gma_encoder = gma_attached_encoder(connector); 333 334 psb_intel_i2c_destroy(gma_encoder->i2c_bus); 335 drm_connector_unregister(connector); 336 drm_connector_cleanup(connector); 337 kfree(connector); 338} 339 340static int cdv_intel_lvds_set_property(struct drm_connector *connector, 341 struct drm_property *property, 342 uint64_t value) 343{ 344 struct drm_encoder *encoder = connector->encoder; 345 346 if (!strcmp(property->name, "scaling mode") && encoder) { 347 struct gma_crtc *crtc = to_gma_crtc(encoder->crtc); 348 uint64_t curValue; 349 350 if (!crtc) 351 return -1; 352 353 switch (value) { 354 case DRM_MODE_SCALE_FULLSCREEN: 355 break; 356 case DRM_MODE_SCALE_NO_SCALE: 357 break; 358 case DRM_MODE_SCALE_ASPECT: 359 break; 360 default: 361 return -1; 362 } 363 364 if (drm_object_property_get_value(&connector->base, 365 property, 366 &curValue)) 367 return -1; 368 369 if (curValue == value) 370 return 0; 371 372 if (drm_object_property_set_value(&connector->base, 373 property, 374 value)) 375 return -1; 376 377 if (crtc->saved_mode.hdisplay != 0 && 378 crtc->saved_mode.vdisplay != 0) { 379 if (!drm_crtc_helper_set_mode(encoder->crtc, 380 &crtc->saved_mode, 381 encoder->crtc->x, 382 encoder->crtc->y, 383 encoder->crtc->primary->fb)) 384 return -1; 385 } 386 } else if (!strcmp(property->name, "backlight") && encoder) { 387 if (drm_object_property_set_value(&connector->base, 388 property, 389 value)) 390 return -1; 391 else 392 gma_backlight_set(encoder->dev, value); 393 } else if (!strcmp(property->name, "DPMS") && encoder) { 394 const struct drm_encoder_helper_funcs *helpers = 395 encoder->helper_private; 396 helpers->dpms(encoder, value); 397 } 398 return 0; 399} 400 401static const struct drm_encoder_helper_funcs 402 cdv_intel_lvds_helper_funcs = { 403 .dpms = cdv_intel_lvds_encoder_dpms, 404 .mode_fixup = cdv_intel_lvds_mode_fixup, 405 .prepare = cdv_intel_lvds_prepare, 406 .mode_set = cdv_intel_lvds_mode_set, 407 .commit = cdv_intel_lvds_commit, 408}; 409 410static const struct drm_connector_helper_funcs 411 cdv_intel_lvds_connector_helper_funcs = { 412 .get_modes = cdv_intel_lvds_get_modes, 413 .mode_valid = cdv_intel_lvds_mode_valid, 414 .best_encoder = gma_best_encoder, 415}; 416 417static const struct drm_connector_funcs cdv_intel_lvds_connector_funcs = { 418 .dpms = drm_helper_connector_dpms, 419 .fill_modes = drm_helper_probe_single_connector_modes, 420 .set_property = cdv_intel_lvds_set_property, 421 .destroy = cdv_intel_lvds_destroy, 422}; 423 424/* 425 * Enumerate the child dev array parsed from VBT to check whether 426 * the LVDS is present. 427 * If it is present, return 1. 428 * If it is not present, return false. 429 * If no child dev is parsed from VBT, it assumes that the LVDS is present. 430 */ 431static bool lvds_is_present_in_vbt(struct drm_device *dev, 432 u8 *i2c_pin) 433{ 434 struct drm_psb_private *dev_priv = dev->dev_private; 435 int i; 436 437 if (!dev_priv->child_dev_num) 438 return true; 439 440 for (i = 0; i < dev_priv->child_dev_num; i++) { 441 struct child_device_config *child = dev_priv->child_dev + i; 442 443 /* If the device type is not LFP, continue. 444 * We have to check both the new identifiers as well as the 445 * old for compatibility with some BIOSes. 446 */ 447 if (child->device_type != DEVICE_TYPE_INT_LFP && 448 child->device_type != DEVICE_TYPE_LFP) 449 continue; 450 451 if (child->i2c_pin) 452 *i2c_pin = child->i2c_pin; 453 454 /* However, we cannot trust the BIOS writers to populate 455 * the VBT correctly. Since LVDS requires additional 456 * information from AIM blocks, a non-zero addin offset is 457 * a good indicator that the LVDS is actually present. 458 */ 459 if (child->addin_offset) 460 return true; 461 462 /* But even then some BIOS writers perform some black magic 463 * and instantiate the device without reference to any 464 * additional data. Trust that if the VBT was written into 465 * the OpRegion then they have validated the LVDS's existence. 466 */ 467 if (dev_priv->opregion.vbt) 468 return true; 469 } 470 471 return false; 472} 473 474/** 475 * cdv_intel_lvds_init - setup LVDS connectors on this device 476 * @dev: drm device 477 * 478 * Create the connector, register the LVDS DDC bus, and try to figure out what 479 * modes we can display on the LVDS panel (if present). 480 */ 481void cdv_intel_lvds_init(struct drm_device *dev, 482 struct psb_intel_mode_device *mode_dev) 483{ 484 struct gma_encoder *gma_encoder; 485 struct gma_connector *gma_connector; 486 struct cdv_intel_lvds_priv *lvds_priv; 487 struct drm_connector *connector; 488 struct drm_encoder *encoder; 489 struct drm_display_mode *scan; 490 struct drm_crtc *crtc; 491 struct drm_psb_private *dev_priv = dev->dev_private; 492 u32 lvds; 493 int pipe; 494 u8 pin; 495 496 if (!dev_priv->lvds_enabled_in_vbt) 497 return; 498 499 pin = GMBUS_PORT_PANEL; 500 if (!lvds_is_present_in_vbt(dev, &pin)) { 501 DRM_DEBUG_KMS("LVDS is not present in VBT\n"); 502 return; 503 } 504 505 gma_encoder = kzalloc(sizeof(struct gma_encoder), 506 GFP_KERNEL); 507 if (!gma_encoder) 508 return; 509 510 gma_connector = kzalloc(sizeof(struct gma_connector), 511 GFP_KERNEL); 512 if (!gma_connector) 513 goto failed_connector; 514 515 lvds_priv = kzalloc(sizeof(struct cdv_intel_lvds_priv), GFP_KERNEL); 516 if (!lvds_priv) 517 goto failed_lvds_priv; 518 519 gma_encoder->dev_priv = lvds_priv; 520 521 connector = &gma_connector->base; 522 gma_connector->save = cdv_intel_lvds_save; 523 gma_connector->restore = cdv_intel_lvds_restore; 524 encoder = &gma_encoder->base; 525 526 527 drm_connector_init(dev, connector, 528 &cdv_intel_lvds_connector_funcs, 529 DRM_MODE_CONNECTOR_LVDS); 530 531 drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS); 532 533 gma_connector_attach_encoder(gma_connector, gma_encoder); 534 gma_encoder->type = INTEL_OUTPUT_LVDS; 535 536 drm_encoder_helper_add(encoder, &cdv_intel_lvds_helper_funcs); 537 drm_connector_helper_add(connector, 538 &cdv_intel_lvds_connector_helper_funcs); 539 connector->display_info.subpixel_order = SubPixelHorizontalRGB; 540 connector->interlace_allowed = false; 541 connector->doublescan_allowed = false; 542 543 /*Attach connector properties*/ 544 drm_object_attach_property(&connector->base, 545 dev->mode_config.scaling_mode_property, 546 DRM_MODE_SCALE_FULLSCREEN); 547 drm_object_attach_property(&connector->base, 548 dev_priv->backlight_property, 549 BRIGHTNESS_MAX_LEVEL); 550 551 /** 552 * Set up I2C bus 553 * FIXME: distroy i2c_bus when exit 554 */ 555 gma_encoder->i2c_bus = psb_intel_i2c_create(dev, 556 GPIOB, 557 "LVDSBLC_B"); 558 if (!gma_encoder->i2c_bus) { 559 dev_printk(KERN_ERR, 560 &dev->pdev->dev, "I2C bus registration failed.\n"); 561 goto failed_blc_i2c; 562 } 563 gma_encoder->i2c_bus->slave_addr = 0x2C; 564 dev_priv->lvds_i2c_bus = gma_encoder->i2c_bus; 565 566 /* 567 * LVDS discovery: 568 * 1) check for EDID on DDC 569 * 2) check for VBT data 570 * 3) check to see if LVDS is already on 571 * if none of the above, no panel 572 * 4) make sure lid is open 573 * if closed, act like it's not there for now 574 */ 575 576 /* Set up the DDC bus. */ 577 gma_encoder->ddc_bus = psb_intel_i2c_create(dev, 578 GPIOC, 579 "LVDSDDC_C"); 580 if (!gma_encoder->ddc_bus) { 581 dev_printk(KERN_ERR, &dev->pdev->dev, 582 "DDC bus registration " "failed.\n"); 583 goto failed_ddc; 584 } 585 586 /* 587 * Attempt to get the fixed panel mode from DDC. Assume that the 588 * preferred mode is the right one. 589 */ 590 mutex_lock(&dev->mode_config.mutex); 591 psb_intel_ddc_get_modes(connector, 592 &gma_encoder->ddc_bus->adapter); 593 list_for_each_entry(scan, &connector->probed_modes, head) { 594 if (scan->type & DRM_MODE_TYPE_PREFERRED) { 595 mode_dev->panel_fixed_mode = 596 drm_mode_duplicate(dev, scan); 597 goto out; /* FIXME: check for quirks */ 598 } 599 } 600 601 /* Failed to get EDID, what about VBT? do we need this?*/ 602 if (dev_priv->lfp_lvds_vbt_mode) { 603 mode_dev->panel_fixed_mode = 604 drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode); 605 if (mode_dev->panel_fixed_mode) { 606 mode_dev->panel_fixed_mode->type |= 607 DRM_MODE_TYPE_PREFERRED; 608 goto out; /* FIXME: check for quirks */ 609 } 610 } 611 /* 612 * If we didn't get EDID, try checking if the panel is already turned 613 * on. If so, assume that whatever is currently programmed is the 614 * correct mode. 615 */ 616 lvds = REG_READ(LVDS); 617 pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0; 618 crtc = psb_intel_get_crtc_from_pipe(dev, pipe); 619 620 if (crtc && (lvds & LVDS_PORT_EN)) { 621 mode_dev->panel_fixed_mode = 622 cdv_intel_crtc_mode_get(dev, crtc); 623 if (mode_dev->panel_fixed_mode) { 624 mode_dev->panel_fixed_mode->type |= 625 DRM_MODE_TYPE_PREFERRED; 626 goto out; /* FIXME: check for quirks */ 627 } 628 } 629 630 /* If we still don't have a mode after all that, give up. */ 631 if (!mode_dev->panel_fixed_mode) { 632 DRM_DEBUG 633 ("Found no modes on the lvds, ignoring the LVDS\n"); 634 goto failed_find; 635 } 636 637 /* setup PWM */ 638 { 639 u32 pwm; 640 641 pwm = REG_READ(BLC_PWM_CTL2); 642 if (pipe == 1) 643 pwm |= PWM_PIPE_B; 644 else 645 pwm &= ~PWM_PIPE_B; 646 pwm |= PWM_ENABLE; 647 REG_WRITE(BLC_PWM_CTL2, pwm); 648 } 649 650out: 651 mutex_unlock(&dev->mode_config.mutex); 652 drm_connector_register(connector); 653 return; 654 655failed_find: 656 mutex_unlock(&dev->mode_config.mutex); 657 pr_err("Failed find\n"); 658 psb_intel_i2c_destroy(gma_encoder->ddc_bus); 659failed_ddc: 660 pr_err("Failed DDC\n"); 661 psb_intel_i2c_destroy(gma_encoder->i2c_bus); 662failed_blc_i2c: 663 pr_err("Failed BLC\n"); 664 drm_encoder_cleanup(encoder); 665 drm_connector_cleanup(connector); 666 kfree(lvds_priv); 667failed_lvds_priv: 668 kfree(gma_connector); 669failed_connector: 670 kfree(gma_encoder); 671} 672