1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Analog Devices ADV7511 HDMI transmitter driver
4 *
5 * Copyright 2012 Analog Devices Inc.
6 */
7
8#include <linux/clk.h>
9#include <linux/device.h>
10#include <linux/gpio/consumer.h>
11#include <linux/module.h>
12#include <linux/of_device.h>
13#include <linux/slab.h>
14
15#include <media/cec.h>
16
17#include <drm/drm_atomic.h>
18#include <drm/drm_atomic_helper.h>
19#include <drm/drm_edid.h>
20#include <drm/drm_print.h>
21#include <drm/drm_probe_helper.h>
22
23#include "adv7511.h"
24
25/* ADI recommended values for proper operation. */
26static const struct reg_sequence adv7511_fixed_registers[] = {
27	{ 0x98, 0x03 },
28	{ 0x9a, 0xe0 },
29	{ 0x9c, 0x30 },
30	{ 0x9d, 0x61 },
31	{ 0xa2, 0xa4 },
32	{ 0xa3, 0xa4 },
33	{ 0xe0, 0xd0 },
34	{ 0xf9, 0x00 },
35	{ 0x55, 0x02 },
36};
37
38/* -----------------------------------------------------------------------------
39 * Register access
40 */
41
42static const uint8_t adv7511_register_defaults[] = {
43	0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 00 */
44	0x00, 0x00, 0x01, 0x0e, 0xbc, 0x18, 0x01, 0x13,
45	0x25, 0x37, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 10 */
46	0x46, 0x62, 0x04, 0xa8, 0x00, 0x00, 0x1c, 0x84,
47	0x1c, 0xbf, 0x04, 0xa8, 0x1e, 0x70, 0x02, 0x1e, /* 20 */
48	0x00, 0x00, 0x04, 0xa8, 0x08, 0x12, 0x1b, 0xac,
49	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 30 */
50	0x00, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 0xb0,
51	0x00, 0x50, 0x90, 0x7e, 0x79, 0x70, 0x00, 0x00, /* 40 */
52	0x00, 0xa8, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
53	0x00, 0x00, 0x02, 0x0d, 0x00, 0x00, 0x00, 0x00, /* 50 */
54	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
55	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 60 */
56	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
57	0x01, 0x0a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 70 */
58	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
59	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 80 */
60	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
61	0x00, 0x00, 0x00, 0x00, 0xc0, 0x00, 0x00, 0x00, /* 90 */
62	0x0b, 0x02, 0x00, 0x18, 0x5a, 0x60, 0x00, 0x00,
63	0x00, 0x00, 0x80, 0x80, 0x08, 0x04, 0x00, 0x00, /* a0 */
64	0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x40, 0x14,
65	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* b0 */
66	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
67	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* c0 */
68	0x00, 0x03, 0x00, 0x00, 0x02, 0x00, 0x01, 0x04,
69	0x30, 0xff, 0x80, 0x80, 0x80, 0x00, 0x00, 0x00, /* d0 */
70	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x01,
71	0x80, 0x75, 0x00, 0x00, 0x60, 0x00, 0x00, 0x00, /* e0 */
72	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
73	0x00, 0x00, 0x00, 0x00, 0x00, 0x75, 0x11, 0x00, /* f0 */
74	0x00, 0x7c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
75};
76
77static bool adv7511_register_volatile(struct device *dev, unsigned int reg)
78{
79	switch (reg) {
80	case ADV7511_REG_CHIP_REVISION:
81	case ADV7511_REG_SPDIF_FREQ:
82	case ADV7511_REG_CTS_AUTOMATIC1:
83	case ADV7511_REG_CTS_AUTOMATIC2:
84	case ADV7511_REG_VIC_DETECTED:
85	case ADV7511_REG_VIC_SEND:
86	case ADV7511_REG_AUX_VIC_DETECTED:
87	case ADV7511_REG_STATUS:
88	case ADV7511_REG_GC(1):
89	case ADV7511_REG_INT(0):
90	case ADV7511_REG_INT(1):
91	case ADV7511_REG_PLL_STATUS:
92	case ADV7511_REG_AN(0):
93	case ADV7511_REG_AN(1):
94	case ADV7511_REG_AN(2):
95	case ADV7511_REG_AN(3):
96	case ADV7511_REG_AN(4):
97	case ADV7511_REG_AN(5):
98	case ADV7511_REG_AN(6):
99	case ADV7511_REG_AN(7):
100	case ADV7511_REG_HDCP_STATUS:
101	case ADV7511_REG_BCAPS:
102	case ADV7511_REG_BKSV(0):
103	case ADV7511_REG_BKSV(1):
104	case ADV7511_REG_BKSV(2):
105	case ADV7511_REG_BKSV(3):
106	case ADV7511_REG_BKSV(4):
107	case ADV7511_REG_DDC_STATUS:
108	case ADV7511_REG_EDID_READ_CTRL:
109	case ADV7511_REG_BSTATUS(0):
110	case ADV7511_REG_BSTATUS(1):
111	case ADV7511_REG_CHIP_ID_HIGH:
112	case ADV7511_REG_CHIP_ID_LOW:
113		return true;
114	}
115
116	return false;
117}
118
119static const struct regmap_config adv7511_regmap_config = {
120	.reg_bits = 8,
121	.val_bits = 8,
122
123	.max_register = 0xff,
124	.cache_type = REGCACHE_RBTREE,
125	.reg_defaults_raw = adv7511_register_defaults,
126	.num_reg_defaults_raw = ARRAY_SIZE(adv7511_register_defaults),
127
128	.volatile_reg = adv7511_register_volatile,
129};
130
131/* -----------------------------------------------------------------------------
132 * Hardware configuration
133 */
134
135static void adv7511_set_colormap(struct adv7511 *adv7511, bool enable,
136				 const uint16_t *coeff,
137				 unsigned int scaling_factor)
138{
139	unsigned int i;
140
141	regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(1),
142			   ADV7511_CSC_UPDATE_MODE, ADV7511_CSC_UPDATE_MODE);
143
144	if (enable) {
145		for (i = 0; i < 12; ++i) {
146			regmap_update_bits(adv7511->regmap,
147					   ADV7511_REG_CSC_UPPER(i),
148					   0x1f, coeff[i] >> 8);
149			regmap_write(adv7511->regmap,
150				     ADV7511_REG_CSC_LOWER(i),
151				     coeff[i] & 0xff);
152		}
153	}
154
155	if (enable)
156		regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(0),
157				   0xe0, 0x80 | (scaling_factor << 5));
158	else
159		regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(0),
160				   0x80, 0x00);
161
162	regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(1),
163			   ADV7511_CSC_UPDATE_MODE, 0);
164}
165
166static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet)
167{
168	if (packet & 0xff)
169		regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
170				   packet, 0xff);
171
172	if (packet & 0xff00) {
173		packet >>= 8;
174		regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE1,
175				   packet, 0xff);
176	}
177
178	return 0;
179}
180
181static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet)
182{
183	if (packet & 0xff)
184		regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
185				   packet, 0x00);
186
187	if (packet & 0xff00) {
188		packet >>= 8;
189		regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE1,
190				   packet, 0x00);
191	}
192
193	return 0;
194}
195
196/* Coefficients for adv7511 color space conversion */
197static const uint16_t adv7511_csc_ycbcr_to_rgb[] = {
198	0x0734, 0x04ad, 0x0000, 0x1c1b,
199	0x1ddc, 0x04ad, 0x1f24, 0x0135,
200	0x0000, 0x04ad, 0x087c, 0x1b77,
201};
202
203static void adv7511_set_config_csc(struct adv7511 *adv7511,
204				   struct drm_connector *connector,
205				   bool rgb, bool hdmi_mode)
206{
207	struct adv7511_video_config config;
208	bool output_format_422, output_format_ycbcr;
209	unsigned int mode;
210	uint8_t infoframe[17];
211
212	config.hdmi_mode = hdmi_mode;
213
214	hdmi_avi_infoframe_init(&config.avi_infoframe);
215
216	config.avi_infoframe.scan_mode = HDMI_SCAN_MODE_UNDERSCAN;
217
218	if (rgb) {
219		config.csc_enable = false;
220		config.avi_infoframe.colorspace = HDMI_COLORSPACE_RGB;
221	} else {
222		config.csc_scaling_factor = ADV7511_CSC_SCALING_4;
223		config.csc_coefficents = adv7511_csc_ycbcr_to_rgb;
224
225		if ((connector->display_info.color_formats &
226		     DRM_COLOR_FORMAT_YCRCB422) &&
227		    config.hdmi_mode) {
228			config.csc_enable = false;
229			config.avi_infoframe.colorspace =
230				HDMI_COLORSPACE_YUV422;
231		} else {
232			config.csc_enable = true;
233			config.avi_infoframe.colorspace = HDMI_COLORSPACE_RGB;
234		}
235	}
236
237	if (config.hdmi_mode) {
238		mode = ADV7511_HDMI_CFG_MODE_HDMI;
239
240		switch (config.avi_infoframe.colorspace) {
241		case HDMI_COLORSPACE_YUV444:
242			output_format_422 = false;
243			output_format_ycbcr = true;
244			break;
245		case HDMI_COLORSPACE_YUV422:
246			output_format_422 = true;
247			output_format_ycbcr = true;
248			break;
249		default:
250			output_format_422 = false;
251			output_format_ycbcr = false;
252			break;
253		}
254	} else {
255		mode = ADV7511_HDMI_CFG_MODE_DVI;
256		output_format_422 = false;
257		output_format_ycbcr = false;
258	}
259
260	adv7511_packet_disable(adv7511, ADV7511_PACKET_ENABLE_AVI_INFOFRAME);
261
262	adv7511_set_colormap(adv7511, config.csc_enable,
263			     config.csc_coefficents,
264			     config.csc_scaling_factor);
265
266	regmap_update_bits(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG1, 0x81,
267			   (output_format_422 << 7) | output_format_ycbcr);
268
269	regmap_update_bits(adv7511->regmap, ADV7511_REG_HDCP_HDMI_CFG,
270			   ADV7511_HDMI_CFG_MODE_MASK, mode);
271
272	hdmi_avi_infoframe_pack(&config.avi_infoframe, infoframe,
273				sizeof(infoframe));
274
275	/* The AVI infoframe id is not configurable */
276	regmap_bulk_write(adv7511->regmap, ADV7511_REG_AVI_INFOFRAME_VERSION,
277			  infoframe + 1, sizeof(infoframe) - 1);
278
279	adv7511_packet_enable(adv7511, ADV7511_PACKET_ENABLE_AVI_INFOFRAME);
280}
281
282static void adv7511_set_link_config(struct adv7511 *adv7511,
283				    const struct adv7511_link_config *config)
284{
285	/*
286	 * The input style values documented in the datasheet don't match the
287	 * hardware register field values :-(
288	 */
289	static const unsigned int input_styles[4] = { 0, 2, 1, 3 };
290
291	unsigned int clock_delay;
292	unsigned int color_depth;
293	unsigned int input_id;
294
295	clock_delay = (config->clock_delay + 1200) / 400;
296	color_depth = config->input_color_depth == 8 ? 3
297		    : (config->input_color_depth == 10 ? 1 : 2);
298
299	/* TODO Support input ID 6 */
300	if (config->input_colorspace != HDMI_COLORSPACE_YUV422)
301		input_id = config->input_clock == ADV7511_INPUT_CLOCK_DDR
302			 ? 5 : 0;
303	else if (config->input_clock == ADV7511_INPUT_CLOCK_DDR)
304		input_id = config->embedded_sync ? 8 : 7;
305	else if (config->input_clock == ADV7511_INPUT_CLOCK_2X)
306		input_id = config->embedded_sync ? 4 : 3;
307	else
308		input_id = config->embedded_sync ? 2 : 1;
309
310	regmap_update_bits(adv7511->regmap, ADV7511_REG_I2C_FREQ_ID_CFG, 0xf,
311			   input_id);
312	regmap_update_bits(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG1, 0x7e,
313			   (color_depth << 4) |
314			   (input_styles[config->input_style] << 2));
315	regmap_write(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG2,
316		     config->input_justification << 3);
317	regmap_write(adv7511->regmap, ADV7511_REG_TIMING_GEN_SEQ,
318		     config->sync_pulse << 2);
319
320	regmap_write(adv7511->regmap, 0xba, clock_delay << 5);
321
322	adv7511->embedded_sync = config->embedded_sync;
323	adv7511->hsync_polarity = config->hsync_polarity;
324	adv7511->vsync_polarity = config->vsync_polarity;
325	adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB;
326}
327
328static void __adv7511_power_on(struct adv7511 *adv7511)
329{
330	adv7511->current_edid_segment = -1;
331
332	regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER,
333			   ADV7511_POWER_POWER_DOWN, 0);
334	if (adv7511->i2c_main->irq) {
335		/*
336		 * Documentation says the INT_ENABLE registers are reset in
337		 * POWER_DOWN mode. My 7511w preserved the bits, however.
338		 * Still, let's be safe and stick to the documentation.
339		 */
340		regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0),
341			     ADV7511_INT0_EDID_READY | ADV7511_INT0_HPD);
342		regmap_update_bits(adv7511->regmap,
343				   ADV7511_REG_INT_ENABLE(1),
344				   ADV7511_INT1_DDC_ERROR,
345				   ADV7511_INT1_DDC_ERROR);
346	}
347
348	/*
349	 * Per spec it is allowed to pulse the HPD signal to indicate that the
350	 * EDID information has changed. Some monitors do this when they wakeup
351	 * from standby or are enabled. When the HPD goes low the adv7511 is
352	 * reset and the outputs are disabled which might cause the monitor to
353	 * go to standby again. To avoid this we ignore the HPD pin for the
354	 * first few seconds after enabling the output. On the other hand
355	 * adv7535 require to enable HPD Override bit for proper HPD.
356	 */
357	if (adv7511->type == ADV7535)
358		regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
359				   ADV7535_REG_POWER2_HPD_OVERRIDE,
360				   ADV7535_REG_POWER2_HPD_OVERRIDE);
361	else
362		regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
363				   ADV7511_REG_POWER2_HPD_SRC_MASK,
364				   ADV7511_REG_POWER2_HPD_SRC_NONE);
365}
366
367static void adv7511_power_on(struct adv7511 *adv7511)
368{
369	__adv7511_power_on(adv7511);
370
371	/*
372	 * Most of the registers are reset during power down or when HPD is low.
373	 */
374	regcache_sync(adv7511->regmap);
375
376	if (adv7511->type == ADV7533 || adv7511->type == ADV7535)
377		adv7533_dsi_power_on(adv7511);
378	adv7511->powered = true;
379}
380
381static void __adv7511_power_off(struct adv7511 *adv7511)
382{
383	/* TODO: setup additional power down modes */
384	if (adv7511->type == ADV7535)
385		regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
386				   ADV7535_REG_POWER2_HPD_OVERRIDE, 0);
387
388	regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER,
389			   ADV7511_POWER_POWER_DOWN,
390			   ADV7511_POWER_POWER_DOWN);
391	regmap_update_bits(adv7511->regmap,
392			   ADV7511_REG_INT_ENABLE(1),
393			   ADV7511_INT1_DDC_ERROR, 0);
394	regcache_mark_dirty(adv7511->regmap);
395}
396
397static void adv7511_power_off(struct adv7511 *adv7511)
398{
399	__adv7511_power_off(adv7511);
400	if (adv7511->type == ADV7533 || adv7511->type == ADV7535)
401		adv7533_dsi_power_off(adv7511);
402	adv7511->powered = false;
403}
404
405/* -----------------------------------------------------------------------------
406 * Interrupt and hotplug detection
407 */
408
409static bool adv7511_hpd(struct adv7511 *adv7511)
410{
411	unsigned int irq0;
412	int ret;
413
414	ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0);
415	if (ret < 0)
416		return false;
417
418	if (irq0 & ADV7511_INT0_HPD) {
419		regmap_write(adv7511->regmap, ADV7511_REG_INT(0),
420			     ADV7511_INT0_HPD);
421		return true;
422	}
423
424	return false;
425}
426
427static void adv7511_hpd_work(struct work_struct *work)
428{
429	struct adv7511 *adv7511 = container_of(work, struct adv7511, hpd_work);
430	enum drm_connector_status status;
431	unsigned int val;
432	int ret;
433
434	ret = regmap_read(adv7511->regmap, ADV7511_REG_STATUS, &val);
435	if (ret < 0)
436		status = connector_status_disconnected;
437	else if (val & ADV7511_STATUS_HPD)
438		status = connector_status_connected;
439	else
440		status = connector_status_disconnected;
441
442	/*
443	 * The bridge resets its registers on unplug. So when we get a plug
444	 * event and we're already supposed to be powered, cycle the bridge to
445	 * restore its state.
446	 */
447	if (status == connector_status_connected &&
448	    adv7511->connector.status == connector_status_disconnected &&
449	    adv7511->powered) {
450		regcache_mark_dirty(adv7511->regmap);
451		adv7511_power_on(adv7511);
452	}
453
454	if (adv7511->connector.status != status) {
455		adv7511->connector.status = status;
456
457		if (adv7511->connector.dev) {
458			if (status == connector_status_disconnected)
459				cec_phys_addr_invalidate(adv7511->cec_adap);
460			drm_kms_helper_hotplug_event(adv7511->connector.dev);
461		} else {
462			drm_bridge_hpd_notify(&adv7511->bridge, status);
463		}
464	}
465}
466
467static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd)
468{
469	unsigned int irq0, irq1;
470	int ret;
471
472	ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0);
473	if (ret < 0)
474		return ret;
475
476	ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(1), &irq1);
477	if (ret < 0)
478		return ret;
479
480	regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0);
481	regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1);
482
483	if (process_hpd && irq0 & ADV7511_INT0_HPD && adv7511->bridge.encoder)
484		schedule_work(&adv7511->hpd_work);
485
486	if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) {
487		adv7511->edid_read = true;
488
489		if (adv7511->i2c_main->irq)
490			wake_up_all(&adv7511->wq);
491	}
492
493#ifdef CONFIG_DRM_I2C_ADV7511_CEC
494	adv7511_cec_irq_process(adv7511, irq1);
495#endif
496
497	return 0;
498}
499
500static irqreturn_t adv7511_irq_handler(int irq, void *devid)
501{
502	struct adv7511 *adv7511 = devid;
503	int ret;
504
505	ret = adv7511_irq_process(adv7511, true);
506	return ret < 0 ? IRQ_NONE : IRQ_HANDLED;
507}
508
509/* -----------------------------------------------------------------------------
510 * EDID retrieval
511 */
512
513static int adv7511_wait_for_edid(struct adv7511 *adv7511, int timeout)
514{
515	int ret;
516
517	if (adv7511->i2c_main->irq) {
518		ret = wait_event_interruptible_timeout(adv7511->wq,
519				adv7511->edid_read, msecs_to_jiffies(timeout));
520	} else {
521		for (; timeout > 0; timeout -= 25) {
522			ret = adv7511_irq_process(adv7511, false);
523			if (ret < 0)
524				break;
525
526			if (adv7511->edid_read)
527				break;
528
529			msleep(25);
530		}
531	}
532
533	return adv7511->edid_read ? 0 : -EIO;
534}
535
536static int adv7511_get_edid_block(void *data, u8 *buf, unsigned int block,
537				  size_t len)
538{
539	struct adv7511 *adv7511 = data;
540	struct i2c_msg xfer[2];
541	uint8_t offset;
542	unsigned int i;
543	int ret;
544
545	if (len > 128)
546		return -EINVAL;
547
548	if (adv7511->current_edid_segment != block / 2) {
549		unsigned int status;
550
551		ret = regmap_read(adv7511->regmap, ADV7511_REG_DDC_STATUS,
552				  &status);
553		if (ret < 0)
554			return ret;
555
556		if (status != 2) {
557			adv7511->edid_read = false;
558			regmap_write(adv7511->regmap, ADV7511_REG_EDID_SEGMENT,
559				     block);
560			ret = adv7511_wait_for_edid(adv7511, 200);
561			if (ret < 0)
562				return ret;
563		}
564
565		/* Break this apart, hopefully more I2C controllers will
566		 * support 64 byte transfers than 256 byte transfers
567		 */
568
569		xfer[0].addr = adv7511->i2c_edid->addr;
570		xfer[0].flags = 0;
571		xfer[0].len = 1;
572		xfer[0].buf = &offset;
573		xfer[1].addr = adv7511->i2c_edid->addr;
574		xfer[1].flags = I2C_M_RD;
575		xfer[1].len = 64;
576		xfer[1].buf = adv7511->edid_buf;
577
578		offset = 0;
579
580		for (i = 0; i < 4; ++i) {
581			ret = i2c_transfer(adv7511->i2c_edid->adapter, xfer,
582					   ARRAY_SIZE(xfer));
583			if (ret < 0)
584				return ret;
585			else if (ret != 2)
586				return -EIO;
587
588			xfer[1].buf += 64;
589			offset += 64;
590		}
591
592		adv7511->current_edid_segment = block / 2;
593	}
594
595	if (block % 2 == 0)
596		memcpy(buf, adv7511->edid_buf, len);
597	else
598		memcpy(buf, adv7511->edid_buf + 128, len);
599
600	return 0;
601}
602
603/* -----------------------------------------------------------------------------
604 * ADV75xx helpers
605 */
606
607static struct edid *adv7511_get_edid(struct adv7511 *adv7511,
608				     struct drm_connector *connector)
609{
610	struct edid *edid;
611
612	/* Reading the EDID only works if the device is powered */
613	if (!adv7511->powered) {
614		unsigned int edid_i2c_addr =
615					(adv7511->i2c_edid->addr << 1);
616
617		__adv7511_power_on(adv7511);
618
619		/* Reset the EDID_I2C_ADDR register as it might be cleared */
620		regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR,
621			     edid_i2c_addr);
622	}
623
624	edid = drm_do_get_edid(connector, adv7511_get_edid_block, adv7511);
625
626	if (!adv7511->powered)
627		__adv7511_power_off(adv7511);
628
629	adv7511_set_config_csc(adv7511, connector, adv7511->rgb,
630			       drm_detect_hdmi_monitor(edid));
631
632	cec_s_phys_addr_from_edid(adv7511->cec_adap, edid);
633
634	return edid;
635}
636
637static int adv7511_get_modes(struct adv7511 *adv7511,
638			     struct drm_connector *connector)
639{
640	struct edid *edid;
641	unsigned int count;
642
643	edid = adv7511_get_edid(adv7511, connector);
644
645	drm_connector_update_edid_property(connector, edid);
646	count = drm_add_edid_modes(connector, edid);
647
648	kfree(edid);
649
650	return count;
651}
652
653static enum drm_connector_status
654adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector)
655{
656	enum drm_connector_status status;
657	unsigned int val;
658	bool hpd;
659	int ret;
660
661	ret = regmap_read(adv7511->regmap, ADV7511_REG_STATUS, &val);
662	if (ret < 0)
663		return connector_status_disconnected;
664
665	if (val & ADV7511_STATUS_HPD)
666		status = connector_status_connected;
667	else
668		status = connector_status_disconnected;
669
670	hpd = adv7511_hpd(adv7511);
671
672	/* The chip resets itself when the cable is disconnected, so in case
673	 * there is a pending HPD interrupt and the cable is connected there was
674	 * at least one transition from disconnected to connected and the chip
675	 * has to be reinitialized. */
676	if (status == connector_status_connected && hpd && adv7511->powered) {
677		regcache_mark_dirty(adv7511->regmap);
678		adv7511_power_on(adv7511);
679		if (connector)
680			adv7511_get_modes(adv7511, connector);
681		if (adv7511->status == connector_status_connected)
682			status = connector_status_disconnected;
683	} else {
684		/* Renable HPD sensing */
685		if (adv7511->type == ADV7535)
686			regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
687					   ADV7535_REG_POWER2_HPD_OVERRIDE,
688					   ADV7535_REG_POWER2_HPD_OVERRIDE);
689		else
690			regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
691					   ADV7511_REG_POWER2_HPD_SRC_MASK,
692					   ADV7511_REG_POWER2_HPD_SRC_BOTH);
693	}
694
695	adv7511->status = status;
696	return status;
697}
698
699static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511,
700			      const struct drm_display_mode *mode)
701{
702	if (mode->clock > 165000)
703		return MODE_CLOCK_HIGH;
704
705	return MODE_OK;
706}
707
708static void adv7511_mode_set(struct adv7511 *adv7511,
709			     const struct drm_display_mode *mode,
710			     const struct drm_display_mode *adj_mode)
711{
712	unsigned int low_refresh_rate;
713	unsigned int hsync_polarity = 0;
714	unsigned int vsync_polarity = 0;
715
716	if (adv7511->embedded_sync) {
717		unsigned int hsync_offset, hsync_len;
718		unsigned int vsync_offset, vsync_len;
719
720		hsync_offset = adj_mode->crtc_hsync_start -
721			       adj_mode->crtc_hdisplay;
722		vsync_offset = adj_mode->crtc_vsync_start -
723			       adj_mode->crtc_vdisplay;
724		hsync_len = adj_mode->crtc_hsync_end -
725			    adj_mode->crtc_hsync_start;
726		vsync_len = adj_mode->crtc_vsync_end -
727			    adj_mode->crtc_vsync_start;
728
729		/* The hardware vsync generator has a off-by-one bug */
730		vsync_offset += 1;
731
732		regmap_write(adv7511->regmap, ADV7511_REG_HSYNC_PLACEMENT_MSB,
733			     ((hsync_offset >> 10) & 0x7) << 5);
734		regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(0),
735			     (hsync_offset >> 2) & 0xff);
736		regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(1),
737			     ((hsync_offset & 0x3) << 6) |
738			     ((hsync_len >> 4) & 0x3f));
739		regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(2),
740			     ((hsync_len & 0xf) << 4) |
741			     ((vsync_offset >> 6) & 0xf));
742		regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(3),
743			     ((vsync_offset & 0x3f) << 2) |
744			     ((vsync_len >> 8) & 0x3));
745		regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(4),
746			     vsync_len & 0xff);
747
748		hsync_polarity = !(adj_mode->flags & DRM_MODE_FLAG_PHSYNC);
749		vsync_polarity = !(adj_mode->flags & DRM_MODE_FLAG_PVSYNC);
750	} else {
751		enum adv7511_sync_polarity mode_hsync_polarity;
752		enum adv7511_sync_polarity mode_vsync_polarity;
753
754		/**
755		 * If the input signal is always low or always high we want to
756		 * invert or let it passthrough depending on the polarity of the
757		 * current mode.
758		 **/
759		if (adj_mode->flags & DRM_MODE_FLAG_NHSYNC)
760			mode_hsync_polarity = ADV7511_SYNC_POLARITY_LOW;
761		else
762			mode_hsync_polarity = ADV7511_SYNC_POLARITY_HIGH;
763
764		if (adj_mode->flags & DRM_MODE_FLAG_NVSYNC)
765			mode_vsync_polarity = ADV7511_SYNC_POLARITY_LOW;
766		else
767			mode_vsync_polarity = ADV7511_SYNC_POLARITY_HIGH;
768
769		if (adv7511->hsync_polarity != mode_hsync_polarity &&
770		    adv7511->hsync_polarity !=
771		    ADV7511_SYNC_POLARITY_PASSTHROUGH)
772			hsync_polarity = 1;
773
774		if (adv7511->vsync_polarity != mode_vsync_polarity &&
775		    adv7511->vsync_polarity !=
776		    ADV7511_SYNC_POLARITY_PASSTHROUGH)
777			vsync_polarity = 1;
778	}
779
780	if (drm_mode_vrefresh(mode) <= 24)
781		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_24HZ;
782	else if (drm_mode_vrefresh(mode) <= 25)
783		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_25HZ;
784	else if (drm_mode_vrefresh(mode) <= 30)
785		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_30HZ;
786	else
787		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
788
789	if (adv7511->type == ADV7511)
790		regmap_update_bits(adv7511->regmap, 0xfb,
791				   0x6, low_refresh_rate << 1);
792	else
793		regmap_update_bits(adv7511->regmap, 0x4a,
794				   0xc, low_refresh_rate << 2);
795
796	regmap_update_bits(adv7511->regmap, 0x17,
797		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
798
799	drm_mode_copy(&adv7511->curr_mode, adj_mode);
800
801	/*
802	 * TODO Test first order 4:2:2 to 4:4:4 up conversion method, which is
803	 * supposed to give better results.
804	 */
805
806	adv7511->f_tmds = mode->clock;
807}
808
809/* -----------------------------------------------------------------------------
810 * DRM Connector Operations
811 */
812
813static struct adv7511 *connector_to_adv7511(struct drm_connector *connector)
814{
815	return container_of(connector, struct adv7511, connector);
816}
817
818static int adv7511_connector_get_modes(struct drm_connector *connector)
819{
820	struct adv7511 *adv = connector_to_adv7511(connector);
821
822	return adv7511_get_modes(adv, connector);
823}
824
825static enum drm_mode_status
826adv7511_connector_mode_valid(struct drm_connector *connector,
827			     struct drm_display_mode *mode)
828{
829	struct adv7511 *adv = connector_to_adv7511(connector);
830
831	return adv7511_mode_valid(adv, mode);
832}
833
834static struct drm_connector_helper_funcs adv7511_connector_helper_funcs = {
835	.get_modes = adv7511_connector_get_modes,
836	.mode_valid = adv7511_connector_mode_valid,
837};
838
839static enum drm_connector_status
840adv7511_connector_detect(struct drm_connector *connector, bool force)
841{
842	struct adv7511 *adv = connector_to_adv7511(connector);
843
844	return adv7511_detect(adv, connector);
845}
846
847static const struct drm_connector_funcs adv7511_connector_funcs = {
848	.fill_modes = drm_helper_probe_single_connector_modes,
849	.detect = adv7511_connector_detect,
850	.destroy = drm_connector_cleanup,
851	.reset = drm_atomic_helper_connector_reset,
852	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
853	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
854};
855
856static int adv7511_connector_init(struct adv7511 *adv)
857{
858	struct drm_bridge *bridge = &adv->bridge;
859	int ret;
860
861	if (!bridge->encoder) {
862		DRM_ERROR("Parent encoder object not found");
863		return -ENODEV;
864	}
865
866	if (adv->i2c_main->irq)
867		adv->connector.polled = DRM_CONNECTOR_POLL_HPD;
868	else
869		adv->connector.polled = DRM_CONNECTOR_POLL_CONNECT |
870				DRM_CONNECTOR_POLL_DISCONNECT;
871
872	ret = drm_connector_init(bridge->dev, &adv->connector,
873				 &adv7511_connector_funcs,
874				 DRM_MODE_CONNECTOR_HDMIA);
875	if (ret < 0) {
876		DRM_ERROR("Failed to initialize connector with drm\n");
877		return ret;
878	}
879	drm_connector_helper_add(&adv->connector,
880				 &adv7511_connector_helper_funcs);
881	drm_connector_attach_encoder(&adv->connector, bridge->encoder);
882
883	return 0;
884}
885
886/* -----------------------------------------------------------------------------
887 * DRM Bridge Operations
888 */
889
890static struct adv7511 *bridge_to_adv7511(struct drm_bridge *bridge)
891{
892	return container_of(bridge, struct adv7511, bridge);
893}
894
895static void adv7511_bridge_enable(struct drm_bridge *bridge)
896{
897	struct adv7511 *adv = bridge_to_adv7511(bridge);
898
899	adv7511_power_on(adv);
900}
901
902static void adv7511_bridge_disable(struct drm_bridge *bridge)
903{
904	struct adv7511 *adv = bridge_to_adv7511(bridge);
905
906	adv7511_power_off(adv);
907}
908
909static void adv7511_bridge_mode_set(struct drm_bridge *bridge,
910				    const struct drm_display_mode *mode,
911				    const struct drm_display_mode *adj_mode)
912{
913	struct adv7511 *adv = bridge_to_adv7511(bridge);
914
915	adv7511_mode_set(adv, mode, adj_mode);
916}
917
918static enum drm_mode_status adv7511_bridge_mode_valid(struct drm_bridge *bridge,
919						      const struct drm_display_info *info,
920		const struct drm_display_mode *mode)
921{
922	struct adv7511 *adv = bridge_to_adv7511(bridge);
923
924	if (adv->type == ADV7533 || adv->type == ADV7535)
925		return adv7533_mode_valid(adv, mode);
926	else
927		return adv7511_mode_valid(adv, mode);
928}
929
930static int adv7511_bridge_attach(struct drm_bridge *bridge,
931				 enum drm_bridge_attach_flags flags)
932{
933	struct adv7511 *adv = bridge_to_adv7511(bridge);
934	int ret = 0;
935
936	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
937		ret = adv7511_connector_init(adv);
938		if (ret < 0)
939			return ret;
940	}
941
942	if (adv->type == ADV7533 || adv->type == ADV7535)
943		ret = adv7533_attach_dsi(adv);
944
945	if (adv->i2c_main->irq)
946		regmap_write(adv->regmap, ADV7511_REG_INT_ENABLE(0),
947			     ADV7511_INT0_HPD);
948
949	return ret;
950}
951
952static enum drm_connector_status adv7511_bridge_detect(struct drm_bridge *bridge)
953{
954	struct adv7511 *adv = bridge_to_adv7511(bridge);
955
956	return adv7511_detect(adv, NULL);
957}
958
959static struct edid *adv7511_bridge_get_edid(struct drm_bridge *bridge,
960					    struct drm_connector *connector)
961{
962	struct adv7511 *adv = bridge_to_adv7511(bridge);
963
964	return adv7511_get_edid(adv, connector);
965}
966
967static void adv7511_bridge_hpd_notify(struct drm_bridge *bridge,
968				      enum drm_connector_status status)
969{
970	struct adv7511 *adv = bridge_to_adv7511(bridge);
971
972	if (status == connector_status_disconnected)
973		cec_phys_addr_invalidate(adv->cec_adap);
974}
975
976static const struct drm_bridge_funcs adv7511_bridge_funcs = {
977	.enable = adv7511_bridge_enable,
978	.disable = adv7511_bridge_disable,
979	.mode_set = adv7511_bridge_mode_set,
980	.mode_valid = adv7511_bridge_mode_valid,
981	.attach = adv7511_bridge_attach,
982	.detect = adv7511_bridge_detect,
983	.get_edid = adv7511_bridge_get_edid,
984	.hpd_notify = adv7511_bridge_hpd_notify,
985};
986
987/* -----------------------------------------------------------------------------
988 * Probe & remove
989 */
990
991static const char * const adv7511_supply_names[] = {
992	"avdd",
993	"dvdd",
994	"pvdd",
995	"bgvdd",
996	"dvdd-3v",
997};
998
999static const char * const adv7533_supply_names[] = {
1000	"avdd",
1001	"dvdd",
1002	"pvdd",
1003	"a2vdd",
1004	"v3p3",
1005	"v1p2",
1006};
1007
1008static int adv7511_init_regulators(struct adv7511 *adv)
1009{
1010	struct device *dev = &adv->i2c_main->dev;
1011	const char * const *supply_names;
1012	unsigned int i;
1013	int ret;
1014
1015	if (adv->type == ADV7511) {
1016		supply_names = adv7511_supply_names;
1017		adv->num_supplies = ARRAY_SIZE(adv7511_supply_names);
1018	} else {
1019		supply_names = adv7533_supply_names;
1020		adv->num_supplies = ARRAY_SIZE(adv7533_supply_names);
1021	}
1022
1023	adv->supplies = devm_kcalloc(dev, adv->num_supplies,
1024				     sizeof(*adv->supplies), GFP_KERNEL);
1025	if (!adv->supplies)
1026		return -ENOMEM;
1027
1028	for (i = 0; i < adv->num_supplies; i++)
1029		adv->supplies[i].supply = supply_names[i];
1030
1031	ret = devm_regulator_bulk_get(dev, adv->num_supplies, adv->supplies);
1032	if (ret)
1033		return ret;
1034
1035	return regulator_bulk_enable(adv->num_supplies, adv->supplies);
1036}
1037
1038static void adv7511_uninit_regulators(struct adv7511 *adv)
1039{
1040	regulator_bulk_disable(adv->num_supplies, adv->supplies);
1041}
1042
1043static bool adv7511_cec_register_volatile(struct device *dev, unsigned int reg)
1044{
1045	struct i2c_client *i2c = to_i2c_client(dev);
1046	struct adv7511 *adv7511 = i2c_get_clientdata(i2c);
1047
1048	if (adv7511->type == ADV7533 || adv7511->type == ADV7535)
1049		reg -= ADV7533_REG_CEC_OFFSET;
1050
1051	switch (reg) {
1052	case ADV7511_REG_CEC_RX_FRAME_HDR:
1053	case ADV7511_REG_CEC_RX_FRAME_DATA0...
1054		ADV7511_REG_CEC_RX_FRAME_DATA0 + 14:
1055	case ADV7511_REG_CEC_RX_FRAME_LEN:
1056	case ADV7511_REG_CEC_RX_BUFFERS:
1057	case ADV7511_REG_CEC_TX_LOW_DRV_CNT:
1058		return true;
1059	}
1060
1061	return false;
1062}
1063
1064static const struct regmap_config adv7511_cec_regmap_config = {
1065	.reg_bits = 8,
1066	.val_bits = 8,
1067
1068	.max_register = 0xff,
1069	.cache_type = REGCACHE_RBTREE,
1070	.volatile_reg = adv7511_cec_register_volatile,
1071};
1072
1073static int adv7511_init_cec_regmap(struct adv7511 *adv)
1074{
1075	int ret;
1076
1077	adv->i2c_cec = i2c_new_ancillary_device(adv->i2c_main, "cec",
1078						ADV7511_CEC_I2C_ADDR_DEFAULT);
1079	if (IS_ERR(adv->i2c_cec))
1080		return PTR_ERR(adv->i2c_cec);
1081
1082	regmap_write(adv->regmap, ADV7511_REG_CEC_I2C_ADDR,
1083		     adv->i2c_cec->addr << 1);
1084
1085	i2c_set_clientdata(adv->i2c_cec, adv);
1086
1087	adv->regmap_cec = devm_regmap_init_i2c(adv->i2c_cec,
1088					&adv7511_cec_regmap_config);
1089	if (IS_ERR(adv->regmap_cec)) {
1090		ret = PTR_ERR(adv->regmap_cec);
1091		goto err;
1092	}
1093
1094	if (adv->type == ADV7533 || adv->type == ADV7535) {
1095		ret = adv7533_patch_cec_registers(adv);
1096		if (ret)
1097			goto err;
1098	}
1099
1100	return 0;
1101err:
1102	i2c_unregister_device(adv->i2c_cec);
1103	return ret;
1104}
1105
1106static int adv7511_parse_dt(struct device_node *np,
1107			    struct adv7511_link_config *config)
1108{
1109	const char *str;
1110	int ret;
1111
1112	of_property_read_u32(np, "adi,input-depth", &config->input_color_depth);
1113	if (config->input_color_depth != 8 && config->input_color_depth != 10 &&
1114	    config->input_color_depth != 12)
1115		return -EINVAL;
1116
1117	ret = of_property_read_string(np, "adi,input-colorspace", &str);
1118	if (ret < 0)
1119		return ret;
1120
1121	if (!strcmp(str, "rgb"))
1122		config->input_colorspace = HDMI_COLORSPACE_RGB;
1123	else if (!strcmp(str, "yuv422"))
1124		config->input_colorspace = HDMI_COLORSPACE_YUV422;
1125	else if (!strcmp(str, "yuv444"))
1126		config->input_colorspace = HDMI_COLORSPACE_YUV444;
1127	else
1128		return -EINVAL;
1129
1130	ret = of_property_read_string(np, "adi,input-clock", &str);
1131	if (ret < 0)
1132		return ret;
1133
1134	if (!strcmp(str, "1x"))
1135		config->input_clock = ADV7511_INPUT_CLOCK_1X;
1136	else if (!strcmp(str, "2x"))
1137		config->input_clock = ADV7511_INPUT_CLOCK_2X;
1138	else if (!strcmp(str, "ddr"))
1139		config->input_clock = ADV7511_INPUT_CLOCK_DDR;
1140	else
1141		return -EINVAL;
1142
1143	if (config->input_colorspace == HDMI_COLORSPACE_YUV422 ||
1144	    config->input_clock != ADV7511_INPUT_CLOCK_1X) {
1145		ret = of_property_read_u32(np, "adi,input-style",
1146					   &config->input_style);
1147		if (ret)
1148			return ret;
1149
1150		if (config->input_style < 1 || config->input_style > 3)
1151			return -EINVAL;
1152
1153		ret = of_property_read_string(np, "adi,input-justification",
1154					      &str);
1155		if (ret < 0)
1156			return ret;
1157
1158		if (!strcmp(str, "left"))
1159			config->input_justification =
1160				ADV7511_INPUT_JUSTIFICATION_LEFT;
1161		else if (!strcmp(str, "evenly"))
1162			config->input_justification =
1163				ADV7511_INPUT_JUSTIFICATION_EVENLY;
1164		else if (!strcmp(str, "right"))
1165			config->input_justification =
1166				ADV7511_INPUT_JUSTIFICATION_RIGHT;
1167		else
1168			return -EINVAL;
1169
1170	} else {
1171		config->input_style = 1;
1172		config->input_justification = ADV7511_INPUT_JUSTIFICATION_LEFT;
1173	}
1174
1175	of_property_read_u32(np, "adi,clock-delay", &config->clock_delay);
1176	if (config->clock_delay < -1200 || config->clock_delay > 1600)
1177		return -EINVAL;
1178
1179	config->embedded_sync = of_property_read_bool(np, "adi,embedded-sync");
1180
1181	/* Hardcode the sync pulse configurations for now. */
1182	config->sync_pulse = ADV7511_INPUT_SYNC_PULSE_NONE;
1183	config->vsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
1184	config->hsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
1185
1186	return 0;
1187}
1188
1189static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
1190{
1191	struct adv7511_link_config link_config;
1192	struct adv7511 *adv7511;
1193	struct device *dev = &i2c->dev;
1194	unsigned int val;
1195	int ret;
1196
1197	if (!dev->of_node)
1198		return -EINVAL;
1199
1200	adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL);
1201	if (!adv7511)
1202		return -ENOMEM;
1203
1204	adv7511->i2c_main = i2c;
1205	adv7511->powered = false;
1206	adv7511->status = connector_status_disconnected;
1207
1208	if (dev->of_node)
1209		adv7511->type = (enum adv7511_type)of_device_get_match_data(dev);
1210	else
1211		adv7511->type = id->driver_data;
1212
1213	memset(&link_config, 0, sizeof(link_config));
1214
1215	if (adv7511->type == ADV7511)
1216		ret = adv7511_parse_dt(dev->of_node, &link_config);
1217	else
1218		ret = adv7533_parse_dt(dev->of_node, adv7511);
1219	if (ret)
1220		return ret;
1221
1222	ret = adv7511_init_regulators(adv7511);
1223	if (ret) {
1224		dev_err(dev, "failed to init regulators\n");
1225		return ret;
1226	}
1227
1228	/*
1229	 * The power down GPIO is optional. If present, toggle it from active to
1230	 * inactive to wake up the encoder.
1231	 */
1232	adv7511->gpio_pd = devm_gpiod_get_optional(dev, "pd", GPIOD_OUT_HIGH);
1233	if (IS_ERR(adv7511->gpio_pd)) {
1234		ret = PTR_ERR(adv7511->gpio_pd);
1235		goto uninit_regulators;
1236	}
1237
1238	if (adv7511->gpio_pd) {
1239		usleep_range(5000, 6000);
1240		gpiod_set_value_cansleep(adv7511->gpio_pd, 0);
1241	}
1242
1243	adv7511->regmap = devm_regmap_init_i2c(i2c, &adv7511_regmap_config);
1244	if (IS_ERR(adv7511->regmap)) {
1245		ret = PTR_ERR(adv7511->regmap);
1246		goto uninit_regulators;
1247	}
1248
1249	ret = regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val);
1250	if (ret)
1251		goto uninit_regulators;
1252	dev_dbg(dev, "Rev. %d\n", val);
1253
1254	if (adv7511->type == ADV7511)
1255		ret = regmap_register_patch(adv7511->regmap,
1256					    adv7511_fixed_registers,
1257					    ARRAY_SIZE(adv7511_fixed_registers));
1258	else
1259		ret = adv7533_patch_registers(adv7511);
1260	if (ret)
1261		goto uninit_regulators;
1262
1263	adv7511_packet_disable(adv7511, 0xffff);
1264
1265	adv7511->i2c_edid = i2c_new_ancillary_device(i2c, "edid",
1266					ADV7511_EDID_I2C_ADDR_DEFAULT);
1267	if (IS_ERR(adv7511->i2c_edid)) {
1268		ret = PTR_ERR(adv7511->i2c_edid);
1269		goto uninit_regulators;
1270	}
1271
1272	regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR,
1273		     adv7511->i2c_edid->addr << 1);
1274
1275	adv7511->i2c_packet = i2c_new_ancillary_device(i2c, "packet",
1276					ADV7511_PACKET_I2C_ADDR_DEFAULT);
1277	if (IS_ERR(adv7511->i2c_packet)) {
1278		ret = PTR_ERR(adv7511->i2c_packet);
1279		goto err_i2c_unregister_edid;
1280	}
1281
1282	regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR,
1283		     adv7511->i2c_packet->addr << 1);
1284
1285	ret = adv7511_init_cec_regmap(adv7511);
1286	if (ret)
1287		goto err_i2c_unregister_packet;
1288
1289	INIT_WORK(&adv7511->hpd_work, adv7511_hpd_work);
1290
1291	if (i2c->irq) {
1292		init_waitqueue_head(&adv7511->wq);
1293
1294		ret = devm_request_threaded_irq(dev, i2c->irq, NULL,
1295						adv7511_irq_handler,
1296						IRQF_ONESHOT, dev_name(dev),
1297						adv7511);
1298		if (ret)
1299			goto err_unregister_cec;
1300	}
1301
1302	adv7511_power_off(adv7511);
1303
1304	i2c_set_clientdata(i2c, adv7511);
1305
1306	if (adv7511->type == ADV7511)
1307		adv7511_set_link_config(adv7511, &link_config);
1308
1309	ret = adv7511_cec_init(dev, adv7511);
1310	if (ret)
1311		goto err_unregister_cec;
1312
1313	adv7511->bridge.funcs = &adv7511_bridge_funcs;
1314	adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
1315			    | DRM_BRIDGE_OP_HPD;
1316	adv7511->bridge.of_node = dev->of_node;
1317	adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
1318
1319	drm_bridge_add(&adv7511->bridge);
1320
1321	adv7511_audio_init(dev, adv7511);
1322	return 0;
1323
1324err_unregister_cec:
1325	cec_unregister_adapter(adv7511->cec_adap);
1326	i2c_unregister_device(adv7511->i2c_cec);
1327	if (adv7511->cec_clk)
1328		clk_disable_unprepare(adv7511->cec_clk);
1329err_i2c_unregister_packet:
1330	i2c_unregister_device(adv7511->i2c_packet);
1331err_i2c_unregister_edid:
1332	i2c_unregister_device(adv7511->i2c_edid);
1333uninit_regulators:
1334	adv7511_uninit_regulators(adv7511);
1335
1336	return ret;
1337}
1338
1339static int adv7511_remove(struct i2c_client *i2c)
1340{
1341	struct adv7511 *adv7511 = i2c_get_clientdata(i2c);
1342
1343	if (adv7511->type == ADV7533 || adv7511->type == ADV7535)
1344		adv7533_detach_dsi(adv7511);
1345	i2c_unregister_device(adv7511->i2c_cec);
1346	if (adv7511->cec_clk)
1347		clk_disable_unprepare(adv7511->cec_clk);
1348
1349	adv7511_uninit_regulators(adv7511);
1350
1351	drm_bridge_remove(&adv7511->bridge);
1352
1353	adv7511_audio_exit(adv7511);
1354
1355	cec_unregister_adapter(adv7511->cec_adap);
1356
1357	i2c_unregister_device(adv7511->i2c_packet);
1358	i2c_unregister_device(adv7511->i2c_edid);
1359
1360	return 0;
1361}
1362
1363static const struct i2c_device_id adv7511_i2c_ids[] = {
1364	{ "adv7511", ADV7511 },
1365	{ "adv7511w", ADV7511 },
1366	{ "adv7513", ADV7511 },
1367	{ "adv7533", ADV7533 },
1368	{ "adv7535", ADV7535 },
1369	{ }
1370};
1371MODULE_DEVICE_TABLE(i2c, adv7511_i2c_ids);
1372
1373static const struct of_device_id adv7511_of_ids[] = {
1374	{ .compatible = "adi,adv7511", .data = (void *)ADV7511 },
1375	{ .compatible = "adi,adv7511w", .data = (void *)ADV7511 },
1376	{ .compatible = "adi,adv7513", .data = (void *)ADV7511 },
1377	{ .compatible = "adi,adv7533", .data = (void *)ADV7533 },
1378	{ .compatible = "adi,adv7535", .data = (void *)ADV7535 },
1379	{ }
1380};
1381MODULE_DEVICE_TABLE(of, adv7511_of_ids);
1382
1383static struct mipi_dsi_driver adv7533_dsi_driver = {
1384	.driver.name = "adv7533",
1385};
1386
1387static struct i2c_driver adv7511_driver = {
1388	.driver = {
1389		.name = "adv7511",
1390		.of_match_table = adv7511_of_ids,
1391	},
1392	.id_table = adv7511_i2c_ids,
1393	.probe = adv7511_probe,
1394	.remove = adv7511_remove,
1395};
1396
1397static int __init adv7511_init(void)
1398{
1399	int ret;
1400
1401	if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) {
1402		ret = mipi_dsi_driver_register(&adv7533_dsi_driver);
1403		if (ret)
1404			return ret;
1405	}
1406
1407	ret = i2c_add_driver(&adv7511_driver);
1408	if (ret) {
1409		if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
1410			mipi_dsi_driver_unregister(&adv7533_dsi_driver);
1411	}
1412
1413	return ret;
1414}
1415module_init(adv7511_init);
1416
1417static void __exit adv7511_exit(void)
1418{
1419	i2c_del_driver(&adv7511_driver);
1420
1421	if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
1422		mipi_dsi_driver_unregister(&adv7533_dsi_driver);
1423}
1424module_exit(adv7511_exit);
1425
1426MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
1427MODULE_DESCRIPTION("ADV7511 HDMI transmitter driver");
1428MODULE_LICENSE("GPL");
1429