// Copyright 2014 the V8 project authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include #include #include "src/builtins/accessors.h" #include "src/common/globals.h" #include "src/common/message-template.h" #include "src/debug/debug.h" #include "src/execution/arguments-inl.h" #include "src/execution/frames-inl.h" #include "src/execution/isolate-inl.h" #include "src/logging/counters.h" #include "src/logging/log.h" #include "src/objects/elements.h" #include "src/objects/hash-table-inl.h" #include "src/objects/literal-objects-inl.h" #include "src/objects/lookup-inl.h" #include "src/objects/smi.h" #include "src/objects/struct-inl.h" #include "src/runtime/runtime-utils.h" #include "src/runtime/runtime.h" namespace v8 { namespace internal { RUNTIME_FUNCTION(Runtime_ThrowUnsupportedSuperError) { HandleScope scope(isolate); DCHECK_EQ(0, args.length()); THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewReferenceError(MessageTemplate::kUnsupportedSuper)); } RUNTIME_FUNCTION(Runtime_ThrowConstructorNonCallableError) { HandleScope scope(isolate); DCHECK_EQ(1, args.length()); Handle constructor = args.at(0); Handle name(constructor->shared().Name(), isolate); Handle context = handle(constructor->native_context(), isolate); DCHECK(context->IsNativeContext()); Handle realm_type_error_function( JSFunction::cast(context->get(Context::TYPE_ERROR_FUNCTION_INDEX)), isolate); if (name->length() == 0) { THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewError(realm_type_error_function, MessageTemplate::kAnonymousConstructorNonCallable)); } THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewError(realm_type_error_function, MessageTemplate::kConstructorNonCallable, name)); } RUNTIME_FUNCTION(Runtime_ThrowStaticPrototypeError) { HandleScope scope(isolate); DCHECK_EQ(0, args.length()); THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewTypeError(MessageTemplate::kStaticPrototype)); } RUNTIME_FUNCTION(Runtime_ThrowSuperAlreadyCalledError) { HandleScope scope(isolate); DCHECK_EQ(0, args.length()); THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewReferenceError(MessageTemplate::kSuperAlreadyCalled)); } RUNTIME_FUNCTION(Runtime_ThrowSuperNotCalled) { HandleScope scope(isolate); DCHECK_EQ(0, args.length()); THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewReferenceError(MessageTemplate::kSuperNotCalled)); } namespace { Object ThrowNotSuperConstructor(Isolate* isolate, Handle constructor, Handle function) { Handle super_name; if (constructor->IsJSFunction()) { super_name = handle(Handle::cast(constructor)->shared().Name(), isolate); } else if (constructor->IsOddball()) { DCHECK(constructor->IsNull(isolate)); super_name = isolate->factory()->null_string(); } else { super_name = Object::NoSideEffectsToString(isolate, constructor); } // null constructor if (super_name->length() == 0) { super_name = isolate->factory()->null_string(); } Handle function_name(function->shared().Name(), isolate); // anonymous class if (function_name->length() == 0) { THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewTypeError(MessageTemplate::kNotSuperConstructorAnonymousClass, super_name)); } THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewTypeError(MessageTemplate::kNotSuperConstructor, super_name, function_name)); } } // namespace RUNTIME_FUNCTION(Runtime_ThrowNotSuperConstructor) { HandleScope scope(isolate); DCHECK_EQ(2, args.length()); Handle constructor = args.at(0); Handle function = args.at(1); return ThrowNotSuperConstructor(isolate, constructor, function); } namespace { template Handle KeyToName(Isolate* isolate, Handle key) { STATIC_ASSERT((std::is_same::value || std::is_same::value)); DCHECK(key->IsName()); return Handle::cast(key); } template <> Handle KeyToName(Isolate* isolate, Handle key) { DCHECK(key->IsNumber()); return isolate->factory()->NumberToString(key); } // Gets |index|'th argument which may be a class constructor object, a class // prototype object or a class method. In the latter case the following // post-processing may be required: // 1) set method's name to a concatenation of |name_prefix| and |key| if the // method's shared function info indicates that method does not have a // shared name. template MaybeHandle GetMethodAndSetName(Isolate* isolate, RuntimeArguments& args, Smi index, Handle name_prefix, Handle key) { int int_index = index.value(); // Class constructor and prototype values do not require post processing. if (int_index < ClassBoilerplate::kFirstDynamicArgumentIndex) { return args.at(int_index); } Handle method = args.at(int_index); if (!method->shared().HasSharedName()) { // TODO(ishell): method does not have a shared name at this point only if // the key is a computed property name. However, the bytecode generator // explicitly generates ToName bytecodes to ensure that the computed // property name is properly converted to Name. So, we can actually be smart // here and avoid converting Smi keys back to Name. Handle name = KeyToName(isolate, key); if (!JSFunction::SetName(method, name, name_prefix)) { return MaybeHandle(); } } return method; } // Gets |index|'th argument which may be a class constructor object, a class // prototype object or a class method. // This is a simplified version of GetMethodAndSetName() // function above that is used when it's guaranteed that the method has // shared name. Object GetMethodWithSharedName(Isolate* isolate, RuntimeArguments& args, Object index) { DisallowGarbageCollection no_gc; int int_index = Smi::ToInt(index); // Class constructor and prototype values do not require post processing. if (int_index < ClassBoilerplate::kFirstDynamicArgumentIndex) { return args[int_index]; } Handle method = args.at(int_index); DCHECK(method->shared().HasSharedName()); return *method; } template Handle ShallowCopyDictionaryTemplate( Isolate* isolate, Handle dictionary_template) { Handle dictionary = Dictionary::ShallowCopy(isolate, dictionary_template); // Clone all AccessorPairs in the dictionary. for (InternalIndex i : dictionary->IterateEntries()) { Object value = dictionary->ValueAt(i); if (value.IsAccessorPair()) { Handle pair(AccessorPair::cast(value), isolate); pair = AccessorPair::Copy(isolate, pair); dictionary->ValueAtPut(i, *pair); } } return dictionary; } template bool SubstituteValues(Isolate* isolate, Handle dictionary, RuntimeArguments& args) { // Replace all indices with proper methods. ReadOnlyRoots roots(isolate); for (InternalIndex i : dictionary->IterateEntries()) { Object maybe_key = dictionary->KeyAt(i); if (!Dictionary::IsKey(roots, maybe_key)) continue; Handle key(maybe_key, isolate); Handle value(dictionary->ValueAt(i), isolate); if (value->IsAccessorPair()) { Handle pair = Handle::cast(value); Object tmp = pair->getter(); if (tmp.IsSmi()) { Handle result; ASSIGN_RETURN_ON_EXCEPTION_VALUE( isolate, result, GetMethodAndSetName(isolate, args, Smi::cast(tmp), isolate->factory()->get_string(), key), false); pair->set_getter(*result); } tmp = pair->setter(); if (tmp.IsSmi()) { Handle result; ASSIGN_RETURN_ON_EXCEPTION_VALUE( isolate, result, GetMethodAndSetName(isolate, args, Smi::cast(tmp), isolate->factory()->set_string(), key), false); pair->set_setter(*result); } } else if (value->IsSmi()) { Handle result; ASSIGN_RETURN_ON_EXCEPTION_VALUE( isolate, result, GetMethodAndSetName(isolate, args, Smi::cast(*value), isolate->factory()->empty_string(), key), false); dictionary->ValueAtPut(i, *result); } } return true; } template void UpdateProtectors(Isolate* isolate, Handle receiver, Handle properties_dictionary) { ReadOnlyRoots roots(isolate); for (InternalIndex i : properties_dictionary->IterateEntries()) { Object maybe_key = properties_dictionary->KeyAt(i); if (!Dictionary::IsKey(roots, maybe_key)) continue; Handle name(Name::cast(maybe_key), isolate); LookupIterator::UpdateProtector(isolate, receiver, name); } } void UpdateProtectors(Isolate* isolate, Handle receiver, Handle properties_template) { int nof_descriptors = properties_template->number_of_descriptors(); for (InternalIndex i : InternalIndex::Range(nof_descriptors)) { Handle name(properties_template->GetKey(i), isolate); LookupIterator::UpdateProtector(isolate, receiver, name); } } bool AddDescriptorsByTemplate( Isolate* isolate, Handle map, Handle descriptors_template, Handle elements_dictionary_template, Handle receiver, RuntimeArguments& args) { int nof_descriptors = descriptors_template->number_of_descriptors(); Handle descriptors = DescriptorArray::Allocate(isolate, nof_descriptors, 0); Handle elements_dictionary = *elements_dictionary_template == ReadOnlyRoots(isolate).empty_slow_element_dictionary() ? elements_dictionary_template : ShallowCopyDictionaryTemplate(isolate, elements_dictionary_template); // Count the number of properties that must be in the instance and // create the property array to hold the constants. int count = 0; for (InternalIndex i : InternalIndex::Range(nof_descriptors)) { PropertyDetails details = descriptors_template->GetDetails(i); if (details.location() == PropertyLocation::kDescriptor && details.kind() == PropertyKind::kData) { count++; } } Handle property_array = isolate->factory()->NewPropertyArray(count); // Read values from |descriptors_template| and store possibly post-processed // values into "instantiated" |descriptors| array. int field_index = 0; for (InternalIndex i : InternalIndex::Range(nof_descriptors)) { Object value = descriptors_template->GetStrongValue(i); if (value.IsAccessorPair()) { Handle pair = AccessorPair::Copy( isolate, handle(AccessorPair::cast(value), isolate)); value = *pair; } DisallowGarbageCollection no_gc; Name name = descriptors_template->GetKey(i); DCHECK(name.IsUniqueName()); PropertyDetails details = descriptors_template->GetDetails(i); if (details.location() == PropertyLocation::kDescriptor) { if (details.kind() == PropertyKind::kData) { if (value.IsSmi()) { value = GetMethodWithSharedName(isolate, args, value); } details = details.CopyWithRepresentation( value.OptimalRepresentation(isolate)); } else { DCHECK_EQ(PropertyKind::kAccessor, details.kind()); if (value.IsAccessorPair()) { AccessorPair pair = AccessorPair::cast(value); Object tmp = pair.getter(); if (tmp.IsSmi()) { pair.set_getter(GetMethodWithSharedName(isolate, args, tmp)); } tmp = pair.setter(); if (tmp.IsSmi()) { pair.set_setter(GetMethodWithSharedName(isolate, args, tmp)); } } } } else { UNREACHABLE(); } DCHECK(value.FitsRepresentation(details.representation())); if (details.location() == PropertyLocation::kDescriptor && details.kind() == PropertyKind::kData) { details = PropertyDetails(details.kind(), details.attributes(), PropertyLocation::kField, PropertyConstness::kConst, details.representation(), field_index) .set_pointer(details.pointer()); property_array->set(field_index, value); field_index++; descriptors->Set(i, name, MaybeObject::FromObject(FieldType::Any()), details); } else { descriptors->Set(i, name, MaybeObject::FromObject(value), details); } } UpdateProtectors(isolate, receiver, descriptors_template); map->InitializeDescriptors(isolate, *descriptors); if (elements_dictionary->NumberOfElements() > 0) { if (!SubstituteValues(isolate, elements_dictionary, args)) { return false; } map->set_elements_kind(DICTIONARY_ELEMENTS); } // Atomically commit the changes. receiver->set_map(*map, kReleaseStore); if (elements_dictionary->NumberOfElements() > 0) { receiver->set_elements(*elements_dictionary); } if (property_array->length() > 0) { receiver->SetProperties(*property_array); } return true; } // TODO(v8:7569): This is a workaround for the Handle vs MaybeHandle difference // in the return types of the different Add functions: // OrderedNameDictionary::Add returns MaybeHandle, NameDictionary::Add returns // Handle. template Handle ToHandle(Handle h) { return h; } template Handle ToHandle(MaybeHandle h) { return h.ToHandleChecked(); } template bool AddDescriptorsByTemplate( Isolate* isolate, Handle map, Handle properties_dictionary_template, Handle elements_dictionary_template, Handle computed_properties, Handle receiver, RuntimeArguments& args) { int computed_properties_length = computed_properties->length(); // Shallow-copy properties template. Handle properties_dictionary = ShallowCopyDictionaryTemplate(isolate, properties_dictionary_template); Handle elements_dictionary = ShallowCopyDictionaryTemplate(isolate, elements_dictionary_template); using ValueKind = ClassBoilerplate::ValueKind; using ComputedEntryFlags = ClassBoilerplate::ComputedEntryFlags; // Merge computed properties with properties and elements dictionary // templates. int i = 0; while (i < computed_properties_length) { int flags = Smi::ToInt(computed_properties->get(i++)); ValueKind value_kind = ComputedEntryFlags::ValueKindBits::decode(flags); int key_index = ComputedEntryFlags::KeyIndexBits::decode(flags); Smi value = Smi::FromInt(key_index + 1); // Value follows name. Handle key = args.at(key_index); DCHECK(key->IsName()); uint32_t element; Handle name = Handle::cast(key); if (name->AsArrayIndex(&element)) { ClassBoilerplate::AddToElementsTemplate( isolate, elements_dictionary, element, key_index, value_kind, value); } else { name = isolate->factory()->InternalizeName(name); ClassBoilerplate::AddToPropertiesTemplate( isolate, properties_dictionary, name, key_index, value_kind, value); } } // Replace all indices with proper methods. if (!SubstituteValues(isolate, properties_dictionary, args)) { return false; } UpdateProtectors(isolate, receiver, properties_dictionary); if (elements_dictionary->NumberOfElements() > 0) { if (!SubstituteValues(isolate, elements_dictionary, args)) { return false; } map->set_elements_kind(DICTIONARY_ELEMENTS); } // Atomically commit the changes. receiver->set_map(*map, kReleaseStore); receiver->set_raw_properties_or_hash(*properties_dictionary, kRelaxedStore); if (elements_dictionary->NumberOfElements() > 0) { receiver->set_elements(*elements_dictionary); } return true; } Handle CreateClassPrototype(Isolate* isolate) { // For constant tracking we want to avoid the hassle of handling // in-object properties, so create a map with no in-object // properties. // TODO(ishell) Support caching of zero in-object properties map // by ObjectLiteralMapFromCache(). Handle map = Map::Create(isolate, 0); return isolate->factory()->NewJSObjectFromMap(map); } bool InitClassPrototype(Isolate* isolate, Handle class_boilerplate, Handle prototype, Handle prototype_parent, Handle constructor, RuntimeArguments& args) { Handle map(prototype->map(), isolate); map = Map::CopyDropDescriptors(isolate, map); map->set_is_prototype_map(true); Map::SetPrototype(isolate, map, prototype_parent); constructor->set_prototype_or_initial_map(*prototype, kReleaseStore); map->SetConstructor(*constructor); Handle computed_properties( class_boilerplate->instance_computed_properties(), isolate); Handle elements_dictionary_template( NumberDictionary::cast(class_boilerplate->instance_elements_template()), isolate); Handle properties_template( class_boilerplate->instance_properties_template(), isolate); if (properties_template->IsDescriptorArray()) { Handle descriptors_template = Handle::cast(properties_template); // The size of the prototype object is known at this point. // So we can create it now and then add the rest instance methods to the // map. return AddDescriptorsByTemplate(isolate, map, descriptors_template, elements_dictionary_template, prototype, args); } else { map->set_is_dictionary_map(true); map->set_is_migration_target(false); map->set_may_have_interesting_symbols(true); map->set_construction_counter(Map::kNoSlackTracking); if (V8_ENABLE_SWISS_NAME_DICTIONARY_BOOL) { Handle properties_dictionary_template = Handle::cast(properties_template); return AddDescriptorsByTemplate( isolate, map, properties_dictionary_template, elements_dictionary_template, computed_properties, prototype, args); } else { Handle properties_dictionary_template = Handle::cast(properties_template); return AddDescriptorsByTemplate( isolate, map, properties_dictionary_template, elements_dictionary_template, computed_properties, prototype, args); } } } bool InitClassConstructor(Isolate* isolate, Handle class_boilerplate, Handle constructor_parent, Handle constructor, RuntimeArguments& args) { Handle map(constructor->map(), isolate); map = Map::CopyDropDescriptors(isolate, map); DCHECK(map->is_prototype_map()); if (!constructor_parent.is_null()) { // Set map's prototype without enabling prototype setup mode for superclass // because it does not make sense. Map::SetPrototype(isolate, map, constructor_parent, false); // Ensure that setup mode will never be enabled for superclass. JSObject::MakePrototypesFast(constructor_parent, kStartAtReceiver, isolate); } Handle elements_dictionary_template( NumberDictionary::cast(class_boilerplate->static_elements_template()), isolate); Handle computed_properties( class_boilerplate->static_computed_properties(), isolate); Handle properties_template( class_boilerplate->static_properties_template(), isolate); if (properties_template->IsDescriptorArray()) { Handle descriptors_template = Handle::cast(properties_template); return AddDescriptorsByTemplate(isolate, map, descriptors_template, elements_dictionary_template, constructor, args); } else { map->set_is_dictionary_map(true); map->InitializeDescriptors(isolate, ReadOnlyRoots(isolate).empty_descriptor_array()); map->set_is_migration_target(false); map->set_may_have_interesting_symbols(true); map->set_construction_counter(Map::kNoSlackTracking); if (V8_ENABLE_SWISS_NAME_DICTIONARY_BOOL) { Handle properties_dictionary_template = Handle::cast(properties_template); return AddDescriptorsByTemplate( isolate, map, properties_dictionary_template, elements_dictionary_template, computed_properties, constructor, args); } else { Handle properties_dictionary_template = Handle::cast(properties_template); return AddDescriptorsByTemplate( isolate, map, properties_dictionary_template, elements_dictionary_template, computed_properties, constructor, args); } } } MaybeHandle DefineClass(Isolate* isolate, Handle class_boilerplate, Handle super_class, Handle constructor, RuntimeArguments& args) { Handle prototype_parent; Handle constructor_parent; if (super_class->IsTheHole(isolate)) { prototype_parent = isolate->initial_object_prototype(); } else { if (super_class->IsNull(isolate)) { prototype_parent = isolate->factory()->null_value(); } else if (super_class->IsConstructor()) { DCHECK(!super_class->IsJSFunction() || !IsResumableFunction( Handle::cast(super_class)->shared().kind())); ASSIGN_RETURN_ON_EXCEPTION( isolate, prototype_parent, Runtime::GetObjectProperty(isolate, super_class, isolate->factory()->prototype_string()), Object); if (!prototype_parent->IsNull(isolate) && !prototype_parent->IsJSReceiver()) { THROW_NEW_ERROR( isolate, NewTypeError(MessageTemplate::kPrototypeParentNotAnObject, prototype_parent), Object); } // Create new handle to avoid |constructor_parent| corruption because of // |super_class| handle value overwriting via storing to // args[ClassBoilerplate::kPrototypeArgumentIndex] below. constructor_parent = handle(HeapObject::cast(*super_class), isolate); } else { THROW_NEW_ERROR(isolate, NewTypeError(MessageTemplate::kExtendsValueNotConstructor, super_class), Object); } } Handle prototype = CreateClassPrototype(isolate); DCHECK_EQ(*constructor, args[ClassBoilerplate::kConstructorArgumentIndex]); // Temporarily change ClassBoilerplate::kPrototypeArgumentIndex for the // subsequent calls, but use a scope to make sure to change it back before // returning, to not corrupt the caller's argument frame (in particular, for // the interpreter, to not clobber the register frame). RuntimeArguments::ChangeValueScope set_prototype_value_scope( isolate, &args, ClassBoilerplate::kPrototypeArgumentIndex, *prototype); if (!InitClassConstructor(isolate, class_boilerplate, constructor_parent, constructor, args) || !InitClassPrototype(isolate, class_boilerplate, prototype, Handle::cast(prototype_parent), constructor, args)) { DCHECK(isolate->has_pending_exception()); return MaybeHandle(); } if (FLAG_log_maps) { Handle empty_map; LOG(isolate, MapEvent("InitialMap", empty_map, handle(constructor->map(), isolate), "init class constructor", SharedFunctionInfo::DebugName( handle(constructor->shared(), isolate)))); LOG(isolate, MapEvent("InitialMap", empty_map, handle(prototype->map(), isolate), "init class prototype")); } return prototype; } } // namespace RUNTIME_FUNCTION(Runtime_DefineClass) { HandleScope scope(isolate); DCHECK_LE(ClassBoilerplate::kFirstDynamicArgumentIndex, args.length()); Handle class_boilerplate = args.at(0); Handle constructor = args.at(1); Handle super_class = args.at(2); DCHECK_EQ(class_boilerplate->arguments_count(), args.length()); RETURN_RESULT_OR_FAILURE( isolate, DefineClass(isolate, class_boilerplate, super_class, constructor, args)); } namespace { enum class SuperMode { kLoad, kStore }; MaybeHandle GetSuperHolder(Isolate* isolate, Handle home_object, SuperMode mode, PropertyKey* key) { if (home_object->IsAccessCheckNeeded() && !isolate->MayAccess(handle(isolate->context(), isolate), home_object)) { isolate->ReportFailedAccessCheck(home_object); RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, JSReceiver); } PrototypeIterator iter(isolate, home_object); Handle proto = PrototypeIterator::GetCurrent(iter); if (!proto->IsJSReceiver()) { MessageTemplate message = mode == SuperMode::kLoad ? MessageTemplate::kNonObjectPropertyLoadWithProperty : MessageTemplate::kNonObjectPropertyStoreWithProperty; Handle name = key->GetName(isolate); THROW_NEW_ERROR(isolate, NewTypeError(message, proto, name), JSReceiver); } return Handle::cast(proto); } MaybeHandle LoadFromSuper(Isolate* isolate, Handle receiver, Handle home_object, PropertyKey* key) { Handle holder; ASSIGN_RETURN_ON_EXCEPTION( isolate, holder, GetSuperHolder(isolate, home_object, SuperMode::kLoad, key), Object); LookupIterator it(isolate, receiver, *key, holder); Handle result; ASSIGN_RETURN_ON_EXCEPTION(isolate, result, Object::GetProperty(&it), Object); return result; } } // anonymous namespace RUNTIME_FUNCTION(Runtime_LoadFromSuper) { HandleScope scope(isolate); DCHECK_EQ(3, args.length()); Handle receiver = args.at(0); Handle home_object = args.at(1); Handle name = args.at(2); PropertyKey key(isolate, name); RETURN_RESULT_OR_FAILURE(isolate, LoadFromSuper(isolate, receiver, home_object, &key)); } RUNTIME_FUNCTION(Runtime_LoadKeyedFromSuper) { HandleScope scope(isolate); DCHECK_EQ(3, args.length()); Handle receiver = args.at(0); Handle home_object = args.at(1); // TODO(ishell): To improve performance, consider performing the to-string // conversion of {key} before calling into the runtime. Handle key = args.at(2); bool success; PropertyKey lookup_key(isolate, key, &success); if (!success) return ReadOnlyRoots(isolate).exception(); RETURN_RESULT_OR_FAILURE( isolate, LoadFromSuper(isolate, receiver, home_object, &lookup_key)); } namespace { MaybeHandle StoreToSuper(Isolate* isolate, Handle home_object, Handle receiver, PropertyKey* key, Handle value, StoreOrigin store_origin) { Handle holder; ASSIGN_RETURN_ON_EXCEPTION( isolate, holder, GetSuperHolder(isolate, home_object, SuperMode::kStore, key), Object); LookupIterator it(isolate, receiver, *key, holder); MAYBE_RETURN(Object::SetSuperProperty(&it, value, store_origin), MaybeHandle()); return value; } } // anonymous namespace RUNTIME_FUNCTION(Runtime_StoreToSuper) { HandleScope scope(isolate); DCHECK_EQ(4, args.length()); Handle receiver = args.at(0); Handle home_object = args.at(1); Handle name = args.at(2); Handle value = args.at(3); PropertyKey key(isolate, name); RETURN_RESULT_OR_FAILURE( isolate, StoreToSuper(isolate, home_object, receiver, &key, value, StoreOrigin::kNamed)); } RUNTIME_FUNCTION(Runtime_StoreKeyedToSuper) { HandleScope scope(isolate); DCHECK_EQ(4, args.length()); Handle receiver = args.at(0); Handle home_object = args.at(1); // TODO(ishell): To improve performance, consider performing the to-string // conversion of {key} before calling into the runtime. Handle key = args.at(2); Handle value = args.at(3); bool success; PropertyKey lookup_key(isolate, key, &success); if (!success) return ReadOnlyRoots(isolate).exception(); RETURN_RESULT_OR_FAILURE( isolate, StoreToSuper(isolate, home_object, receiver, &lookup_key, value, StoreOrigin::kMaybeKeyed)); } } // namespace internal } // namespace v8